Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECAL online DQM timing conditions tag override - 132x - do not merge #42855

Conversation

thomreis
Copy link
Contributor

PR description:

This PR is intended for the online DQM during the HI run 2023. Do not merge it in official 13_2_X.

The ECAL timing calibration constants and timing offset constants in the GT will be overridden by tags containing conditions for the CC timing. This is needed because the HLT GT used in the online DQM configuration contains the conditions for the ratio timing method running at the HLT.

PR validation:

Run the ecal_dqm_sourceclient-live_cfg.py configuration.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_13_2_X.

It involves the following packages:

  • DQM/Integration (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@batinkov, @rchatter, @argiro, @thomreis, @wang0jin, @threus, @francescobrivio this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b993ad/34891/summary.html
COMMIT: ad270a4
CMSSW: CMSSW_13_2_X_2023-09-25-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42855/34891/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198243
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198212
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Oct 3, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@tjavaid
Copy link

tjavaid commented Oct 3, 2023

hold

  • a temporary fix, not intended to be merged it in official 13_2_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2023

Pull request has been put on hold by @tjavaid
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@tjavaid
Copy link

tjavaid commented Oct 5, 2023

@thomreis , perhaps you would like to close this PR since #42933 has already been there and deployed online?

@thomreis
Copy link
Contributor Author

thomreis commented Oct 5, 2023

Hi @tjavaid yes we are closing this PR.
We were not notified that it had been deployed yesterday already in fact.

@thomreis thomreis closed this Oct 5, 2023
@thomreis thomreis deleted the ecal-online-dqm-timing-tag-override-132x branch October 5, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants