Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the ratio timing method for ECAL online DQM - 131X #43023

Conversation

thomreis
Copy link
Contributor

PR description:

This PR sets the ECAL timing algorithm used in the online DQM reconstruction to the ratio method. Like this the online DQM monitors the algorithm that is used at the HLT and can also directly use the calibrations and offsets from the HLT GT.

This PR should replace #42855 on the online DQM.

PR validation:

Ran ecal_dqm_sourceclient-live_cfg.py configuration locally.

Backport of #42932

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 16, 2023

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_13_1_X.

It involves the following packages:

  • DQM/Integration (dqm)

@antoniovagnerini, @syuvivida, @cmsbuild, @nothingface0, @tjavaid, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @rchatter, @francescobrivio, @thomreis, @wang0jin, @argiro, @batinkov this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor Author

type ecal

@cmsbuild cmsbuild added the ecal label Oct 16, 2023
@thomreis
Copy link
Contributor Author

backport of #42932

@thomreis
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f6638/35202/summary.html
COMMIT: 2a83f46
CMSSW: CMSSW_13_1_X_2023-10-15-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43023/35202/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196443
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196421
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Oct 16, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 059379c into cms-sw:CMSSW_13_1_X Oct 16, 2023
@thomreis thomreis deleted the ecal-online-dqm-ratio-timing-default-131x branch February 2, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants