Use ECAL ratio timing algorithm for Run 1 and Run 2, and CC timing algorithm for Run 3 and beyond #42928

thomreis · 2023-10-02T13:51:46Z

PR description:

This PR sets the default ECAL timing algorithm to the ratio method. This is the default timing algorithm for Run 1 and Run 2.
For Run 3 and Phase 2 a new modifier run3_ecal is used to change the timing algorithm to CC timing and use different records with the label 'CC' for the timing calibrations and timing offset constants.

Note that this behaviour is different than what was discussed in the meeting on the 27th Sept. when the plan was made to make the CC timing the default and use eras to modify Run 1 and Run 2 configurations to use the ratio method. Since Run 1 configurations could not be modified using eras we decided to reverse the behaviour as in the description above.

PR validation:

The PR passes Run 1 and Run2 WFs in the limited matrix tests but currently fails all Run 3 and Phase 2 WFs because the consumed records with the 'CC' label are not yet in the GTs.

…3 and use ratio timing for Run1 and Run2.

thomreis · 2023-10-02T13:54:36Z

type ecal

cmsbuild · 2023-10-02T13:57:27Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42928/37070

This PR adds an extra 24KB to repository

cmsbuild · 2023-10-02T13:57:53Z

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

Configuration/Eras (operations)
RecoLocalCalo/EcalRecProducers (reconstruction)

@rappoccio, @fabiocos, @davidlange6, @jfernan2, @cmsbuild, @antoniovilela, @mandrenguyen can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis, @apsallid, @fabiocos, @youyingli, @rchatter, @argiro, @makortel, @wang0jin, @missirol, @AnnikaStein this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

saumyaphor4252 · 2023-10-02T18:56:04Z

@cmsbuild, please test

cmsbuild · 2023-10-02T20:22:41Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cefc69/35015/summary.html
COMMIT: 0e5e58d
CMSSW: CMSSW_13_3_X_2023-10-02-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42928/35015/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 3 errors in the following unit tests:

---> test TestDQMOnlineClient-ecal_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-visualization had ERRORS
---> test TestDQMOnlineClient-visualization_secondInstance had ERRORS

RelVals

138.4

----- Begin Fatal Exception 02-Oct-2023 21:29:41 CEST-----------------------
An exception of category 'NoProductResolverException' occurred while
   [0] Processing  Event run: 346512 lumi: 250 event: 243042266 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Prefetching for module DQMMessageLogger/'DQMMessageLogger'
   [3] Prefetching for module LogErrorHarvester/'logErrorHarvester'
   [4] Prefetching for module EcalRecHitProducer/'ecalRecHit@cpu'
   [5] Calling method for module EcalUncalibRecHitProducer/'ecalMultiFitUncalibRecHit@cpu'
Exception Message:
No data of type "EcalTimeOffsetConstant" with label "CC" in record "EcalTimeOffsetConstantRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

138.5

----- Begin Fatal Exception 02-Oct-2023 21:29:56 CEST-----------------------
An exception of category 'NoProductResolverException' occurred while
   [0] Processing  Event run: 346512 lumi: 250 event: 243042266 stream: 0
   [1] Running path 'dqmoffline_13_step'
   [2] Prefetching for module SMPDQM/'SMPDQM'
   [3] Prefetching for module MuonProducer/'muons'
   [4] Prefetching for module MuonIdProducer/'muons1stStep'
   [5] Prefetching for module EcalRecHitProducer/'ecalRecHit@cpu'
   [6] Calling method for module EcalUncalibRecHitProducer/'ecalMultiFitUncalibRecHit@cpu'
Exception Message:
No data of type "EcalTimeOffsetConstant" with label "CC" in record "EcalTimeOffsetConstantRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

139.001

----- Begin Fatal Exception 02-Oct-2023 21:34:10 CEST-----------------------
An exception of category 'NoProductResolverException' occurred while
   [0] Processing  Event run: 346512 lumi: 250 event: 243042266 stream: 0
   [1] Running path 'dqmofflineOnPAT_1_step'
   [2] Prefetching for module SingleTopTChannelLeptonDQM_miniAOD/'singleTopElectronMediumDQM_miniAOD'
   [3] Prefetching for module PATMuonSlimmer/'slimmedMuons'
   [4] Prefetching for module PATMuonSelector/'selectedPatMuons'
   [5] Prefetching for module PATMuonProducer/'patMuons'
   [6] Prefetching for module MuonProducer/'muons'
   [7] Prefetching for module MuonIdProducer/'muons1stStep'
   [8] Prefetching for module EcalRecHitProducer/'ecalRecHit@cpu'
   [9] Calling method for module EcalUncalibRecHitProducer/'ecalMultiFitUncalibRecHit@cpu'
Exception Message:
No data of type "EcalTimeOffsetConstant" with label "CC" in record "EcalTimeOffsetConstantRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

139.005139.005_AlCaPhiSym2021/step2_AlCaPhiSym2021.log
138.4138.4_PromptCollisions2021/step2_PromptCollisions2021.log
138.5138.5_ExpressCollisions2021/step2_ExpressCollisions2021.log

Expand to see more relval errors ...

AddOn Tests

hlt_mc_GRun

----- Begin Fatal Exception 02-Oct-2023 21:34:50 CEST-----------------------
An exception of category 'NoProductResolverException' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 4 stream: 3
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module CaloTowersCreator/'towerMaker'
   [4] Prefetching for module EcalRecHitProducer/'ecalRecHit@cpu'
   [5] Calling method for module EcalUncalibRecHitProducer/'ecalMultiFitUncalibRecHit@cpu'
Exception Message:
No data of type "EcalTimeOffsetConstant" with label "CC" in record "EcalTimeOffsetConstantRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

hlt_mc_HIon

----- Begin Fatal Exception 02-Oct-2023 21:33:28 CEST-----------------------
An exception of category 'NoProductResolverException' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 1
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module CaloTowersCreator/'towerMaker'
   [4] Prefetching for module EcalRecHitProducer/'ecalRecHit@cpu'
   [5] Calling method for module EcalUncalibRecHitProducer/'ecalMultiFitUncalibRecHit@cpu'
Exception Message:
No data of type "EcalTimeOffsetConstant" with label "CC" in record "EcalTimeOffsetConstantRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

hlt_mc_PIon

----- Begin Fatal Exception 02-Oct-2023 21:32:57 CEST-----------------------
An exception of category 'NoProductResolverException' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 1
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module CaloTowersCreator/'towerMaker'
   [4] Prefetching for module EcalRecHitProducer/'ecalRecHit@cpu'
   [5] Calling method for module EcalUncalibRecHitProducer/'ecalMultiFitUncalibRecHit@cpu'
Exception Message:
No data of type "EcalTimeOffsetConstant" with label "CC" in record "EcalTimeOffsetConstantRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

thomreis · 2023-10-03T07:47:12Z

As mentioned in the description exceptions of the NoProductResolverException are expected for this PR at the moment because the records are not yet in the GTs. @saumyaphor4252 if you are happy with the current result can we proceed and add them?

saumyaphor4252 · 2023-10-05T17:55:12Z

test parameters:

pull_request=Include ECAL Timing CC labelled tags in Run3 data and MC GTs #42958

saumyaphor4252 · 2023-10-05T17:56:06Z

@cmsbuild, please test

mmusich

just a minor suggestion, you can actually drop cms type specifications for extra safety.

RecoLocalCalo/EcalRecProducers/python/ecalMultiFitUncalibRecHit_cfi.py

cmsbuild · 2023-10-06T11:47:50Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cefc69/35079/summary.html
COMMIT: 3814335
CMSSW: CMSSW_13_3_X_2023-10-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42928/35079/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Done generating edm plugin poisoned information
gmake[1]: *** [config/SCRAM/GMake/Makefile.rules:1937: CompilePython] Error 1
>> Plugins of all types refreshed.
gmake[1]: Target 'PostBuild' not remade because of errors.
gmake[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_X_2023-10-06-1100'
gmake: *** [config/SCRAM/GMake/Makefile.rules:1825: src] Error 2
gmake: Target 'all' not remade because of errors.
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_X_2023-10-06-1100/tmp/el8_amd64_gcc11/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package Configuration/Eras

saumyaphor4252 · 2023-10-06T12:35:35Z

please test

Should work now, fixed a missing comma

cmsbuild · 2023-10-06T16:44:56Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cefc69/35084/summary.html
COMMIT: 3814335
CMSSW: CMSSW_13_3_X_2023-10-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42928/35084/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 130 lines to the logs
Reco comparison results: 19199 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3356920
DQMHistoTests: Total failures: 8908
DQMHistoTests: Total nulls: 6
DQMHistoTests: Total successes: 3347984
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.023 KiB( 49 files compared)
DQMHistoSizes: changed ( 4.53 ): -0.023 KiB JetMET/SUSYDQM
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: found differences in 5 / 48 workflows

thomreis · 2023-10-06T18:12:16Z

We expect changes in the ECAL timing with this PR since before many workflows were using the default CC timing algorithm but with the ratio timing calibrations in the GTs. This should be fixed now with this PR.

perrotta · 2023-10-10T11:54:25Z

urgent

ping @cms-sw/reconstruction-l2 @cms-sw/orp-l2 (for @cms-sw/operations-l2 )

mandrenguyen · 2023-10-10T12:05:15Z

@thomreis
I see the expected changes to the timing distributions.
Are very small changes to other distribution such as the following one also expected?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_13_3_X_2023-10-06-1100+cefc69/59157/validateJR/1000.0_RunMinBias2011A/all_RECO_step2_inAOD/c_log10max1e-5,recoSuperClusters_lowPtGsfElectronSuperClusters__RECO_obj_correctedEnergy.png

Just checking

thomreis · 2023-10-10T12:26:35Z

Yes it is possible that the changed timing has small effects on other distributions as well. Depending, e.g. how the out of time flag is set.

mandrenguyen · 2023-10-10T13:25:46Z

+reconstruction
I see a change to quantities related to ECAL time, as intended, and then small changes to other ECAL related quantities which are also expected, as indicated here.

rappoccio · 2023-10-10T14:38:33Z

+1

cmsbuild · 2023-10-10T14:38:58Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Get the CC labelled timing conditions for ECAL reconstruction for Run…

0e5e58d

…3 and use ratio timing for Run1 and Run2.

cmsbuild added this to the CMSSW_13_3_X milestone Oct 2, 2023

cmsbuild added reconstruction-pending operations-pending pending-signatures tests-pending orp-pending code-checks-pending labels Oct 2, 2023

cmsbuild added the ecal label Oct 2, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 2, 2023

cmsbuild added tests-started and removed tests-pending labels Oct 2, 2023

cmsbuild added tests-rejected and removed tests-started labels Oct 2, 2023

This was referenced Oct 4, 2023

Use ECAL ratio timing algorithm for Run 1 and Run 2, and CC timing algorithm for Run 3 and beyond - 132X #42946

Merged

Use ECAL ratio timing algorithm for Run 1 and Run 2, and CC timing algorithm for Run 3 and beyond - 131X #42947

Merged

saumyaphor4252 mentioned this pull request Oct 5, 2023

Include ECAL Timing CC labelled tags in Run3 data and MC GTs #42958

Merged

cmsbuild added the requires-external label Oct 5, 2023

cmsbuild added tests-started and removed tests-rejected labels Oct 5, 2023

mmusich reviewed Oct 5, 2023

View reviewed changes

RecoLocalCalo/EcalRecProducers/python/ecalMultiFitUncalibRecHit_cfi.py Outdated Show resolved Hide resolved

cmsbuild added the tests-rejected label Oct 6, 2023

cmsbuild added tests-started and removed tests-rejected labels Oct 6, 2023

cmsbuild added tests-approved and removed tests-started labels Oct 6, 2023

cmsbuild added the urgent label Oct 10, 2023

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Oct 10, 2023

cmsbuild added operations-approved fully-signed orp-approved and removed operations-pending pending-signatures orp-pending labels Oct 10, 2023

cmsbuild merged commit 5cde0d9 into cms-sw:master Oct 10, 2023

thomreis deleted the ecal-default-timing-cond-records branch February 2, 2024 14:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use ECAL ratio timing algorithm for Run 1 and Run 2, and CC timing algorithm for Run 3 and beyond #42928

Use ECAL ratio timing algorithm for Run 1 and Run 2, and CC timing algorithm for Run 3 and beyond #42928

thomreis commented Oct 2, 2023

thomreis commented Oct 2, 2023

cmsbuild commented Oct 2, 2023

cmsbuild commented Oct 2, 2023

saumyaphor4252 commented Oct 2, 2023

cmsbuild commented Oct 2, 2023

thomreis commented Oct 3, 2023

saumyaphor4252 commented Oct 5, 2023

saumyaphor4252 commented Oct 5, 2023

mmusich left a comment

cmsbuild commented Oct 6, 2023

saumyaphor4252 commented Oct 6, 2023

cmsbuild commented Oct 6, 2023

thomreis commented Oct 6, 2023

perrotta commented Oct 10, 2023

mandrenguyen commented Oct 10, 2023

thomreis commented Oct 10, 2023

mandrenguyen commented Oct 10, 2023

rappoccio commented Oct 10, 2023

cmsbuild commented Oct 10, 2023

Use ECAL ratio timing algorithm for Run 1 and Run 2, and CC timing algorithm for Run 3 and beyond #42928

Use ECAL ratio timing algorithm for Run 1 and Run 2, and CC timing algorithm for Run 3 and beyond #42928

Conversation

thomreis commented Oct 2, 2023

PR description:

PR validation:

thomreis commented Oct 2, 2023

cmsbuild commented Oct 2, 2023

cmsbuild commented Oct 2, 2023

saumyaphor4252 commented Oct 2, 2023

cmsbuild commented Oct 2, 2023

Unit Tests

RelVals

RelVals-INPUT

AddOn Tests

thomreis commented Oct 3, 2023

saumyaphor4252 commented Oct 5, 2023

saumyaphor4252 commented Oct 5, 2023

mmusich left a comment

Choose a reason for hiding this comment

cmsbuild commented Oct 6, 2023

Build

saumyaphor4252 commented Oct 6, 2023

cmsbuild commented Oct 6, 2023

Comparison Summary

thomreis commented Oct 6, 2023

perrotta commented Oct 10, 2023

mandrenguyen commented Oct 10, 2023

thomreis commented Oct 10, 2023

mandrenguyen commented Oct 10, 2023

rappoccio commented Oct 10, 2023

cmsbuild commented Oct 10, 2023