Include ECAL Timing CC labelled tags in Run3 data and MC GTs

[saumyaphor4252]

PR description:

This PR is mostly a follow-up to #42928 and adds the Ecal Timing CC labelled tags to

• Run3 Express, Prompt, offline data GTs
• Run3 MC GTs, and
• Phase2 MC GT

as follows:

For MC

Rcd	Label	Tag
EcalTimeOffsetConstantRcd	-	EcalTimeOffsetConstant_v01_mc
EcalTimeCalibConstantsRcd	-	EcalTimeCalibConstants_mc
EcalTimeOffsetConstantRcd	CC	EcalTimeOffsetConstant_cctiming_v01_mc
EcalTimeCalibConstantsRcd	CC	EcalTimeCalibConstants_mc

For Data:

Rcd	Label	HLT	Express	Prompt
EcalTimeOffsetConstantRcd	-	EcalTimeOffsetConstant_v01_hlt	EcalTimeOffsetConstant_v01_hlt	EcalTimeOffsetConstant_v01_hlt
EcalTimeCalibConstantsRcd	-	EcalTimeCalibConstants_v3_hlt	EcalTimeCalibConstants_v3_hlt	EcalTimeCalibConstants_v3_hlt
EcalTimeOffsetConstantRcd	CC	-	EcalTimeOffsetConstant_v01_express	EcalTimeOffsetConstant_v01_express
EcalTimeCalibConstantsRcd	CC	-	EcalTimeCalibConstants_v1_Express	EcalTimeCalibConstants_v01_prompt

Rcd	Label	PromptAnalysis	Offline
EcalTimeOffsetConstantRcd	-	EcalTimeOffsetConstant_v01_express	EcalTimeOffsetConstant_v01_offline
EcalTimeCalibConstantsRcd	-	EcalTimeCalibConstants_v01_prompt	EcalTimeCalibConstants_Run1_Run2_Run3_v03_offline
EcalTimeOffsetConstantRcd	CC	EcalTimeOffsetConstant_v01_express	EcalTimeOffsetConstant_cctiming_v01_offline
EcalTimeCalibConstantsRcd	CC	EcalTimeCalibConstants_v01_prompt	EcalTimeCalibConstants_Run1_Run2_Run3_v03_offline

The relevant CMS Talk posts and links for the mentioned changes are [1][2][3]

[1] https://indico.cern.ch/event/1329876/
[2] https://cms-talk.web.cern.ch/t/queues-133x-mc-and-data-queues-opened/29683
[3] https://cms-talk.web.cern.ch/t/full-track-validation-ecal-time-calibration-conditions-for-cc-timing-algorithm/28247

In addition, it also introduces a new key run3_data_PromptAnalysis to the autoCond. The corresponding GT is for the offline reprocessing happening with Prompt GTs. So far, the GT has conditions used for the 2022FG reprocessing and was last done in 130X cycle [4] with 130X_dataRun3_PromptAnalysis_v1. The difference between the 133X GT with the 130X GT used for nanov12 [4] is only the addition of the ECAL Timing CC labelled tags. (See in the diffs below). No workflow is testing this GT for now. We leave that to PdMV to include the relevant workflows at some point.

[4] https://cms-talk.web.cern.ch/t/mc-offline-rereco-gts-for-2022-remini-nano-v12-in-130x/29645

Apart from that it also does some minor changes:

• Updates the Run-3 data offline GT to fix the ES channel status tag
• Resnapshots the Run3 HLT GT
• Syncs the Express and Prompt GTs with current data-taking GTs
• Formats text

GT Differences with the last ones are here:

• Run3 data HLT : No change, just updated snapshot time

  • Diff with last GT: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/132X_dataRun3_HLT_frozen_v1/133X_dataRun3_HLT_frozen_v1
  • Diff from Current HLT GT: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/132X_dataRun3_HLT_v2/133X_dataRun3_HLT_frozen_v1

• Run3 data Express : Includes Ecal Timing CC labelled tags, and updates as per the current Express GT with new snapshot time

  • Diff with last GT: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/133X_dataRun3_Express_frozen_v1/132X_dataRun3_Express_frozen_v1
  • Diff from Current Express GT: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/133X_dataRun3_Express_frozen_v1/132X_dataRun3_Express_v4

• Run3 data Prompt : Includes Ecal Timing CC labelled tags, and updates as per the current Prompt GT with new snapshot time

  • Diff with last GT: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/133X_dataRun3_Prompt_frozen_v1/132X_dataRun3_Prompt_frozen_v1
  • Diff from Current Prompt GT: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/133X_dataRun3_Prompt_frozen_v1/132X_dataRun3_Prompt_v4

• Run3 data Offline : Includes Ecal Timing CC labelled tags and updates the ES Channel status tag to fix the wrong IOV upload 375472 instead of 374572
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/133X_dataRun3_v3/132X_dataRun3_v1

• Run3 data PromptAnalysis : New key for offline reprocessing with Prompt GTs; Includes Ecal Timing CC labelled tags from the last GT used for NANOv12 130X_dataRun3_PromptAnalysis_v1
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/133X_dataRun3_PromptAnalysis_v1/130X_dataRun3_PromptAnalysis_v1

• Phase1 2022 design : Includes Ecal Timing CC labelled tags
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/133X_mcRun3_2022_design_v1/132X_mcRun3_2022_design_v1

• Phase1 2022 realistic : Includes Ecal Timing CC labelled tags
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/133X_mcRun3_2022_realistic_v1/132X_mcRun3_2022_realistic_v2

• Phase1 2022 realistic postEE : Includes Ecal Timing CC labelled tags
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/133X_mcRun3_2022_realistic_postEE_v1/132X_mcRun3_2022_realistic_postEE_v2

• Phase1 2022 cosmics : Includes Ecal Timing CC labelled tags
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/133X_mcRun3_2022cosmics_realistic_deco_v1/132X_mcRun3_2022cosmics_realistic_deco_v2

• Phase1 2022 cosmics design : Includes Ecal Timing CC labelled tags
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/133X_mcRun3_2022cosmics_design_deco_v1/132X_mcRun3_2022cosmics_design_deco_v1

• Phase1 2022 realistic hi : Includes Ecal Timing CC labelled tags
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/133X_mcRun3_2022_realistic_HI_v1/132X_mcRun3_2022_realistic_HI_v1

• Phase1 2023 design : Includes Ecal Timing CC labelled tags
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/133X_mcRun3_2023_design_v1/132X_mcRun3_2023_design_v1

• Phase1 2023 realistic : Includes Ecal Timing CC labelled tags
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/133X_mcRun3_2023_realistic_v1/132X_mcRun3_2023_realistic_v4

• Phase1 2023 realistic postBPix : Includes Ecal Timing CC labelled tags
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/133X_mcRun3_2023_realistic_postBPix_v1/132X_mcRun3_2023_realistic_postBPix_v3

• Phase1 2023 cosmics reaslistic : Includes Ecal Timing CC labelled tags
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/133X_mcRun3_2023cosmics_realistic_deco_v1/132X_mcRun3_2023cosmics_realistic_deco_v3

• Phase1 2023 cosmics design : Includes Ecal Timing CC labelled tags
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/133X_mcRun3_2023cosmics_design_deco_v1/132X_mcRun3_2023cosmics_design_deco_v1

• Phase1 2023 realistic hi : Includes Ecal Timing CC labelled tags
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/133X_mcRun3_2023_realistic_HI_v1/132X_mcRun3_2023_realistic_HI_v2

• Phase1 2024 realistic : Includes Ecal Timing CC labelled tags
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/133X_mcRun3_2024_realistic_v1/132X_mcRun3_2024_realistic_v2

• Phase2 : Includes Ecal Timing CC labelled tags
  https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/133X_mcRun4_realistic_v1/132X_mcRun4_realistic_v2

PR validation:

Tested successfully with the PR #42928 using

• runTheMatrix.py -l 138.2,138.4,138.5,139.001,141.002,141.003,159.1,160.1,312.0,12034.0,12434.0,12834.0,11601.0,23234.0 -j10 --ibeos
• runTheMatrix.py -l 12430.0,12440.0 --what upgrade -j 8 --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport. Backport will be followed up for 132X and 131X to go with:

• Use ECAL ratio timing algorithm for Run 1 and Run 2, and CC timing algorithm for Run 3 and beyond - 132X #42946
• Use ECAL ratio timing algorithm for Run 1 and Run 2, and CC timing algorithm for Run 3 and beyond - 131X #42947

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42958/37109

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @saumyaphor4252 (Saumya Phor) for master.

It involves the following packages:

• Configuration/AlCa (alca)

@consuegs, @cmsbuild, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@fabiocos, @missirol, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[saumyaphor4252]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce8476/35066/summary.html
COMMIT: 15b81fe
CMSSW: CMSSW_13_3_X_2023-10-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42958/35066/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 4 lines to the logs
• Reco comparison results: 11315 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3356920
• DQMHistoTests: Total failures: 5748
• DQMHistoTests: Total nulls: 74
• DQMHistoTests: Total successes: 3351076
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.016 KiB( 49 files compared)
• DQMHistoSizes: changed ( 141.044 ): 0.016 KiB JetMET/SUSYDQM
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: found differences in 4 / 48 workflows

[mmusich]

Run3 data Offline : Updates the ES Channel status tag to fix the wrong IOV upload 375472 instead of 374572
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/133X_dataRun3_v1/132X_dataRun3_v1

based on these test results looks like this GT has to be updated to add the CC-labeled ecal tags as well.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42958/37120

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #42958 was updated. @saumyaphor4252, @cmsbuild, @consuegs, @perrotta can you please check and sign again.

[saumyaphor4252]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce8476/35081/summary.html
COMMIT: 6482871
CMSSW: CMSSW_13_3_X_2023-10-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42958/35081/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 7577 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3356920
• DQMHistoTests: Total failures: 786
• DQMHistoTests: Total nulls: 6
• DQMHistoTests: Total successes: 3356106
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.016 KiB( 49 files compared)
• DQMHistoSizes: changed ( 141.044 ): 0.016 KiB JetMET/SUSYDQM
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: found differences in 3 / 48 workflows

[saumyaphor4252]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce8476/35088/summary.html
COMMIT: 6482871
CMSSW: CMSSW_13_3_X_2023-10-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42958/35088/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7577 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3356920
• DQMHistoTests: Total failures: 786
• DQMHistoTests: Total nulls: 6
• DQMHistoTests: Total successes: 3356106
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.016 KiB( 49 files compared)
• DQMHistoSizes: changed ( 141.044 ): 0.016 KiB JetMET/SUSYDQM
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: found differences in 3 / 48 workflows

[mmusich]

type bug-fix

• I think with this PR (alone) we expect to fix the ECAL @ HLT reconstruction in Run3 MC, as - before this PR - these workflows were using the CC timing calibration while using the ratio method in reconstruction. This PR restores the status quo ante.

Cc: @cms-sw/egamma-pog-l2

[saumyaphor4252]

+alca

• Differences in Ecal (plus related objects) expected from the change in the Ecal Timing calibrations
• Differences in HLT trigger rates clarified by the above comment
• Bug fix for the following:
  • Update 2022 MC GTs for new ecal timing calibrations #42761
  • Update 2023 MC GTs - 13_3_X #42701 (See Update 2023 MC GTs - 13_3_X #42701 (comment))

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1