Fix approximated SiStrip clusters workflow by saving SiStrip FED error information

[mmusich]

PR description:

It has been shown (see talk) that events repacked in the RAW' data format and then reconstructed with the dedicated process modifier approxSiStripClusters have a different content in terms of tracks w.r.t. the standard reconstruction starting from RAW data (with full SiStrip ADC information). Part of that is expected from information loss intrinsic to the procedure, but dedicated checks showed that in some events few perfectly valid seeds lead to no track reconstructed when data is repacked with the RAW' data format.
This has been shown to depend on the fact the currently the RAW' data format is not saving the list of SiStrip FED errors (collection DetIdedmEDCollection_siStripDigisHLT_*_*) which is used in the tracking setup to construct the list of inactive componets:

cmssw/RecoTracker/MeasurementDet/plugins/MeasurementTrackerEventProducer.cc

Lines 405 to 417 in a5b91a1

	void MeasurementTrackerEventProducer::getInactiveStrips(const edm::Event& event,
	std::vector<uint32_t>& rawInactiveDetIds) const {
	if (!theInactiveStripDetectorLabels.empty()) {
	edm::Handle<DetIdCollection> detIds;
	for (const edm::EDGetTokenT<DetIdCollection>& tk : theInactiveStripDetectorLabels) {
	if (event.getByToken(tk, detIds)) {
	rawInactiveDetIds.insert(rawInactiveDetIds.end(), detIds->begin(), detIds->end());
	}
	}
	if (!rawInactiveDetIds.empty())
	std::sort(rawInactiveDetIds.begin(), rawInactiveDetIds.end());
	}
	}

which is then used in trajectory building.
This PR proposed to fix this issue by keeping the missing collection (2bb7f37, supposed eventually to come from the HLT) in the repack procedure and then to use it in the MeasurementTrackerEventProducer (1f49f6e).
After that is no longer necessary to run the SiStrip unpacker siStripDigis in the RAW2DIGI step, therefore that's excluded from execution profiting of the process modifier (6cc72b5).

PR validation:

Run successfully runTheMatrix.py -l 140.58 -t 4 -j 8 --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, to be backported to at least CMSSW_13_2_X

[mmusich]

test parameters:

• workflows=159,159.02,159.03,140.56,140.58,140.6

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42475/36483

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• Configuration/EventContent (operations)
• Configuration/StandardSequences (operations)
• RecoTracker/MeasurementDet (reconstruction)

@perrotta, @rappoccio, @clacaputo, @cmsbuild, @mandrenguyen, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@mtosi, @fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @gpetruc, @ebrondol, @sameasy, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-971b83/34093/summary.html
COMMIT: 1f49f6e
CMSSW: CMSSW_13_3_X_2023-08-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42475/34093/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 17 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 840 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 3456607
• DQMHistoTests: Total failures: 923
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3455662
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
• Checked 230 log files, 176 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[mmusich]

type bug-fix

[mandrenguyen]

+reconstruction
An increase in tracks in observed, consistent with expectations
c_recoTracks_generalTracks__reRECO_obj_phi.png
Recovered tracks are mostly from pixel pair iteration, consistent with studies that showed that rawprime was mostly losing tracks from that step.
c_recoTracks_generalTracks__reRECO_obj_originalAlgo.png

No change is to observed to MC workflows, also consistent with previous studies.

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.