[13.2.X] Fix approximated SiStrip clusters workflow by saving SiStrip FED error information

[mmusich]

backport of #42475
backport of #42480

PR description:

It has been shown (see talk) that events repacked in the RAW' data format and then reconstructed with the dedicated process modifier approxSiStripClusters have a different content in terms of tracks w.r.t. the standard reconstruction starting from RAW data (with full SiStrip ADC information). Part of that is expected from information loss intrinsic to the procedure, but dedicated checks showed that in some events few perfectly valid seeds lead to no track reconstructed when data is repacked with the RAW' data format.
This has been shown to depend on the fact the currently the RAW' data format is not saving the list of SiStrip FED errors (collection DetIdedmEDCollection_siStripDigisHLT_*_*) which is used in the tracking setup to construct the list of inactive componets:

cmssw/RecoTracker/MeasurementDet/plugins/MeasurementTrackerEventProducer.cc

Lines 405 to 417 in a5b91a1

	void MeasurementTrackerEventProducer::getInactiveStrips(const edm::Event& event,
	std::vector<uint32_t>& rawInactiveDetIds) const {
	if (!theInactiveStripDetectorLabels.empty()) {
	edm::Handle<DetIdCollection> detIds;
	for (const edm::EDGetTokenT<DetIdCollection>& tk : theInactiveStripDetectorLabels) {
	if (event.getByToken(tk, detIds)) {
	rawInactiveDetIds.insert(rawInactiveDetIds.end(), detIds->begin(), detIds->end());
	}
	}
	if (!rawInactiveDetIds.empty())
	std::sort(rawInactiveDetIds.begin(), rawInactiveDetIds.end());
	}
	}

which is then used in trajectory building.
This PR proposed to fix this issue by keeping the missing collection (32b79ff, supposed eventually to come from the HLT) in the repack procedure and then to use it in the MeasurementTrackerEventProducer (4e3c70e).
After that is no longer necessary to run the SiStrip unpacker siStripDigis in the RAW2DIGI step, therefore that's excluded from execution profiting of the process modifier (e6f3888).
In addition since the DetIdedmEDCollection with the list of Strip FED errors is supposed to come from the HLT in production, the name of the collection should match the one in the Online HLT Heavy Ion menu in order to consume the right collection (as it was done before for SiStripClusters2ApproxClustersHLT -> hltSiStripClusters2ApproxClusters in #39863).
This is done in commit 6e38bd9.
This final change is purely technical and it's not expected to generate further regressions.

PR validation:

Run successfully runTheMatrix.py -l 140.58 -t 4 -j 8 --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #42475 and #42480 to CMSSW_13_2_X for the 2023 HI data-taking.

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_2_X.

It involves the following packages:

• Configuration/EventContent (operations)
• Configuration/PyReleaseValidation (pdmv, upgrade)
• Configuration/StandardSequences (operations)
• RecoLocalTracker/SiStripZeroSuppression (reconstruction)
• RecoTracker/MeasurementDet (reconstruction)

@perrotta, @rappoccio, @bbilin, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @sunilUIET, @mandrenguyen, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@echabert, @VourMa, @felicepantaleo, @yduhm, @robervalwalsh, @Martin-Grunewald, @threus, @mmusich, @slomeo, @makortel, @JanFSchulte, @dgulhan, @missirol, @jlidrych, @GiacomoSguazzoni, @rovere, @VinInn, @alesaggio, @ebrondol, @mtosi, @fabiocos, @gbenelli, @gpetruc, @sameasy this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix approximated SiStrip clusters workflow by saving SiStrip FED error information  #42475

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99ed79/34159/summary.html
COMMIT: 6e38bd9
CMSSW: CMSSW_13_2_X_2023-08-08-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42507/34159/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially removed 10 lines from the logs
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3196338
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3196304
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99ed79/34178/summary.html
COMMIT: 6e38bd9
CMSSW: CMSSW_13_2_X_2023-08-08-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42507/34178/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 11 lines to the logs
• Reco comparison results: 50 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3196338
• DQMHistoTests: Total failures: 223
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3196093
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1
Differences in comparisons are unrelated to this PR

[makortel]

+1 Differences in comparisons are unrelated to this PR

Could I ask the occurrence of "random comparison differences" to be documented in some way? On a cursory look these look like #39754

[mmusich]

urgent

• to be included in the next 13_2_X release

[srimanob]

+Upgrade

[mmusich]

kindly pinging @cms-sw/pdmv-l2

[sunilUIET]

+pdmv

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will be automatically merged.