Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAW' workflow: rename siStripDigisHLT to hltSiStripRawToDigi #42480

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 6, 2023

PR description:

This is a quick follow-up to #42475.
Since the DetIdedmEDCollection with the list of Strip FED errors is supposed to come from the HLT in production, the name of the collection should match the one in the Online HLT Heavy Ion menu:

https://github.com/cms-sw/cmssw/blob/f04980c79911900153373b23c402f042276160ee/HLTrigger/Configuration/test/OnLine_HLT_HIon.py#L6129

in order to consume the right collection (as it was done before for SiStripClusters2ApproxClustersHLT -> hltSiStripClusters2ApproxClusters in #39863).
The change is purely technical and it's not expected to generate regressions.

PR validation:

Run successfully runTheMatrix.py -l 140.58 -t 4 -j 8 --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but needs to be backported (along side #42475) to CMSSW_13_2_X in order to be used in the 2023 HI data-taking

@@ -84,5 +84,5 @@
scalersInputTag = cms.InputTag( "rawDataRepacker" )
)

DigiToApproxClusterRawTask = cms.Task(siStripDigisHLT,siStripZeroSuppressionHLT,hltScalersRawToDigi,hltBeamSpotProducer,siStripClustersHLT,hltSiStripClusters2ApproxClusters,rawPrimeDataRepacker)
DigiToApproxClusterRawTask = cms.Task(hltSiStripRawToDigi,siStripZeroSuppressionHLT,hltScalersRawToDigi,hltBeamSpotProducer,siStripClustersHLT,hltSiStripClusters2ApproxClusters,rawPrimeDataRepacker)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a side note, we could actually rename all the HLT mock-up collections:

  • siStripZeroSuppressionHLT -> hltSiStripZeroSuppression
  • siStripClustersHLT -> hltSiStripClusterizerForRawPrime

even though since the event products are not persisted, it's not strictly mandatory to be in synch with the content of the HLT menu. I let the reviewers decide.

@mmusich
Copy link
Contributor Author

mmusich commented Aug 6, 2023

test parameters:

  • workflows=159,159.02,159.03,140.56,140.58,140.6

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42480/36488

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2023

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Configuration/EventContent (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)
  • RecoLocalTracker/SiStripZeroSuppression (reconstruction)
  • RecoTracker/MeasurementDet (reconstruction)

@perrotta, @rappoccio, @bbilin, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @sunilUIET, @mandrenguyen, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@echabert, @VourMa, @felicepantaleo, @yduhm, @robervalwalsh, @Martin-Grunewald, @threus, @mmusich, @slomeo, @makortel, @JanFSchulte, @dgulhan, @missirol, @jlidrych, @GiacomoSguazzoni, @rovere, @VinInn, @alesaggio, @ebrondol, @mtosi, @fabiocos, @gbenelli, @gpetruc, @sameasy this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor

I vaguely recall there was a discussion about the names of the collections at HLT, but I don't immediately recall why we settled on the current set.
FYI @cms-sw/hlt-l2 @denerslemos @vince502
These products will be produced at HLT, they offline workflow is only for testing.
Obviously, once we update the collection names, let's not change them again.

@mmusich
Copy link
Contributor Author

mmusich commented Aug 6, 2023

please test

@mmusich
Copy link
Contributor Author

mmusich commented Aug 6, 2023

but I don't immediately recall why we settled on the current set.

As long as they are not supposed to be consumed downstream, I guess it does not matter other than "aesthetically", as for the one that I actually changed names, it's necessary to stay in synch with the menu. I have chosen the current name, hopefully indeed it won't be further changed later on.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a24758/34110/summary.html
COMMIT: a74d893
CMSSW: CMSSW_13_3_X_2023-08-06-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42480/34110/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 3456607
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3456582
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
  • Checked 230 log files, 176 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@mmusich
Copy link
Contributor Author

mmusich commented Aug 8, 2023

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 can you please have a look and sign?
A backport (#42507) of this will be needed to 13.2.X, thank you.

@sunilUIET
Copy link
Contributor

+pdmv

@mmusich
Copy link
Contributor Author

mmusich commented Aug 10, 2023

@cms-sw/upgrade-l2 kind ping.

@srimanob
Copy link
Contributor

+Upgrade

Technical PR for renaming.

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 842379d into cms-sw:master Aug 10, 2023
@mmusich mmusich deleted the rawprime_hlt_collection_renaming branch August 10, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants