-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAW' workflow: rename siStripDigisHLT
to hltSiStripRawToDigi
#42480
RAW' workflow: rename siStripDigisHLT
to hltSiStripRawToDigi
#42480
Conversation
@@ -84,5 +84,5 @@ | |||
scalersInputTag = cms.InputTag( "rawDataRepacker" ) | |||
) | |||
|
|||
DigiToApproxClusterRawTask = cms.Task(siStripDigisHLT,siStripZeroSuppressionHLT,hltScalersRawToDigi,hltBeamSpotProducer,siStripClustersHLT,hltSiStripClusters2ApproxClusters,rawPrimeDataRepacker) | |||
DigiToApproxClusterRawTask = cms.Task(hltSiStripRawToDigi,siStripZeroSuppressionHLT,hltScalersRawToDigi,hltBeamSpotProducer,siStripClustersHLT,hltSiStripClusters2ApproxClusters,rawPrimeDataRepacker) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a side note, we could actually rename all the HLT mock-up collections:
siStripZeroSuppressionHLT
->hltSiStripZeroSuppression
siStripClustersHLT
->hltSiStripClusterizerForRawPrime
even though since the event products are not persisted, it's not strictly mandatory to be in synch with the content of the HLT menu. I let the reviewers decide.
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42480/36488
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@perrotta, @rappoccio, @bbilin, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @sunilUIET, @mandrenguyen, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
I vaguely recall there was a discussion about the names of the collections at HLT, but I don't immediately recall why we settled on the current set. |
please test |
As long as they are not supposed to be consumed downstream, I guess it does not matter other than "aesthetically", as for the one that I actually changed names, it's necessary to stay in synch with the menu. I have chosen the current name, hopefully indeed it won't be further changed later on. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a24758/34110/summary.html Comparison SummarySummary:
|
+1 |
@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 can you please have a look and sign? |
+pdmv |
@cms-sw/upgrade-l2 kind ping. |
+Upgrade Technical PR for renaming. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This is a quick follow-up to #42475.
Since the
DetIdedmEDCollection
with the list of Strip FED errors is supposed to come from the HLT in production, the name of the collection should match the one in the Online HLT Heavy Ion menu:https://github.com/cms-sw/cmssw/blob/f04980c79911900153373b23c402f042276160ee/HLTrigger/Configuration/test/OnLine_HLT_HIon.py#L6129
in order to consume the right collection (as it was done before for
SiStripClusters2ApproxClustersHLT
->hltSiStripClusters2ApproxClusters
in #39863).The change is purely technical and it's not expected to generate regressions.
PR validation:
Run successfully
runTheMatrix.py -l 140.58 -t 4 -j 8 --ibeos
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but needs to be backported (along side #42475) to CMSSW_13_2_X in order to be used in the 2023 HI data-taking