Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use std::vector<DetId> as data format of SiStrip DetIds with FED errors [13_2_X] #42666

Merged

Conversation

missirol
Copy link
Contributor

backport of #42662

PR description:

From the description of #42662:

This PR changes the data format of the collection used for the DetIds of SiStrip modules with FED errors (this collection is used to mask said modules during the event reconstruction).

#42475 showed that this information needs to be added to the RawPrime event content (see that PR for details).

The current data format for this is DetIdCollection, and concerns were raised (see #42495 (comment) and replies) on the forward-compatibility of this data format in view of possibly adding it to the RAW data tier (which is expected to be backward- and forward-compatible across release cycles).

Following the discussion in #42495 (comment), this PR tries to implement a solution replacing DetIdCollection (== edm::EDCollection<DetId>) with DetIdVector (== std::vector<DetId>) in the SiStrip unpacker and related clients/utilities, such that the data format added to RAW(Prime) would be a std::vector<DetId> rather than a edm::EDCollection<DetId>.

Merely technical. No changes expected.

Thanks to @mmusich for help with preparing this PR.

PR validation:

None.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#42662

Data-format change suggested in view of 2023 HIon data-taking.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 25, 2023

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_2_X.

It involves the following packages:

  • CalibTracker/SiStripHitEfficiency (alca)
  • Calibration/TkAlCaRecoProducers (alca)
  • Configuration/EventContent (operations)
  • Configuration/Skimming (pdmv)
  • DPGAnalysis/SiStripTools (analysis)
  • DPGAnalysis/Skims (pdmv)
  • DQM/SiPixelHeterogeneous (dqm)
  • DataFormats/Common (core)
  • DataFormats/DetId (simulation)
  • EventFilter/SiStripRawToDigi (reconstruction)
  • RecoLocalTracker/Configuration (reconstruction)
  • RecoTracker/MeasurementDet (reconstruction)
  • SimG4Core/Configuration (simulation)

@rappoccio, @bbilin, @pmandrik, @tjavaid, @perrotta, @civanch, @makortel, @cmsbuild, @miquork, @antoniovilela, @mandrenguyen, @davidlange6, @smuzaffar, @consuegs, @Dr15Jones, @emanueleusai, @mdhildreth, @AdrianoDee, @syuvivida, @micsucmed, @fabiocos, @francescobrivio, @nothingface0, @clacaputo, @saumyaphor4252, @sunilUIET, @tvami, @rvenditti can you please review it and eventually sign? Thanks.
@echabert, @VourMa, @felicepantaleo, @yduhm, @robervalwalsh, @Martin-Grunewald, @bsunanda, @fioriNTU, @threus, @mmusich, @slomeo, @venturia, @youyingli, @makortel, @JanFSchulte, @dgulhan, @jlidrych, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @jandrea, @alesaggio, @idebruyn, @ebrondol, @mtosi, @fabiocos, @AnnikaStein, @gbenelli, @wddgit, @gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

test parameters:

  • workflows = 1001.2, 1001.3

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-66de99/34494/summary.html
COMMIT: 618a999
CMSSW: CMSSW_13_2_X_2023-08-25-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42666/34494/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3212848
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3212826
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 161 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

urgent

@mandrenguyen
Copy link
Contributor

+reconstruction

@emanueleusai
Copy link
Member

+1

@civanch
Copy link
Contributor

civanch commented Aug 26, 2023

+1

@makortel
Copy link
Contributor

+core

@perrotta
Copy link
Contributor

+alca

@perrotta
Copy link
Contributor

+operations

@sunilUIET
Copy link
Contributor

+pdmv

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 36634cf into cms-sw:CMSSW_13_2_X Aug 27, 2023
@missirol missirol deleted the devel_stdVecForDetIdsOfSiStripDigis_132X branch August 27, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment