Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix approximated SiStrip clusters workflow by saving SiStrip FED error information #42475

Merged
merged 3 commits into from
Aug 5, 2023
Merged

Fix approximated SiStrip clusters workflow by saving SiStrip FED error information #42475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bb7f37
fix event content for RAW': save SiStrip FED errors in the RAW data
mmusich Aug 4, 2023
6cc72b5
don't run the Strip unpacker in the RAW' case
mmusich Aug 4, 2023
1f49f6e
take the list of SiStrip FED errors from RAW' in case of the approxim…
mmusich Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Configuration/EventContent/python/EventContent_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,8 @@ def SwapKeepAndDrop(l):
from Configuration.ProcessModifiers.approxSiStripClusters_cff import approxSiStripClusters
approxSiStripClusters.toModify(RAWEventContent,
outputCommands = RAWEventContent.outputCommands+[
'keep *_hltSiStripClusters2ApproxClusters_*_*'
'keep *_hltSiStripClusters2ApproxClusters_*_*',
'keep DetIdedmEDCollection_siStripDigisHLT_*_*'
])

#
Expand Down Expand Up @@ -622,7 +623,8 @@ def SwapKeepAndDrop(l):
FEVTDEBUGEventContent.outputCommands.extend(SimFastTimingFEVTDEBUG.outputCommands)
approxSiStripClusters.toModify(FEVTDEBUGEventContent,
outputCommands = FEVTDEBUGEventContent.outputCommands+[
'keep *_hltSiStripClusters2ApproxClusters_*_*'
'keep *_hltSiStripClusters2ApproxClusters_*_*',
'keep DetIdedmEDCollection_siStripDigisHLT_*_*'
])
#
#
Expand All @@ -640,7 +642,8 @@ def SwapKeepAndDrop(l):
FEVTDEBUGHLTEventContent.outputCommands.append('keep *_*_PixelDigiSimLink_*')
approxSiStripClusters.toModify(FEVTDEBUGHLTEventContent,
outputCommands = FEVTDEBUGHLTEventContent.outputCommands+[
'keep *_hltSiStripClusters2ApproxClusters_*_*'
'keep *_hltSiStripClusters2ApproxClusters_*_*',
'keep DetIdedmEDCollection_siStripDigisHLT_*_*'
])
phase2_muon.toModify(FEVTDEBUGHLTEventContent,
outputCommands = FEVTDEBUGHLTEventContent.outputCommands + ['keep recoMuons_muons1stStep_*_*'])
Expand Down
4 changes: 4 additions & 0 deletions Configuration/StandardSequences/python/RawToDigi_Repacked_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@
castorDigis,
scalersRawToDigi)

from Configuration.ProcessModifiers.approxSiStripClusters_cff import approxSiStripClusters
approxSiStripClusters.toModify(RawToDigiTask,
RawToDigiTask.copyAndExclude(siStripDigis)) # in case of the approximate cluster wf don't run the

RawToDigi = cms.Sequence(RawToDigiTask)

RawToDigiTask_woGCT = RawToDigiTask.copyAndExclude([gctDigis])
Expand Down
13 changes: 12 additions & 1 deletion RecoTracker/MeasurementDet/python/MeasurementTrackerEventProducer_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@
badPixelFEDChannelCollectionLabels = ['siPixelDigis'],
)

# in case of RAW' (approximated SiStrip clusters)
# take the list of inactive strip labels directly from RAW data
from Configuration.ProcessModifiers.approxSiStripClusters_cff import approxSiStripClusters
approxSiStripClusters.toModify(MeasurementTrackerEvent,
inactiveStripDetectorLabels = ["siStripDigisHLT"])

# This customization will be removed once we have phase2 pixel digis
# Need this line to stop error about missing siPixelDigis
from Configuration.Eras.Modifier_phase2_tracker_cff import phase2_tracker
Expand All @@ -31,4 +37,9 @@

MeasurementTrackerEventPreSplitting = MeasurementTrackerEvent.clone(
pixelClusterProducer = 'siPixelClustersPreSplitting'
)
)

# in case of RAW' (approximated SiStrip clusters)
# take the list of inactive strip labels directly from RAW data
approxSiStripClusters.toModify(MeasurementTrackerEventPreSplitting,
inactiveStripDetectorLabels = ["siStripDigisHLT"])