-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Phase2 HLT DQM #41898
Add Phase2 HLT DQM #41898
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41898/35841
|
A new Pull Request was created by @srimanob (Phat Srimanobhas) for master. It involves the following packages:
@perrotta, @rappoccio, @nothingface0, @emanueleusai, @civanch, @mdhildreth, @rvenditti, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
type -trk
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c68c85/33044/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
@cms-sw/dqm-l2 @cms-sw/simulation-l2 Thx in advance. |
+1 |
HLTriggerOffline/JetMET/python/Validation/SingleJetValidation_cfi.py
Outdated
Show resolved
Hide resolved
phase2_common.toModify(SingleJetMetPaths, | ||
PatternJetTrg = cms.untracked.string("HLT_(AK4)?PF(NoPU|Puppi)?Jet([0-9])+(_v[0-9]+)?$") | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many of the new histograms are empty. I think the reason (or at least, one reason) is that the value of PFJetAlgorithm
should be updated to hltAK4PFPuppiJetsCorrected
in phase-2 wfs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of the empty histogram is GenJet collection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the reason (or at least, one reason) is that the value of
PFJetAlgorithm
should be updated tohltAK4PFPuppiJetsCorrected
in phase-2 wfs.
Scratch that. hltAK4PFPuppiJetsCorrected
is anyway correct in this case, but the reason some histograms are empty is that no event passes the trigger in question (HLT_AK4PFPuppiJet520_v*
).
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c68c85/33054/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
@cms-sw/dqm-l2 Can we quickly converge on this? So after this PR is merged, I can continue working on Phase-2 paths. I would like to split between the skeleton (this PR), and trigger paths monitoring. Thx. |
+1 |
@cms-sw/simulation-l2 |
+1 |
@perrotta @rappoccio Could you please consider? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This PR is the second attempt to include HLT validation for Phase-2. This PR starts with JetMET-only path for now.
The difference than original PR (#39450) is to avoid a lot of empty histograms from HLT validation by enable one-by-one validation, starting from JetMET.
PR validation:
Try to run locally, to see newly produced histogram.
With this PR: we see a new folder of (
HLT_AK4PFPuppiJet520
inHLT/HLTJETMET
fromhltvalidationWithMC
) and (HLT/HCAL
fromhltvalidationCommon
)https://tinyurl.com/2xova9bl
Compare to what we have now:
https://tinyurl.com/29p9jyte
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
No need of backport