Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Phase2 HLT DQM #41898

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Add Phase2 HLT DQM #41898

merged 3 commits into from
Jun 9, 2023

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Jun 7, 2023

PR description:

This PR is the second attempt to include HLT validation for Phase-2. This PR starts with JetMET-only path for now.
The difference than original PR (#39450) is to avoid a lot of empty histograms from HLT validation by enable one-by-one validation, starting from JetMET.

PR validation:

Try to run locally, to see newly produced histogram.

With this PR: we see a new folder of (HLT_AK4PFPuppiJet520 in HLT/HLTJETMET from hltvalidationWithMC) and (HLT/HCAL from hltvalidationCommon)
https://tinyurl.com/2xova9bl

Compare to what we have now:
https://tinyurl.com/29p9jyte

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No need of backport

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41898/35841

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2023

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • HLTriggerOffline/Common (dqm)
  • HLTriggerOffline/JetMET (dqm)
  • Validation/Configuration (dqm, simulation)

@perrotta, @rappoccio, @nothingface0, @emanueleusai, @civanch, @mdhildreth, @rvenditti, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@youyingli, @fabiocos, @VourMa, @missirol, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @apsallid, @mtosi, @ebrondol, @sameasy, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

srimanob commented Jun 7, 2023

@cmsbuild please test

@mmusich
Copy link
Contributor

mmusich commented Jun 8, 2023

type -trk

  • not sure what triggered adding this label, but from the list of packages involved looks spurious

@cmsbuild cmsbuild removed the trk label Jun 8, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c68c85/33044/summary.html
COMMIT: cefd58a
CMSSW: CMSSW_13_2_X_2023-06-07-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41898/33044/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
10804.31 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 13 lines to the logs
  • Reco comparison results: 32 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3219909
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3219881
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 7737.647000000001 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): 1280.052 KiB HLT/HCAL
  • DQMHistoSizes: changed ( 23634.0,... ): 11.467 KiB HLT/HLTJETMET
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 6 / 46 workflows

@srimanob
Copy link
Contributor Author

srimanob commented Jun 8, 2023

@cms-sw/dqm-l2 @cms-sw/simulation-l2
I would like to have this in the next 13_2_0_pre2 (next week) as skeleton for Phase-2 HLT to develop DQM. New histograms are expected as described in PR description.

Thx in advance.

FYI @SohamBhattacharya

@civanch
Copy link
Contributor

civanch commented Jun 8, 2023

+1

phase2_common.toModify(SingleJetMetPaths,
PatternJetTrg = cms.untracked.string("HLT_(AK4)?PF(NoPU|Puppi)?Jet([0-9])+(_v[0-9]+)?$")
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many of the new histograms are empty. I think the reason (or at least, one reason) is that the value of PFJetAlgorithm should be updated to hltAK4PFPuppiJetsCorrected in phase-2 wfs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of the empty histogram is GenJet collection.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reason (or at least, one reason) is that the value of PFJetAlgorithm should be updated to hltAK4PFPuppiJetsCorrected in phase-2 wfs.

Scratch that. hltAK4PFPuppiJetsCorrected is anyway correct in this case, but the reason some histograms are empty is that no event passes the trigger in question (HLT_AK4PFPuppiJet520_v*).

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c68c85/33054/summary.html
COMMIT: bc78dcf
CMSSW: CMSSW_13_2_X_2023-06-07-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41898/33054/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
10804.31 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 21 lines to the logs
  • Reco comparison results: 34 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3219909
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3219881
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 7737.647000000001 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): 1280.052 KiB HLT/HCAL
  • DQMHistoSizes: changed ( 23634.0,... ): 11.467 KiB HLT/HLTJETMET
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 6 / 46 workflows

@srimanob
Copy link
Contributor Author

srimanob commented Jun 9, 2023

@cms-sw/dqm-l2 Can we quickly converge on this? So after this PR is merged, I can continue working on Phase-2 paths. I would like to split between the skeleton (this PR), and trigger paths monitoring. Thx.

@emanueleusai
Copy link
Member

+1

@srimanob
Copy link
Contributor Author

srimanob commented Jun 9, 2023

@cms-sw/simulation-l2
Could you please re-review and re-sign? The last update is on style of configuration. Thanks.

@civanch
Copy link
Contributor

civanch commented Jun 9, 2023

+1

@srimanob
Copy link
Contributor Author

srimanob commented Jun 9, 2023

@perrotta @rappoccio Could you please consider? Thanks.

@perrotta
Copy link
Contributor

perrotta commented Jun 9, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants