Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Phase2 HLT DQM #41898

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Add Phase2 HLT DQM #41898

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cefd58a
first Phase2 HLT DQM
Jun 7, 2023
9491002
update singlejet
Jun 8, 2023
bc78dcf
style update
Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Configuration/StandardSequences/python/Harvesting_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@
validationHarvesting = cms.Path(postValidation*hltpostvalidation*postValidation_gen)
#validationHarvestingNoHLT = cms.Sequence(postValidation*postValidation_gen)
#validationHarvesting = cms.Sequence(postValidation*hltpostvalidation*postValidation_gen)
validationHarvestingPhase2 = cms.Path(hltpostvalidation)

from Configuration.Eras.Modifier_phase2_common_cff import phase2_common
phase2_common.toReplaceWith(validationHarvesting,validationHarvestingPhase2)

_validationHarvesting_fastsim = validationHarvesting.copy()
for _entry in [hltpostvalidation]:
Expand Down
6 changes: 6 additions & 0 deletions Configuration/StandardSequences/python/Validation_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@
from Configuration.Eras.Modifier_fastSim_cff import fastSim
fastSim.toReplaceWith(prevalidation,_prevalidation_fastsim)

from Configuration.Eras.Modifier_phase2_common_cff import phase2_common
phase2_common.toReplaceWith(prevalidation, prevalidation.copyAndExclude([cms.SequencePlaceholder("mix"),globalPrevalidation,metPreValidSeq,jetPreValidSeq]))

validationNoHLT = cms.Sequence(
genvalid_all
*globaldigisanalyze
Expand All @@ -57,6 +60,9 @@
validation = cms.Sequence(validationNoHLT
*hltvalidation)

from Configuration.Eras.Modifier_phase2_common_cff import phase2_common
phase2_common.toReplaceWith(validation, validation.copyAndExclude([validationNoHLT]))

validationNoHLTHiMix = cms.Sequence(
genvalid_all_hiMix
*globaldigisanalyze
Expand Down
23 changes: 23 additions & 0 deletions HLTriggerOffline/Common/python/HLTValidationHarvest_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,29 @@
)
from Configuration.Eras.Modifier_phase1Pixel_cff import phase1Pixel

# Temporary Phase-2 configuration
# Exclude everything except JetMET for now
from Configuration.Eras.Modifier_phase2_common_cff import phase2_common
phase2_common.toReplaceWith(hltpostvalidation, hltpostvalidation.copyAndExclude([postProcessorHLTtrackingSequence,
postProcessorHLTvertexing,
HLTMuonPostVal,
HLTTauPostVal,
EgammaPostVal,
postProcessorHLTgsfTrackingSequence,
postProcessorHLTmuonTrackingSequence,
heavyFlavorValidationHarvestingSequence,
#JetMETPostVal,
#HLTAlCaPostVal,
SusyExoPostVal,
#ExamplePostVal,
hltvalidationqt,
HLTHiggsPostVal,
hltExoticaPostProcessors,
b2gHLTriggerValidationHarvest,
HLTSMPPostVal,
HltBTagPostVal])
)

# fastsim customs
from Configuration.Eras.Modifier_fastSim_cff import fastSim
fastSim.toReplaceWith(hltpostvalidation, hltpostvalidation.copyAndExclude([
Expand Down
28 changes: 28 additions & 0 deletions HLTriggerOffline/Common/python/HLTValidation_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,16 @@
)
from Configuration.Eras.Modifier_phase1Pixel_cff import phase1Pixel

# Temporary Phase-2 config
from Configuration.Eras.Modifier_phase2_common_cff import phase2_common
phase2_common.toReplaceWith(hltassociation, hltassociation.copyAndExclude([hltMultiTrackValidation,
hltMultiPVValidation,
egammaSelectors,
ExoticaValidationProdSeq,
hltMultiTrackValidationGsfTracks,
hltMultiTrackValidationMuonTracks])
)

# hcal
from DQMOffline.Trigger.HCALMonitoring_cff import *

Expand All @@ -61,6 +71,24 @@
+hltHCALdigisAnalyzer+hltHCALRecoAnalyzer+hltHCALNoiseRates # HCAL
)

# Temporary Phase-2 config
# Exclude everything except JetMET for now
from Configuration.Eras.Modifier_phase2_common_cff import phase2_common
phase2_common.toReplaceWith(hltvalidationWithMC, hltvalidationWithMC.copyAndExclude([HLTMuonVal,
HLTTauVal,
egammaValidationSequence,
heavyFlavorValidationSequence,
#HLTJetMETValSeq,
HLTSusyExoValSeq,
HiggsValidationSequence,
ExoticaValidationSequence,
b2gHLTriggerValidation,
SMPValidationSequence,
hltbtagValidationSequence,
hltHCALdigisAnalyzer,
hltHCALRecoAnalyzer,
hltHCALNoiseRates]))

hltvalidationWithData = cms.Sequence(
)

Expand Down
5 changes: 5 additions & 0 deletions HLTriggerOffline/JetMET/python/Validation/SingleJetValidation_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,9 @@
HLTriggerResults = cms.InputTag("TriggerResults::HLT"),
)

from Configuration.Eras.Modifier_phase2_common_cff import phase2_common
phase2_common.toModify(SingleJetMetPaths,
PatternJetTrg = cms.untracked.string("HLT_(AK4)?PF(NoPU|Puppi)?Jet([0-9])+(_v[0-9]+)?$")
srimanob marked this conversation as resolved.
Show resolved Hide resolved
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many of the new histograms are empty. I think the reason (or at least, one reason) is that the value of PFJetAlgorithm should be updated to hltAK4PFPuppiJetsCorrected in phase-2 wfs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of the empty histogram is GenJet collection.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reason (or at least, one reason) is that the value of PFJetAlgorithm should be updated to hltAK4PFPuppiJetsCorrected in phase-2 wfs.

Scratch that. hltAK4PFPuppiJetsCorrected is anyway correct in this case, but the reason some histograms are empty is that no event passes the trigger in question (HLT_AK4PFPuppiJet520_v*).

SingleJetValidation = cms.Sequence(SingleJetMetPaths)
2 changes: 1 addition & 1 deletion Validation/Configuration/python/autoValidation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
'TrackerPhase2Validation' : ['', 'trackerphase2ValidationSource', 'trackerphase2ValidationHarvesting'],
}

_phase2_allowed = ['baseValidation','trackingValidation','muonOnlyValidation','JetMETOnlyValidation', 'electronOnlyValidation', 'photonOnlyValidation','bTagOnlyValidation', 'tauOnlyValidation', 'hcalValidation', 'HGCalValidation', 'MTDValidation', 'OuterTrackerValidation', 'ecalValidation_phase2', 'TrackerPhase2Validation']
_phase2_allowed = ['baseValidation','trackingValidation','muonOnlyValidation','JetMETOnlyValidation', 'electronOnlyValidation', 'photonOnlyValidation','bTagOnlyValidation', 'tauOnlyValidation', 'hcalValidation', 'HGCalValidation', 'MTDValidation', 'OuterTrackerValidation', 'ecalValidation_phase2', 'TrackerPhase2Validation', 'standardValidation']
autoValidation['phase2Validation'] = ['','','']
for i in range(0,3):
autoValidation['phase2Validation'][i] = '+'.join([_f for _f in [autoValidation[m][i] for m in _phase2_allowed] if _f])