Add Phase-2 MET and Muon trigger paths to DQM

[srimanob]

PR description:

This PR is to add MET and Muon triggers path for Phase-2 DQM. This is a follow up PR of #41898

Example of DQMs: https://tinyurl.com/238eknnf

PR validation:

Running 24850.0_ZMM_14+2026D98 locally, and check DQMs.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41917/35873

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

• HLTriggerOffline/Common (dqm)
• HLTriggerOffline/JetMET (dqm)
• HLTriggerOffline/Muon (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mtosi, @andrea21z, @abbiendi, @Fedespring, @missirol, @HuguesBrun, @jhgoh, @CeliaFernandez, @trocino, @cericeci this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[srimanob]

@cmsbuild please test

[srimanob]

Again that type trk shows up (same as #41898). I don't think we need tracker to monitor here. Something should trigger it. @mmusich @smuzaffar Any idea? Thx.

[mmusich]

type -trk

[mmusich]

@srimanob

Something should trigger it.

I am not sure.
Normally the regexp that should be matched to trigger the label are here:

https://github.com/cms-sw/cms-bot/blob/master/categories_map.py#L1739-L1789

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0482ef/33079/summary.html
COMMIT: 58766f7
CMSSW: CMSSW_13_2_X_2023-06-10-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41917/33079/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 48 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3220833
• DQMHistoTests: Total failures: 2228
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3218583
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 33782.484 KiB( 47 files compared)
• DQMHistoSizes: changed ( 23234.0 ): 5609.634 KiB HLT/Muon
• DQMHistoSizes: changed ( 23634.0,... ): 5630.568 KiB HLT/Muon
• DQMHistoSizes: changed ( 23634.0,... ): 4.002 KiB HLT/HLTJETMET
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[missirol]

I am not sure. Normally the regexp that should be matched to trigger the label are here:

https://github.com/cms-sw/cms-bot/blob/master/categories_map.py#L1739-L1789

I think the following is happening

Non-Blocking label:trk:^.*(Validation/Si).*$:HLTriggerOffline/JetMET/python/Validation/SingleJetValidation_cfi.py

Maybe we need something like

-    CMSSW_LABELS[l] = [re.compile('^.*('+p+').*$') for p in CMSSW_LABELS[l]]
+    CMSSW_LABELS[l] = [re.compile('^('+p+').*$') for p in CMSSW_LABELS[l]]

https://github.com/cms-sw/cms-bot/blob/921489f5eba818a82a067f14d458a0037ccba60f/process_pr.py#L46

[missirol]

Also, maybe one should consider moving the content of HLTriggerOffline/JetMET/python/Validation to HLTriggerOffline/JetMET/python/ (and then remove the "Validation" subdirectory).

[smuzaffar]

https://github.com/cms-sw/cms-bot/blob/master/process_pr.py#L46 is fixed now, thanks @missirol . I think .* was there to allow just providing the file name instead of complete package name. For just match the filename we can use .*/Filename.ext in the https://github.com/cms-sw/cms-bot/blob/master/categories_map.py

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41917/35899

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #41917 was updated. @nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please check and sign again.

[srimanob]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0482ef/33115/summary.html
COMMIT: 980098d
CMSSW: CMSSW_13_2_X_2023-06-12-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41917/33115/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 7 lines to the logs
• Reco comparison results: 51 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3190910
• DQMHistoTests: Total failures: 2228
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3188660
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 33782.484 KiB( 47 files compared)
• DQMHistoSizes: changed ( 23234.0 ): 5609.634 KiB HLT/Muon
• DQMHistoSizes: changed ( 23634.0,... ): 5630.568 KiB HLT/Muon
• DQMHistoSizes: changed ( 23634.0,... ): 4.002 KiB HLT/HLTJETMET
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[srimanob]

@emanueleusai
Could you please re-sign? The last commit is technical and text fixes. Thanks.

[perrotta]

@emanueleusai Could you please re-sign? The last commit is technical and text fixes. Thanks.

Indeed the last commit is quite technical and simple: we can even keep the previous @cms-sw/dqm-l2 signature for good

[perrotta]

+1

[perrotta]

merge

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.