-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce tracking and vertexing HLT validation (w.r.t TPs) for Phase 2 #43094
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43094/37332
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@tjavaid, @antoniovagnerini, @syuvivida, @cmsbuild, @rvenditti, @nothingface0 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
@rovere let me know if there's interest in backporting this to 13.1.X |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b3b77/35371/summary.html Comparison SummarySummary:
|
@mmusich if it is transparent I'd appreciate having this backported. |
@cms-sw/dqm-l2 your signature is required here. Thank you. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
Ciao @srimanob indeed we would like to move to 13_3 asap. Yet there are ongoing developments which are still based on 13_1 and would benefit from the possibility of having a centralized tracking+vertexing validation. I'm mainly thinking of Pixel-(Pata)Tracks to be included in the simplified HLT Menu. |
yes, there it is #43131 |
+1 |
…ting from phase-2 modifier
…e2HLT follow-up to #43094, remove HLT tracking and vertexing validation harvesting from phase-2 modifier
…ting from phase-2 modifier
…ting from phase-2 modifier
PR description:
This PR is a companion of #42783.
Changes needed to the Tracking and Vertexing Validation (w.r.t. Simulation) @ HLT sequence for the Phase-2 setup.
This relies on the current naming of the tracking collections for the phase-2 HLT:
generalTracks::HLT
(somewhat copied from offline)offlinePrimaryVertices::HLT
(as above)hltPhase2PixelTracks
(pixel tracks)hltPhase2PixelVertices
(pixel vertices)PR validation:
Run successfully
runTheMatrix.py -l 24834.0 -t 4 -j 8 --ibeos
and checked that HLT tracking and vertexing validation plots are filled.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but might be backported to 13.1.X if there is interest from the Upgrade community.