Add 2023 data relval workflows

[kskovpen]

PR description:

This PR adds 141.001-141.013 wfs for release validation that use 2023B data.

PR validation:

Tests will be triggered once the transfer is completed.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41629/35515

• This PR adds an extra 60KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/relval_standard.py modified in PR(s): remove 2022 HLT menu from CMSSW_13_X_Y #41471
  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): remove 2022 HLT menu from CMSSW_13_X_Y #41471, Add prototype HcalNanoAOD #41607, Introduce variant of pp_on_PbPb era for 2023 #41571

[cmsbuild]

A new Pull Request was created by @kskovpen for master.

It involves the following packages:

• Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[kskovpen]

please test

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52d066/32599/summary.html
COMMIT: 415a56c
CMSSW: CMSSW_13_2_X_2023-05-12-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41629/32599/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 4.53, 4.22, 5.1, 7.3, 8, 9.0, 136.731, 136.7611, 136.8311, 136.88811, 136.793, 136.874, 138.4, 138.5, 139.001, 140.53, 140.56, 12434.0, 23696.0, 23700.0, 25, 1306.0, 23834.999, 158.01, 135.4, 10024.0, 1330, 13234.0, 312.0, 10042.0, 11834.0, 23234.0, 2500.601, 10824.0, 23634.0, 23634.911, 250202.181, 2018.1, 101.0, 1000, 1001, 10224.0, 25202.0, 11634.911, 11634.914, 11634.0, 11634.7, 13434.0

RelVals-INPUT

[kskovpen]

test parameters:

• workflows = 141.001,141.002,141.003,141.004,141.005,141.006,141.007,141.008,141.009,141.010,141.011,141.012,141.013
• relvals_opt = -w standard

[kskovpen]

please test

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52d066/32601/summary.html
COMMIT: 415a56c
CMSSW: CMSSW_13_2_X_2023-05-12-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41629/32601/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 4.53, 4.22, 5.1, 7.3, 8, 9.0, 136.731, 136.7611, 136.8311, 136.88811, 136.793, 136.874, 138.4, 138.5, 139.001, 140.53, 140.56, 12434.0, 23696.0, 23700.0, 25, 1306.0, 23834.999, 158.01, 135.4, 10024.0, 1330, 13234.0, 312.0, 10042.0, 11834.0, 23234.0, 2500.601, 10824.0, 23634.0, 23634.911, 250202.181, 2018.1, 101.0, 1000, 1001, 10224.0, 25202.0, 11634.911, 11634.914, 11634.0, 11634.7, 13434.0
ValueError: Undefined workflows: 141.008, 141.009, 141.01, 141.004, 141.005, 141.011, 141.012, 141.013, 141.001, 141.002, 141.003, 141.006, 141.007

RelVals-INPUT

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

@aloeliger the noisy L1MuonEndcap messages that were mentioned in #41629 (comment) are still there, even though one month ago they were said "there is or will be an unpacker level fix for these warnings in the works (hopefully by the end of the week)".

Do you have any update about that expected fix to the unpacker?

[perrotta]

Moreover (also for @aloeliger ) in the log of, e.g., wf 141.008 there is the following warning:

%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 09-Jun-2023 16:50:58 CEST  Run: 366727 Stream: 0
Algo "L1_SingleJet60er2p5" not found in the trigger menu L1Menu_Collisions2023_v1_1_0. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 09-Jun-2023 16:50:58 CEST  Run: 366727 Stream: 0
Algo "L1_SingleJet60_FWD3p0" not found in the trigger menu L1Menu_Collisions2023_v1_1_0. Could not retrieve algo bit number.
%MSG

Maybe some wrong L1T menu was considered?

Or maybe simpy DQM/L1TMonitor/python/L1TStage2uGTTiming_cfi.py needs to be update and/or customized for the different eras: @emanueleusai ?

[missirol]

This was noticed a while back, #41645 (comment).

Maybe some wrong L1T menu was considered?
Or maybe simpy DQM/L1TMonitor/python/L1TStage2uGTTiming_cfi.py needs to be update and/or customized for the different eras

It's the second one. Those two L1T algos were removed in 2023 L1T menus.

[perrotta]

Maybe some wrong L1T menu was considered?
Or maybe simpy DQM/L1TMonitor/python/L1TStage2uGTTiming_cfi.py needs to be update and/or customized for the different eras

It's the second one. Those two L1T algos were removed in 2023 L1T menus.

Please @emanueleusai take note

[mmusich]

Or maybe simpy DQM/L1TMonitor/python/L1TStage2uGTTiming_cfi.py needs to be update and/or customized for the different eras
...
Those two L1T algos were removed in 2023 L1T menus.

if these two need to be removed only in 2023, I am afraid there is no common 2023 modifier that one can use (at the moment the EraRun3_2023 only has an egamma modifier):

cmssw/Configuration/Eras/python/Era_Run3_2023_cff.py

Line 6 in 609dc7c

Run3_2023 = cms.ModifierChain(Run3, run3_egamma_2023)

while I agree it's annoying to have the printout (also in Tier0 logs), I am wondering if this warrants alone the creation of a new modifier. Are there perhaps other 2023 L1T-specific changes one can foresee to address with an hypothetical new modifier?
That said, it looks to me that DB conditions would be the way to go to store dynamically changing lists of algos.

[aloeliger]

@aloeliger the noisy L1MuonEndcap messages that were mentioned in #41629 (comment) are still there, even though one month ago they were said "there is or will be an unpacker level fix for these warnings in the works (hopefully by the end of the week)".

Do you have any update about that expected fix to the unpacker?

@perrotta The end-cap muon experts have been making promises about a number of pull requests for a while now that have not materialized yet. I'll lean on them this week during work hours when they are likelier to respond. If necessary i can take a look at it myself, but it might take just as long while I familiarize myself with what is going here since they claimed this is an unpacker fix.

[aloeliger]

Moreover (also for @aloeliger ) in the log of, e.g., wf 141.008 there is the following warning:

%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 09-Jun-2023 16:50:58 CEST  Run: 366727 Stream: 0
Algo "L1_SingleJet60er2p5" not found in the trigger menu L1Menu_Collisions2023_v1_1_0. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 09-Jun-2023 16:50:58 CEST  Run: 366727 Stream: 0
Algo "L1_SingleJet60_FWD3p0" not found in the trigger menu L1Menu_Collisions2023_v1_1_0. Could not retrieve algo bit number.
%MSG

Maybe some wrong L1T menu was considered?

Or maybe simpy DQM/L1TMonitor/python/L1TStage2uGTTiming_cfi.py needs to be update and/or customized for the different eras: @emanueleusai ?

@perrotta I had a chat with the menu folks about this a while ago when we saw the same thing:

%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 26-Apr-2023 01:15:56 CEST  Run: 366498 Stream: 0
Algo "L1_SingleJet60er2p5" not found in the trigger menu L1Menu_Collisions2023_v1_0_0. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 26-Apr-2023 01:15:56 CEST  Run: 366498 Stream: 0
Algo "L1_SingleJet60_FWD3p0" not found in the trigger menu L1Menu_Collisions2023_v1_0_0. Could not retrieve algo bit number.
%MSG

According to the menu experts:

these seeds are indeed not present in the menu v1_0_0. There were removed going from 2022 to 2023, as reported in the README of the menu v1_0_0.
This piece of info was algo propagated to HLT, for example in CMSHLT-2691

I don't know where this is reading it's menu from, but it is not getting any proper 2023 menu from what I can tell.

[mmusich]

@aloeliger

I don't know where this is reading it's menu from, but it is not getting any proper 2023 menu from what I can tell.

Algos to be checked by the DQM module are hardcoded here:

cmssw/DQM/L1TMonitor/python/L1TStage2uGTTiming_cfi.py

Lines 25 to 42 in 609dc7c

	prescaledAlgoShortList = cms.untracked.vstring(
	"L1_FirstCollisionInTrain",
	"L1_LastCollisionInTrain",
	"L1_IsolatedBunch",
	"L1_SingleMu0_BMTF",
	"L1_SingleMu0_OMTF",
	"L1_SingleMu0_EMTF",
	"L1_SingleEG10er2p5",
	"L1_SingleEG15er2p5",
	"L1_SingleEG26er2p5",
	"L1_SingleLooseIsoEG28er1p5",
	"L1_SingleJet60",
	"L1_SingleJet60er2p5",
	"L1_SingleJet60_FWD3p0",
	"L1_ETMHF100",
	"L1_HTT120er",
	"L1_ETT1200"
	),

See #41629 (comment) for further discussion.

[aloeliger]

@aloeliger

I don't know where this is reading it's menu from, but it is not getting any proper 2023 menu from what I can tell.

Algos to be checked by the DQM module are hardcoded here:

cmssw/DQM/L1TMonitor/python/L1TStage2uGTTiming_cfi.py

Lines 25 to 42 in 609dc7c

	prescaledAlgoShortList = cms.untracked.vstring(
	"L1_FirstCollisionInTrain",
	"L1_LastCollisionInTrain",
	"L1_IsolatedBunch",
	"L1_SingleMu0_BMTF",
	"L1_SingleMu0_OMTF",
	"L1_SingleMu0_EMTF",
	"L1_SingleEG10er2p5",
	"L1_SingleEG15er2p5",
	"L1_SingleEG26er2p5",
	"L1_SingleLooseIsoEG28er1p5",
	"L1_SingleJet60",
	"L1_SingleJet60er2p5",
	"L1_SingleJet60_FWD3p0",
	"L1_ETMHF100",
	"L1_HTT120er",
	"L1_ETT1200"
	),

See #41629 (comment) for further discussion.

I can reach out to the menu team and see if they think there's a suitable replacement.

[perrotta]

@perrotta The end-cap muon experts have been making promises about a number of pull requests for a while now that have not materialized yet. I'll lean on them this week during work hours when they are likelier to respond. If necessary i can take a look at it myself, but it might take just as long while I familiarize myself with what is going here since they claimed this is an unpacker fix.

Maybe a github issue with the list of those "promises" can help keeping track of them...
There is no reason to delay further the merging of this PR, though

[perrotta]

+1