remove 2022 HLT menu from CMSSW_13_X_Y

[missirol]

PR description:

This PR removes the 2022 HLT menu (frozen pp menu "V1.5" of 2022) from the master branch of CMSSW. This change will be backported down to the 13_0_X release cycle.

The alias HLT:@relval2022 is updated to point to the Fake2 HLT menu, i.e. the "fake" menu used in any wfs for conditions between 2016 and the year prior to current data-taking (in this case, 2022).

This change has knock-on effects which, while not directly under HLT's responsability, are addressed in this PR.

• Just moving to the "fake" HLT menu would break wf 11634.7, because the MkFit customisation for HLT proved to be, once again, too fragile against HLT changes (see HLT menu development for 12_4_X (5/N): HLT V1.3 [12_5_X] #38816 (comment) for context). The customisation is updated to avoid such issues now and in the future, and wf 12434.7 (which uses the 2023 HLT menu) is added to the RelVals tested in PRs and IBs. 12434.7 replaces 11634.7 in PR tests, and 11634.7 continues to run in IBs.

• The DQM and Validation sequences of 2022 MC wfs are changed to cope with the "fake" HLT menu introduced in those wfs ("FakeHLT" DQM/Validation sequences). While implementing these changes, I think I accidentally fixed several wfs that were missing some of their intended customisations, e.g. wfs 10824.8, 10024.24, 10034.19 and 10080.81. This can be checked looking at the output of [1] and [2] with and without this PR.

This PR is a prerequisite for #41351.

[1] runTheMatrix.py -nel all -w standard,highstats,pileup,generator,extendedgen,production,ged,2017,2016,machine,premix,nano,2026
[2] runTheMatrix.py -nel all -w upgrade

PR validation:

runTheMatrix.py -l 11634.0,11634.7,11634.601,12434.7,10824.6,10824.8,10024.24,10034.19,10080.81 -w upgrade

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_13_0_X
CMSSW_13_1_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41471/35333

• This PR adds an extra 104KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/relval_2017.py modified in PR(s): Guard for No Digis for Phase2 and Patatrack NuGun #41255
  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Adding all geometries and the FullRecoGPU for Patatrack wfs for Phase2  #41011, Guard for No Digis for Phase2 and Patatrack NuGun #41255, Add run3 tracking low pu era #33532, Displaced regional tracking iteration #40643
  • File Configuration/PyReleaseValidation/scripts/runTheMatrix.py modified in PR(s): Guard for No Digis for Phase2 and Patatrack NuGun #41255

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

• Configuration/HLT (hlt)
• Configuration/PyReleaseValidation (pdmv, upgrade)
• HLTrigger/Configuration (hlt)
• RecoTracker/MkFit (reconstruction)

@Martin-Grunewald, @AdrianoDee, @bbilin, @clacaputo, @cmsbuild, @missirol, @srimanob, @kskovpen, @sunilUIET, @mandrenguyen can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @silviodonato, @kpedro88, @gpetruc, @mmusich, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[missirol]

test parameters:

• workflows = 11634.601,10824.6,10824.8,10024.24,10034.19,10080.81
• relvals_opt = -w upgrade

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7713c9/32263/summary.html
COMMIT: c7812aa
CMSSW: CMSSW_13_1_X_2023-04-30-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41471/32263/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially removed 306 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 4249 differences found in the comparisons
• DQMHistoTests: Total files compared: 53
• DQMHistoTests: Total histograms compared: 3671643
• DQMHistoTests: Total failures: 13113
• DQMHistoTests: Total nulls: 2
• DQMHistoTests: Total successes: 3658506
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -840611.894 KiB( 52 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): -40481.807 KiB HLT/JME
• DQMHistoSizes: changed ( 11634.0,... ): -19942.411 KiB HLT/BTV
• DQMHistoSizes: changed ( 11634.0,... ): -15156.684 KiB HLT/Tracking
• DQMHistoSizes: changed ( 11634.0,... ): -12244.889 KiB HLT/EXO
• DQMHistoSizes: changed ( 11634.0,... ): -10388.740 KiB HLT/SiStrip
• DQMHistoSizes: changed ( 11634.0,... ): -10237.354 KiB HLT/HCAL
• DQMHistoSizes: changed ( 11634.0,... ): -9205.523 KiB HLT/Vertexing
• DQMHistoSizes: changed ( 11634.0,... ): -9053.111 KiB HLT/Muon
• DQMHistoSizes: changed ( 11634.0,... ): -8697.605 KiB HLT/Pixel
• DQMHistoSizes: changed ( 11634.0,... ): -5317.474 KiB HLT/SUSYBSM
• DQMHistoSizes: changed ( 11634.0 ): ...
• Checked 238 log files, 185 edm output root files, 53 DQM output files
• TriggerResults: found differences in 5 / 51 workflows

[missirol]

• One clarification regarding the *.7 wfs using the MkFit customisation: this PR adds 12434.7 (2023, ttbar, NoPU) to PR tests and IBs, removes 11634.7 (2022, ttbar, NoPU) from PR tests, and leaves 11634.7 running in IBs. (or at least, that's the intention)

• The DQM differences in 11*.* wfs (2022, ttbar) are in line with the change to the HLT menu (from 2022 pp menu to "fake" menu).

• The many DQM differences in wfs 10024.24, 10034.19 and 10080.81 are likely due to the fact that this PR changes those RelVals configuring them as originally intended (afaiu): 10024.24 [pre-PR] [post-PR], 10034.19 [pre-PR] [post-PR], 10080.81 [pre-PR] [post-PR].

• I'm not sure what the errors reported in "DAS Queries" for wfs 10034.19 and 10080.81 mean. It just looks like the corresponding GEN-SIM samples are not available in the cmsbot cache. This is consistent with the fact those wfs do not run in IBs (afaics), and this PR is not changing that. If so, these errors are not problematic.

[missirol]

+hlt

[missirol]

@cms-sw/dqm-l2 @cms-sw/ctpps-dpg-l2

Just FYI, looking at DQM differences in wf 11834.0, I noticed that the implementation of the CTPPS DQM plots below is very fragile, as it relies on the exact name (incl. version number) of a certain HLT Path, it could be improved.

cmssw/DQM/CTPPS/plugins/CTPPSPixelDQMSource.cc

Line 1237 in 9556ab9

if ((hltResults->accept(i) > 0) && (triggerName == randomHLTPath))

cmssw/DQM/CTPPS/python/ctppsPixelDQMSource_cfi.py

Line 13 in 9556ab9

randomHLTPath = cms.untracked.string("HLT_Random_v3"),

[missirol]

@cms-sw/upgrade-l2 @cms-sw/reconstruction-l2 @cms-sw/pdmv-l2

The latest push was just a rebase. Could you please have a look again, and sign ?

[kskovpen]

+pdmv

[missirol]

@cms-sw/upgrade-l2 @cms-sw/reconstruction-l2

The latest push was just a rebase. Could you please have a look again, and sign ?

[srimanob]

+Upgrade

[clacaputo]

+reconstruction

[missirol]

@cms-sw/orp-l2 , I think the "hold" on this PR can be removed.

[perrotta]

unhold

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1