Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 2022 HLT menu from CMSSW_13_X_Y [13_0_X] #41663

Merged
merged 3 commits into from
May 16, 2023

Conversation

missirol
Copy link
Contributor

backport of #41471

PR description:

From the description of #41471:

This PR removes the 2022 HLT menu (frozen pp menu "V1.5" of 2022) from the master branch of CMSSW. This change will be backported down to the 13_0_X release cycle.

The alias HLT:@relval2022 is updated to point to the Fake2 HLT menu, i.e. the "fake" menu used in any wfs for conditions between 2016 and the year prior to current data-taking (in this case, 2022).

This change has knock-on effects which, while not directly under HLT's responsability, are addressed in this PR.

  • Just moving to the "fake" HLT menu would break wf 11634.7, because the MkFit customisation for HLT proved to be, once again, too fragile against HLT changes (see HLT menu development for 12_4_X (5/N): HLT V1.3 [12_5_X] #38816 (comment) for context). The customisation is updated to avoid such issues now and in the future, and wf 12434.7 (which uses the 2023 HLT menu) is added to the RelVals tested in PRs and IBs. 12434.7 replaces 11634.7 in PR tests, and 11634.7 continues to run in IBs.

  • The DQM and Validation sequences of 2022 MC wfs are changed to cope with the "fake" HLT menu introduced in those wfs ("FakeHLT" DQM/Validation sequences). While implementing these changes, I think I accidentally fixed several wfs that were missing some of their intended customisations, e.g. wfs 10824.8, 10024.24, 10034.19 and 10080.81. This can be checked looking at the output of [1] and [2] with and without this PR.

[1] runTheMatrix.py -nel all -w standard,highstats,pileup,generator,extendedgen,production,ged,2017,2016,machine,premix,nano,2026
[2] runTheMatrix.py -nel all -w upgrade

(modulo the fact that wf 10080.81 does not exist in CMSSW_13_0_X)

This PR is a prerequisite for #41352.

PR validation:

None beyond the tests done for #41471.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#41471

Removal of 2022 HLT menu from release cycles meant for 2023 data-taking, or beyond.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 13, 2023

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/HLT (hlt)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • HLTrigger/Configuration (hlt)
  • RecoTracker/MkFit (reconstruction)

@Martin-Grunewald, @AdrianoDee, @bbilin, @clacaputo, @cmsbuild, @missirol, @srimanob, @kskovpen, @sunilUIET, @mandrenguyen can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @silviodonato, @kpedro88, @gpetruc, @mmusich, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

test parameters:

  • workflows = 11634.7,11634.601,10824.6,10824.8,10024.24,10034.19
  • relvals_opt = -w upgrade

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e469b/32605/summary.html
COMMIT: 69c657f
CMSSW: CMSSW_13_0_X_2023-05-12-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41663/32605/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially removed 380 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 3524 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 3769651
  • DQMHistoTests: Total failures: 16067
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 3753559
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1004287.1710000001 KiB( 53 files compared)
  • DQMHistoSizes: changed ( 11634.601,... ): -40481.807 KiB HLT/JME
  • DQMHistoSizes: changed ( 11634.601,... ): -19107.470 KiB HLT/BTV
  • DQMHistoSizes: changed ( 11634.601,... ): -15156.684 KiB HLT/Tracking
  • DQMHistoSizes: changed ( 11634.601,... ): -12244.889 KiB HLT/EXO
  • DQMHistoSizes: changed ( 11634.601,... ): -10388.740 KiB HLT/SiStrip
  • DQMHistoSizes: changed ( 11634.601,... ): -10237.354 KiB HLT/HCAL
  • DQMHistoSizes: changed ( 11634.601,... ): -9205.523 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 11634.601,... ): -9053.111 KiB HLT/Muon
  • DQMHistoSizes: changed ( 11634.601,... ): -8697.605 KiB HLT/Pixel
  • DQMHistoSizes: changed ( 11634.601,... ): -5317.474 KiB HLT/SUSYBSM
  • DQMHistoSizes: changed ( 11634.601 ): ...
  • Checked 242 log files, 190 edm output root files, 54 DQM output files
  • TriggerResults: found differences in 6 / 52 workflows

@missirol
Copy link
Contributor Author

+hlt

@missirol
Copy link
Contributor Author

missirol commented May 15, 2023

@cms-sw/upgrade-l2 @cms-sw/reconstruction-l2 @cms-sw/pdmv-l2

Could you please review this backport ?

11834.0, #2021 ttbar PU
13234.0, #2021 ttbar fastsim
13434.0, #2021 ttbar PU fastsim
12434.0, #2023 ttbar
12434.7, #2023 ttbar mkFit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I forget to look on #41471. Sorry for the noise.

@srimanob
Copy link
Contributor

+Upgrade

@missirol
Copy link
Contributor Author

@cms-sw/reconstruction-l2 @cms-sw/pdmv-l2

Could you please review this backport ?

@kskovpen
Copy link
Contributor

+pdmv

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 517e24f into cms-sw:CMSSW_13_0_X May 16, 2023
@missirol missirol deleted the remove2022HLTv1p5_130X branch May 21, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants