improve implementation of HLTJetTag<T> plugin template [13_0_X]

[missirol]

backport of #41351

PR description:

From the description of #41351 :

This PR aims to improve the plugin template HLTJetTag<T> as follows.

1. Add option to match jets by delta-R (the plugin uses two jet collections: the first one is a simple jet collection, the second one is the "key" of a JetTagCollection whose values as the jet b-tagging scores).
2. If delta-R matching is not used (not using delta-R matching remains the default behaviour), the (b-)tag value of the jet is accessed via the method edm::AssociationVector::operator[]. This requires that the input jet collection is the same as the "key" collection of the JetTagCollection. If this is not the case, the plugin will throw an exception at runtime.

The limits of the current implementation of HLTJetTag<T> were discussed in #41045.

PR validation:

None beyond the checks done for #41351.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#41351

Backport of an HLT-related update to the release cycle used for 2023 pp data-taking.

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_0_X.

It involves the following packages:

• HLTrigger/btau (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @silviodonato, @AnnikaStein, @Martin-Grunewald, @JyothsnaKomaragiri, @andrzejnovak, @demuller this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from improve implementation of HLTJetTag<T> plugin template #41351

[missirol]

Please do not start the tests yet, unless you want to see them fail.

• The 2023 HLT menu first has to be fixed.
• The frozen 2022 HLT menu has to be removed from CMSSW, otherwise any wf with it would fail at runtime with this PR.

[cmsbuild]

Pull request #41352 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

[missirol]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-706c42/32688/summary.html
COMMIT: c7dfe93
CMSSW: CMSSW_13_0_X_2023-05-17-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41352/32688/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
• 138.4138.4_PromptCollisions2021/step2_PromptCollisions2021.log
• 1002.31002.3_RunZeroBias2022B/step2_RunZeroBias2022B.log

Expand to see more relval errors ...

• 20834.502

Comparison Summary

Summary:

• You potentially removed 12 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3316771
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3316746
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-706c42/32701/summary.html
COMMIT: c7dfe93
CMSSW: CMSSW_13_0_X_2023-05-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41352/32701/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 18 lines to the logs
• Reco comparison results: 15 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3316771
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3316740
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1