-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More Configurable Pixel Tracks and HIon Template #41632
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41632/35517
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
@@ -0,0 +1 @@ | |||
tests passed, failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely not!
048f9f1
to
03a9bdd
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41632/35519
|
A new Pull Request was created by @AdrianoDee (Adriano Di Florio) for master. It involves the following packages:
@civanch, @Dr15Jones, @kskovpen, @pmandrik, @bsunanda, @makortel, @bbilin, @fwyzard, @mdhildreth, @mandrenguyen, @cmsbuild, @AdrianoDee, @srimanob, @clacaputo, @syuvivida, @nothingface0, @sunilUIET, @tjavaid, @micsucmed, @emanueleusai, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
03a9bdd
to
5e079d8
Compare
test parameters:
|
hiPixelTracksCUDA = _pixelTracksCUDA.clone(pixelRecHitSrc="siPixelRecHitsPreSplittingCUDA", idealConditions = False, | ||
ptmin = 0.25, hardCurvCut = 0.0756, doPtCut = False, | ||
onGPU = True, | ||
phiCuts = cms.vint32([900 for i in range(19)]), #19 pairs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
phiCuts = cms.vint32([900 for i in range(19)]), #19 pairs | |
phiCuts = cms.vint32(19*[900]), #19 pairs |
should work as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And looks better: applied.
ptmin = 0.25, hardCurvCut = 0.0756, doPtCut = False, | ||
onGPU = True, | ||
phiCuts = cms.vint32([900 for i in range(19)]), #19 pairs | ||
trackQualityCuts = cms.PSet( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be
trackQualityCuts = cms.PSet( | |
trackQualityCuts = dict( |
and then drop all cms.sometype
specifications
@@ -16,7 +16,7 @@ def _addNoFlow(module): | |||
if not tmp[ind-1] in _noflowSeen: | |||
module.noFlowDists.append(tmp[ind-1]) | |||
|
|||
_defaultSubdirs = ["Tracking/Track/*", "Tracking/TrackTPPtLess09/*", "Tracking/TrackFromPV/*", "Tracking/TrackFromPVAllTP/*", "Tracking/TrackAllTPEffic/*", "Tracking/TrackBuilding/*","Tracking/TrackConversion/*", "Tracking/TrackGsf/*"] | |||
_defaultSubdirs = ["Tracking/Track/*", "Tracking/TrackTPPtLess09/*", "Tracking/HIPixelTrack/*" , "Tracking/TrackFromPV/*", "Tracking/TrackFromPVAllTP/*", "Tracking/TrackAllTPEffic/*", "Tracking/TrackBuilding/*","Tracking/TrackConversion/*", "Tracking/TrackGsf/*"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this addition be era-dependent? 1/8 increment of folders is not that large, but still, seeing HI
it in pp is not that expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, done
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41632/35520
|
+1 |
@cms-sw/pdmv-l2 your signature is the only thing missing before merging this PR and finally build the already two weeks late CMSSW_13_2_0_pre3. Please either sign or state clearly which is the status of your review and when you plan to conclude it. |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
Clean Up for Pixel Tracks - Follow-up to #41632
…1632 fix configuration of GPU Pixel unpacker in Run-3 HLT menus post-#41632
…1632_132X fix configuration of GPU Pixel unpacker in Run-3 HLT menus post-#41632 [`13_2_X`]
This PR proposes some modifications to the GPU (CUDA based) pixel track reconstruction in order, also, to be run smoothly for HIon events. The modifications include:
HIonPhase1
pixel topology;maxNumClustersPerModules
toTrackerTraits
and increasing it to2048
for HIon operations (and exampanding theblockPrefixScan
for theclusterChargeCut
);gpuCalibPixel
(such as the gains and the readout modes) configurable at run-time extendingSiPixelClusterThresholds
struct. This is not strictly needed but I feel would ease the things in future if these constants need to be changed;SiPixelRawToClusterCUDA
in order to include the changes when using an HIon topology (note that the name change is needed since, as far as I have understood, HLT would need to have both module names defined in the same release to do the migration);maxNumberOfDoublets
,z0Cut
,ptCut
andphiCuts
configurable at run time (this will be needed to run offline pixel tracking/seeding on GPU);*.5
) and "Patatrack" (*.501
,*.502
) together withHydjet_Quenched_MinBias_5020GeV_cfi
andHydjet_Quenched_MinBias_5362GeV_cfi
in the matrix;.501
and.502
) for GPU-likehiConformalPixelTracks
for160
workflow;doSplitting
flag), useless for HIon operations, given also that too much shared memory would be needed for the average number of tracks per vertices (MAXTK
) in PbPb conditions;Any comment on this by HIon people is very welcome, especially on the w.f.s introduced.
Solves #40623 #37425.
HI Physics performance plots
HIon pixel tracking performance for:
14950.502_HydjetQMinBias_5362GeV+2023HI_Patatrack_PixelOnlyGPU
here;hiConformalPixelTracks
with w.f.160.502_HydjetQ_MinBias_5362GeV_2023_ppReco
here;Note: these performance may be improved or changed and the sizes of the structures should be better tuned to fit the T4@P5 memory. But I'd leave this to HIon people that know better than me what they need. This PR is here to give the skeleton/template and to may way easier the validation and tuning.
Run2 2018 Data Throughput plots
The pp performance are basically untouched both in physics and throughput.
On
/EphemeralHLTPhysics1/Run2018D-v1/RAW
run=323775
lumi=53
10 July 2023 Update
Addressed comments (from @fwyzard). Mostly:
CUDADataFormats/SiPixelCluster/interface/gpuClusteringConstants.h
;static_cast<T>
where needed;gpuClusterChargeCut
to run for more than2*maxThreads
clusters per module;~phase2_tracker
;List of modules for @Martin-Grunewald .
Under
DQM/SiPixelHeterogeneous/
-
SiPixelHIonPhase1CompareRecHitsSoA
-
SiPixelHIonPhase1CompareTrackSoA
-
SiPixelHIonPhase1MonitorRecHitsSoA
-
SiPixelHIonPhase1MonitorTrackSoA
Under
RecoLocalTracker/SiPixelClusterizer/
-
SiPixelDigisClustersFromSoAHIonPhase1
-
SiPixelRawToClusterCUDAHIonPhase1
Under
RecoLocalTracker/SiPixelRecHits/
-
PixelCPEFastESProducerHIonPhase1
-
SiPixelRecHitCUDAHIonPhase1
-
SiPixelRecHitFromCUDAHIonPhase1
-
SiPixelRecHitSoAFromCUDAHIonPhase1
-
SiPixelRecHitSoAFromLegacyHIonPhase1
Under
RecoTracker/PixelSeeding/
-
CAHitNtupletCUDAHIonPhase1
Under
RecoTracker/PixelTrackFitting/
-
PixelTrackDumpCUDAHIonPhase1
-
PixelTrackProducerFromSoAHIonPhase1
-
PixelTrackSoAFromCUDAHIonPhase1
Under
RecoTracker/PixelVertexFinding/
-
PixelVertexProducerCUDAHIonPhase1
12 July 2023 Update
As sanity check, MTV plots by @CesarBernardes for HIon Conformal Pixel Tracks here before and after the comments.
Updated throughput plots on
/EphemeralHLTPhysics1/Run2018D-v1/RAW
run=323775
lumi=53
:(FYI @denerslemos)