Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we move PixelTracks used for HI reco to patatrack PixelTracks, using GPU? #37425

Closed
clacaputo opened this issue Mar 31, 2022 · 16 comments
Closed

Comments

@clacaputo
Copy link
Contributor

This issue is intended to initiate a discussion about whether the pixeltracks used for HI reco can be moved to patatrack pixel tracks that also run on GPU.

This would be an advantage also for 2022 data taking since the HI reco happens during the Christmas period at CERN also using the HLT farm that has gpus.

@cmsbuild
Copy link
Contributor

A new Issue was created by @clacaputo Claudio Caputo.

@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@clacaputo
Copy link
Contributor Author

clacaputo commented Mar 31, 2022

assign reconstruction

@cmsbuild
Copy link
Contributor

New categories assigned: reconstruction

@jpata,@slava77,@clacaputo you have been requested to review this Pull request/Issue and eventually sign? Thanks

@clacaputo
Copy link
Contributor Author

assign heterogeneous

@cmsbuild
Copy link
Contributor

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

@clacaputo
Copy link
Contributor Author

Tagging HI reco contact: @mandrenguyen

@mandrenguyen
Copy link
Contributor

To give some context, we have been running stand-alone pixel tracking in the offline heavy-ion reconstruction for a while.
We recently moved to the fit model used by patatrack #36558
We are running the patatrack code online, as is done in pp. I understand that this code is visible offline, as well.
I don't know of any good reason not to simply run the patatrack code.
I propose to organize a chat to discuss this.
On the heavy-ion side the tracking is manged by @CesarBernardes and @abaty
I've already been contacted by @AdrianoDee from the patatrack team.
I'll put the reco conveners in the loop, and we can add in any other relevant people from there.

@VinInn
Copy link
Contributor

VinInn commented Apr 1, 2022

I suggest you just try and eventually report issues.

@jpata
Copy link
Contributor

jpata commented May 16, 2022

type trk

@cmsbuild cmsbuild added the trk label May 16, 2022
@jpata
Copy link
Contributor

jpata commented May 16, 2022

@mandrenguyen could you summarize the conclusions of the meeting? Is it planned to be implemented by HI, or should we close this issue?

@mandrenguyen
Copy link
Contributor

At the time of the meeting that you refer to, @CesarBernardes did some comparisons, but it appeared that certain selections would need to be optimized in patatrack to match our offline pixel tracking. I believe there was some follow-up after the meeting by @CesarBernardes and @AdrianoDee Perhaps they can report the latest status here.

@AdrianoDee
Copy link
Contributor

Hi @jpata and @mandrenguyen yes, with Cesar (not being able to tag him) we have been working on that and tackled down why we were loosing efficiency. Now we would need to test the gpu pixel tracking to better asses the performace. My idea is to anyway introduce a wf that runs the HIon pixel tracking on gpu so that the HI people may have a better look at it.

@mmusich
Copy link
Contributor

mmusich commented Aug 8, 2023

type tracking

@mmusich
Copy link
Contributor

mmusich commented Aug 8, 2023

@AdrianoDee @cms-sw/reconstruction-l2 is this issue still active after the merge of #41632 ?

@AdrianoDee
Copy link
Contributor

Could be closed indeed.

@iarspider
Copy link
Contributor

@cmsbuild please close

@cmsbuild cmsbuild closed this as completed Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants