Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12_5_X] Fixed misnamed files in EcalTPG unittest script #39502

Closed
wants to merge 116 commits into from
Closed

[12_5_X] Fixed misnamed files in EcalTPG unittest script #39502

wants to merge 116 commits into from

Conversation

perrotta
Copy link
Contributor

backport of #39235

This PR fixes the issue #38964 created in CondTools/Ecal unittests by the merged PR #38856. The issue was still present in 12_5_X, but the fix was only submitted for the master, 12_6_X (as noticed by @makortel in #39485 (comment))

Two different unit tests were writing on the same local sqlite file, causing troubles. The output files are now unique.

rappoccio and others added 30 commits August 31, 2022 09:23
@rappoccio
Merge pull request cms-sw#39254 from lathomas/UnprefirableEventBit_Ma…
29bfa8a 
…ster

 Compute/store unprefirable event information by default in MINIAOD
@rappoccio
Merge pull request cms-sw#39247 from mmusich/moveDiMuonMassBiasClient…
459c35b 
…ToHarvestingPath

[12.5.X]  Move `DiMuonMassBiasClient` to a regular harvesting path
@fabferro
fix misaligned geometry token
c96e664
Add scripts to test muon tomography for 2026D49 as well as a few othe…
84e6f75 
…rs - backport of cms-sw#39299
@cmsbuild
Merge pull request cms-sw#39276 from swagata87/125X_gsfWarning
e6e3568 
[125X backport] [GSF tracking] Add TSOS only if it is meaningful
@cmsbuild
Merge pull request cms-sw#39291 from fabferro/misGeoFix_125
47fdcb7 
[12_5_X] Fix the mismatch in transition ID for idealGeo backport
@cmsbuild
Merge pull request cms-sw#39257 from thomreis/ecal-reco-gpu-uncalibre…
757a2aa 
…chit-no-externalwork

ECAL - Remove ExternalWork from EcalUncalibRecHitProducerGPU - 12_5_X
@missirol
specify compression settings in offline output modules used by HLT
2fe494c
@missirol
avoid non-reproducible ordering in l1tPhase2MuonEfficiency harvester
08244f4
@cmsbuild
Merge pull request cms-sw#39281 from trtomei/dev_HLTP2_issue39194
a4bf79b 
Simplifying LL1TkMuonFilter, CMSSW_12_5_X
@mandrenguyen
Add production-like Run 3 HI MC workflow to relval
c436566
@mandrenguyen
fix typo
cc41422
@cmsbuild
Merge pull request cms-sw#39269 from sam7k9621/SKIM_PD
2edfc21 
[backport] Update the EXODisappTrk skim source PD
@mtosi @mmusich
add gen fragments for 13.6 TeV
1cfac38 
Pythia8GeneratorFilter --> Pythia8ConcurrentGeneratorFilter

deleted uneeded file

add OmegaMinus w/ TuneCP5 setting

fix CP5 tuning

Pythia8ConcurrentGeneratorFilter

ExternalGeneratorFilter
@mmusich
Adding V0 validation wfs to the matrix
9c58314
@zhangcg123
A possible solution for RPCAMCLikn out-of-range issue
0d26c8c
@zhangcg123
clang-format
28fc34a
@rgerosa
fixing PNET DQM module
32d1757
@cmsbuild
Merge pull request cms-sw#39300 from bsunanda/Phase2-hgx324B
eae34e1 
Phase2-hgx324B Add scripts to test muon tomography for 2026D49 as well as a few others - backport of cms-sw#39299
@cmsbuild
Merge pull request cms-sw#39305 from missirol/devel_hltOutputModuleRe…
bf683dc 
…pl2_125X

specify compression settings in offline output modules used by HLT [`12_5_X`]
@cmsbuild
Merge pull request cms-sw#39303 from missirol/devel_fixOrderL1TPhase2…
ba31558 
…MuonDQM_125X

avoid non-reproducible ordering in `l1tPhase2MuonEfficiency` harvester [`12_5_X`]
@cmsbuild
Merge pull request cms-sw#39320 from zhangcg123/ASolutionforIssue3893…
0ae4b73 
…9_125X

A possible solution for RPCAMCLink out-of-range issue[12_5_X]
@cmsbuild
Merge pull request cms-sw#39324 from kpedro88/FixDeepDoubleX_125X
d08a098 
Fixes for DeepDoubleX [12_5_X]
@cmsbuild
Merge pull request cms-sw#39312 from fwyzard/alpaka_framework
50fe088 
Update alpaka::allocMappedBuf memory functions [12.5.x]
@quark2
Revive the green status on the lumi-based plots
328e6d4
@mmusich
add DiMuon monitioring to other TkAl X->mu mu producers
f2bc95d
@mmusich
add di-muon mass bias harvesting sequences for charmonium and bottomo…
c6bf539 
…nium
@mmusich
improve DiMuonVertexMonitor histogram titles: make them configurable …
0c30936 
…for different resonances
@mmusich
update unit tests for different resonances
f13d38e
@abhih1
Adjusting thresholds for timing, laser and hot cell quality plots
65cde2f
@perrotta perrotta mentioned this pull request Sep 26, 2022
Merged
@perrotta
Copy link
Contributor Author

close

@perrotta perrotta closed this Sep 26, 2022
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39502/32255

  • This PR adds an extra 8KB to repository

  • Found files with invalid states:

    • L1Trigger/VertexFinder/python/VertexProducer_cfi.py:
    • L1Trigger/VertexFinder/python/VertexNTupler_cfi.py:

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 26, 2022 •
edited
Loading

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

  • Alignment/OfflineValidation (alca)
  • CalibPPS/AlignmentGlobal (alca)
  • CalibTracker/SiStripHitEfficiency (alca)
  • Calibration/HcalCalibAlgos (alca)
  • Calibration/IsolatedParticles (alca)
  • CommonTools/TriggerUtils (hlt, l1)
  • CondFormats/Common (db, alca)
  • CondTools/Ecal (db)
  • Configuration/DataProcessing (operations)
  • Configuration/Generator (generators)
  • Configuration/HLT (hlt)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)
  • DPGAnalysis/Skims (pdmv)
  • DQM/BeamMonitor (dqm, db)
  • DQM/EcalMonitorClient (dqm)
  • DQM/EcalMonitorTasks (dqm)
  • DQM/GEM (dqm)
  • DQM/Integration (dqm)
  • DQM/Physics (dqm)
  • DQM/SiOuterTracker (dqm)
  • DQM/TrackingMonitorSource (dqm)
  • DQMOffline/Alignment (dqm)
  • DQMOffline/CalibTracker (dqm)
  • DQMOffline/Configuration (dqm)
  • DQMOffline/L1Trigger (dqm, l1)
  • DQMOffline/RecoB (dqm)
  • DQMOffline/Trigger (dqm)
  • DataFormats/HcalRecHit (reconstruction)
  • DataFormats/L1TMuonPhase2 (l1)
  • DataFormats/PatCandidates (reconstruction)
  • EventFilter/L1TRawToDigi (l1)
  • EventFilter/RPCRawToDigi (reconstruction)
  • Geometry/VeryForwardGeometryBuilder (geometry)
  • HLTrigger/Configuration (hlt)
  • HLTrigger/HLTanalyzers (hlt)
  • HLTrigger/HLTcore (hlt)
  • HLTrigger/HLTfilters (hlt)
  • HeterogeneousCore/AlpakaCore (heterogeneous)
  • IOPool/Input (core)
  • L1Trigger/Configuration (l1)
  • L1Trigger/DemonstratorTools (l1)
  • L1Trigger/L1CaloTrigger (upgrade, l1)
  • L1Trigger/L1THGCal (upgrade, l1)
  • L1Trigger/L1THGCalUtilities (upgrade, l1)
  • L1Trigger/L1TTrackMatch (upgrade, l1)
  • L1Trigger/Phase2L1GMT (l1)
  • L1Trigger/Phase2L1ParticleFlow (upgrade, l1)
  • L1Trigger/Phase2L1Taus (l1)
  • L1Trigger/TrackFindingTracklet (l1)
  • L1Trigger/VertexFinder (l1)
  • PhysicsTools/Heppy (analysis)
  • PhysicsTools/PatAlgos (reconstruction)
  • PhysicsTools/TagAndProbe (analysis)
  • RecoEgamma/EgammaHLTProducers (hlt)
  • RecoLocalCalo/HcalRecAlgos (reconstruction)
  • RecoLocalCalo/HcalRecProducers (reconstruction)
  • RecoLocalTracker/SiPixelClusterizer (reconstruction)
  • RecoTracker/TkSeedGenerator (reconstruction)
  • RecoVertex/BeamSpotProducer (reconstruction, alca)
  • Validation/HGCalValidation (dqm)
  • Validation/RecoVertex (dqm)

@SiewYan, @rappoccio, @kskovpen, @bbilin, @pmandrik, @ianna, @Saptaparna, @Martin-Grunewald, @alberto-sanchez, @bsunanda, @menglu21, @ChrisMisan, @cecilecaillol, @perrotta, @civanch, @yuanchao, @makortel, @ahmad3213, @cmsbuild, @missirol, @fwyzard, @GurpreetSinghChahal, @mandrenguyen, @davidlange6, @smuzaffar, @Dr15Jones, @epalencia, @emanueleusai, @mdhildreth, @AdrianoDee, @jfernan2, @syuvivida, @ggovi, @micsucmed, @fabiocos, @francescobrivio, @malbouis, @mkirsano, @rekovic, @clacaputo, @srimanob, @saumyaphor4252, @sunilUIET, @tvami, @rvenditti can you please review it and eventually sign? Thanks.
@felicepantaleo, @gbenelli, @Martin-Grunewald, @bsunanda, @OzAmram, @watson-ij, @thomreis, @demuller, @varuns23, @slomeo, @sethzenz, @battibass, @ahinzmann, @fabiocos, @jdolen, @azotz, @fwyzard, @ferencek, @skinnari, @rociovilar, @arossi83, @sroychow, @fabferro, @rovere, @eyigitba, @jdamgov, @jandrea, @ebrondol, @abdoulline, @dgulhan, @AlexDeMoor, @valsdav, @apsallid, @afiqaize, @gpetruc, @ram1123, @erikbutz, @emilbols, @kpedro88, @argiro, @mbluj, @fioriNTU, @grzanka, @JanFSchulte, @jhgoh, @lgray, @HuguesBrun, @cericeci, @trocino, @beaucero, @GiacomoSguazzoni, @VinInn, @nhanvtran, @gkasieczka, @schoef, @idebruyn, @francescobrivio, @adewit, @wddgit, @makortel, @mariadalfonso, @amarini, @tvami, @echabert, @rappoccio, @jainshilpi, @trtomei, @threus, @seemasharmafnal, @venturia, @mmarionncern, @simonepigazzini, @vandreev11, @Sam-Harper, @cseez, @hatakeyamak, @mmusich, @mtosi, @batinkov, @AnnikaStein, @Fedespring, @dkotlins, @wrtabb, @andrzejnovak, @pfs, @gouskos, @VourMa, @robervalwalsh, @jbsauvan, @tlampen, @youyingli, @hdelanno, @silviodonato, @missirol, @tocheng, @rchatter, @JyothsnaKomaragiri, @sobhatta, @lecriste, @dinyar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Sep 26, 2022

-1

@perrotta perrotta deleted the backport39235 branch September 27, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-rejected analysis-pending backport-ok code-checks-approved core-pending db-rejected dqm-pending generators-pending geometry-pending heterogeneous-pending hlt-pending l1-pending operations-pending orp-pending pdmv-pending pending-signatures reconstruction-pending tests-pending upgrade-pending
Projects
None yet
Milestone
CMSSW_12_6_X
Development

Successfully merging this pull request may close these issues.