Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx324A Enable the muon tomography code to utilize RecHits in addition to SimHits #39299

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Sep 4, 2022

PR description:

Enable the muon tomography code to utilize RecHits in addition to SimHits

PR validation:

Use the scripts to reach up to RecHit level and use this for muon tomography

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be back ported to 12_5_X to make it available for 2026D49 as well

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39299/31980

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2022

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Validation/HGCalValidation (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@youyingli, @vandreev11, @sethzenz, @rovere, @lgray, @cseez, @apsallid, @pfs, @lecriste, @hatakeyamak, @ebrondol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Sep 4, 2022

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6a706/27310/summary.html
COMMIT: 3c62a53
CMSSW: CMSSW_12_6_X_2022-09-03-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39299/27310/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3618210
  • DQMHistoTests: Total failures: 23
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3618165
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

  • differences in L1T and MTD not related to this PR

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Sep 5, 2022

+1

cmsbuild added a commit that referenced this pull request Sep 6, 2022
Phase2-hgx324B Add scripts to test muon tomography for 2026D49 as well as a few others - backport of #39299
adewit pushed a commit to adewit/cmssw that referenced this pull request Jan 24, 2023
fllor pushed a commit to fllor/cmssw that referenced this pull request Feb 15, 2023
adewit pushed a commit to adewit/cmssw that referenced this pull request Apr 28, 2023
adewit pushed a commit to adewit/cmssw that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants