Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alpaka::allocMappedBuf memory functions #39311

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 5, 2022

PR description:

Update and extend the use of the alpaka::allocMappedBuf functions following the update of the Alpaka external to 2022.09.02 / b518e8c943a8.

Clean up whitespace, comments, and unused dependencies.

PR validation:

Integration tests pass.

If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 12.5.x.

Update and extend the use of alpaka::allocMappedBuf functions following
the update of the Alpaka external to 2022.09.02 / b518e8c943a8.
@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 5, 2022

please test with cms-sw/cmsdist#8068

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39311/32000

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2022

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

  • DataFormats/Portable (heterogeneous)
  • DataFormats/PortableTestObjects (heterogeneous)
  • HeterogeneousCore/AlpakaInterface (heterogeneous)
  • HeterogeneousCore/AlpakaTest (heterogeneous)

@makortel, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9321cf/27348/summary.html
COMMIT: da2b7bc
CMSSW: CMSSW_12_6_X_2022-09-05-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39311/27348/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9321cf/27348/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9321cf/27348/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
136.8561 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3618210
  • DQMHistoTests: Total failures: 82
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3618106
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 6, 2022

+heterogeneous

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Sep 6, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants