Revert the requirement of having an associated L1T muon in L1TPhase2MuonOffline::matchMuonsToGen

[perrotta]

PR description:

The fix I implemented in #39283 was not correct. The (quite convoluted) logic of the L1TPhase2MuonOffline class does require that a (generated muon, l1t muon) pair is created even if there is not a l1t muon. I restore here that feature as it was in origin, still maintaining all the other code improvements implemented in #39283

Also this PR will not fix the non reproducibility issue observed in DQM for the Phase2 L1T muon efficiency plots. Such a fix will require a more detailed check and debug, made this time not by the release manager but by the @cms-sw/dqm-l2 experts.

By the way: who's filling the
L1T__L1TPhase2_Muons_TkMuon_efficiencies_globalEfficiencies
L1T__L1TPhase2_Muons_SAMuon_efficiencies_globalEfficiencies
histos? I supposed it was the L1TPhase2MuonOffline class that I was trying to fix, but I start to doubt it... That class fills the differential efficiencies, instead. Perhaps some harvester called after it?

Could some @cms-sw/dqm-l2 and/or @cms-sw/l1-l2 experts investigate, and at least identify who's filling the non reproducible histo?

PR validation:

It builds

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39297/31977

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

• DQMOffline/L1Trigger (dqm, l1)

@epalencia, @emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @pmandrik, @micsucmed, @cecilecaillol, @rvenditti can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-267829/27307/summary.html
COMMIT: 9f304cf
CMSSW: CMSSW_12_6_X_2022-09-02-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39297/27307/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3618210
• DQMHistoTests: Total failures: 71
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3618117
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[emanueleusai]

@perrotta we will investigate (if #39301 doesn't fix it)

[emanueleusai]

+1

• differences in L1T DQM plots expected

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1