avoid non-reproducible ordering in l1tPhase2MuonEfficiency harvester

[missirol]

PR description:

This PR is a guess to try and solve Item-6 of #39194.

This comment by @perrotta led me to L1TPhase2MuonDQMEfficiency_cfi, where one sees that qualStrings is a set, and not a list. Afaiu, sets are unordered and there is no guarantee on their ordering when iterating on them. This means that the output of generateEfficiencyStrings will always contain the same elements, but with non-reproducible ordering.

Once fed to DQMGenericClient, the latter creates a single histogram with bins containing the global efficiency of each element of efficiencyProfile. I'm guessing that if the ordering of efficiencyProfile is not reproducible, the binning of the "global" histogram in question won't be either.

cmssw/DQMServices/Components/plugins/DQMGenericClient.cc

Line 857 in b2a2b0b

const int iBin = hGlobalEffic->Fill(newEfficMEName.c_str(), 0);

https://root.cern.ch/doc/master/classTH1.html#alpha

PR validation:

None.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_12_5_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39301/31981

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

• DQMOffline/L1Trigger (dqm, l1)

@epalencia, @emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @pmandrik, @micsucmed, @cecilecaillol, @rvenditti can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[missirol]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-441025/27314/summary.html
COMMIT: 957d931
CMSSW: CMSSW_12_6_X_2022-09-04-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39301/27314/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 138.2138.2_ExpressCosmics+RunCosmics2021+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3/step2_ExpressCosmics+RunCosmics2021+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3.log
• 138.1138.1_PromptCosmics+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3/step2_PromptCosmics+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3618210
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3618176
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

• RelVal input file errors are clearly unrelated
• @cms-sw/dqm-l2 @cms-sw/l1-l2 I would like to finally get rid of the non reproducibility issue, and I would like to see the effect of this PR in the next PR, I'm therefore bypassing your signature here: please complain, and feel free to propose either to fix or to revert, if you have anything against it.

[perrotta]

merge

[emanueleusai]

+1

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing).

[perrotta]

And I confirm that after the merging of this PR in master the non reproducibility of the L1T Phase2 Muon efficiency in DQM has disappeared: thank you Marino!