Simplify L1TPhase2MuonOffline and fix the matching with gen muons in it

[perrotta]

PR description:

The last item listed in the github issue #39194 reports about a non reproducibility observed in DQM in the PR tests for the efficiencies for Phase2 muons.

The class that provides those efficiency plots is L1TPhase2MuonOffline, recently introduced in the release with the merging of #38442.

I do not expect that this PR can fix such a non reproducibility issue (say I would be surprised if so). However, cleaning the code a bit could help possible further degugging of the same. This is what this PR is intended to.

@cms-sw/l1-l2 please only consider this PR if it does not interfere with other updates that you are independently implementing in that code to fix the reported issue. Still you can take these simplifications into account for your own code, if so.

Further simplifications and or optimizations are also certainly possible for this code!

PR validation:

It compiles and runs on a few Phase2 workflows

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39283/31942

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

• DQMOffline/L1Trigger (dqm, l1)

@epalencia, @emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @pmandrik, @micsucmed, @cecilecaillol, @rvenditti can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b89c3/27260/summary.html
COMMIT: 9d6791a
CMSSW: CMSSW_12_6_X_2022-08-31-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39283/27260/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3620448
• DQMHistoTests: Total failures: 20
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3620406
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[perrotta]

I've found a bug in the method L1TPhase2MuonOffline::matchMuonsToGen as it was coded in origin: the match was saved even if there was actually no match, with a null pointer for the muon. I don't know if it is the possible culprit for the issue of the non reproducibility reported in the PR description, but it certainly needs to be fixed.

A fix is now coded in the commit 01f6d9f

[perrotta]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39283/31953

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #39283 was updated. @epalencia, @emanueleusai, @ahmad3213, @rekovic, @jfernan2, @pmandrik, @micsucmed, @cecilecaillol, @rvenditti can you please check and sign again.

[perrotta]

please abort

[perrotta]

@cmsbuild please test

[cecilecaillol]

+l1

[perrotta]

type bugfix

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b89c3/27276/summary.html
COMMIT: 01f6d9f
CMSSW: CMSSW_12_6_X_2022-09-01-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39283/27276/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3620448
• DQMHistoTests: Total failures: 73
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3620352
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

• differences in L1T DQM plots noted in Remaining issues after the merging of "L1T Phase-2, remove old simulation and adapt DQM (#38442)" #39194 already (and the reason for this PR)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1