A possible solution for RPCAMCLink out-of-range issue[12_5_X]

[zhangcg123]

backport of #39307

PR description:

After the PR #38564 merged, there is an issue about RPCAMCLink #38939.

The reason for the crash is that during the run 314890 (used by the workflow 136.8561_RunZeroBias) the CPPF data were considered as corrupted. The reason was an firmware update, which led to some problems.. The CPPF good data have been restored after the run 315764.( Copy from #38939 (comment) )

This is fixed by adding a sanity check to RPCCPPFUnpacker.

@mileva @andresib @minerva1993 @jhgoh @ram1123 @vukasinmilosevic

PR validation:

runTheMatrix.py -l limited -i all --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

#39307 for CMSSW_12_5_X

[cmsbuild]

A new Pull Request was created by @zhangcg123 for CMSSW_12_5_X.

It involves the following packages:

• EventFilter/RPCRawToDigi (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from A possible solution for RPCAMCLink out-of-range issue #39307

[mandrenguyen]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32988e/27378/summary.html
COMMIT: 28fc34a
CMSSW: CMSSW_12_5_X_2022-09-06-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39320/27378/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3695708
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3695667
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1