A possible solution for RPCAMCLink out-of-range issue

[zhangcg123]

PR description:

After the PR #38564 merged, there is an issue about RPCAMCLink #38939.

The reason for the crash is that during the run 314890 (used by the workflow 136.8561_RunZeroBias) the CPPF data were considered as corrupted. The reason was an firmware update, which led to some problems.. The CPPF good data have been restored after the run 315764.( Copy from #38939 (comment) )

This is fixed by adding a sanity check to RPCCPPFUnpacker.

PR validation:

runTheMatrix.py -l 136.8561 --job-reports -t 4 --ibeos

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39307/31986

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39307/31986/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39307/31986/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39307/31988

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @zhangcg123 for master.

It involves the following packages:

• EventFilter/RPCRawToDigi (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mandrenguyen]

@cms-sw/muon-dpg-l2 looking at the issue (#38939) you were advocating such a fix.
Does the PR correspond to your expectations?
Is the hard-coded value:
if (record.getLink() > 80)
something that will always be valid?

[zhangcg123]

@mileva @andresib @minerva1993 @jhgoh, Dear RPC experts, please take a look at this.

[mileva]

Hi @mandrenguyen !
Thank you for mentioning @cms-sw/muon-dpg-l2 and also the RPCs!
I am not an firmware expert, but after a short discussion with @zhangcg123 I think the proposed value is correct.
Further to the RPCAMCLink class,
it should be OK.
At least I hope.
As this is quite specific value and we do not expect to change, I agree to remain hardcoded.
Regards!
Roumyana

[perrotta]

please test workflow 136.8561
(Thank you @zhangcg123 )

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2b1f06/27341/summary.html
COMMIT: b7a005f
CMSSW: CMSSW_12_6_X_2022-09-05-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39307/27341/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
136.8561 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 484 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 5 differences found in the comparisons
• Reco comparison had 2 failed jobs
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3618210
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3618180
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 215 log files, 52 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

@zhangcg123 please prepare a backport for CMSSW_12_5_X