Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPPF DQM modules backport to 12_4_X #40258

Closed
wants to merge 3 commits into from

Conversation

zhangcg123
Copy link
Contributor

@zhangcg123 zhangcg123 commented Dec 7, 2022

PR description:

Add CPPF online DQM modules L1TdeStage2CPPF and L1TStage2CPPF.
By comparing the CPPF emulator and unpacker outputs and putting some comparison histograms on the CMS online DQM GUI, shifters can monitor the status of the CPPF hardware.

PR validation:

cmsRun DQM/Integration/python/clients/l1tstage2emulator_dqm_sourceclient-live_cfg.py unitTest=True

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #38564 and #39307. For CPPF online DQM

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
bugfix

bugfix

remove commented lines

add L1TStage2CPPF cfi

clear comments

code-checks and format

LogInfo to Warning

remove couts

src to plugins

clang format
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2022

A new Pull Request was created by @zhangcg123 for CMSSW_12_4_X.

It involves the following packages:

  • DQM/L1TMonitor (dqm)
  • EventFilter/RPCRawToDigi (reconstruction)
  • L1Trigger/Configuration (l1)
  • L1Trigger/L1TMuonCPPF (l1)

@epalencia, @micsucmed, @emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @clacaputo, @syuvivida, @pmandrik, @mandrenguyen, @cecilecaillol, @rvenditti can you please review it and eventually sign? Thanks.
@JanFSchulte, @eyigitba, @Martin-Grunewald, @missirol, @thomreis, @dinyar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@clacaputo
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe6a87/29507/summary.html
COMMIT: 377e2e5
CMSSW: CMSSW_12_4_X_2022-12-06-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40258/29507/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3709306
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3709276
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2094.1640000000007 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 102.075 KiB L1TEMU/L1TdeStage2CPPF
  • DQMHistoSizes: changed ( 10024.0,... ): 2.633 KiB L1T/L1TStage2CPPF
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 161 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@@ -143,6 +143,8 @@ void RPCCPPFUnpacker::processRXRecord(RPCAMCLink link,
LogDebug("RPCCPPFRawToDigi") << "RXRecord " << std::hex << record.getRecord() << std::dec << std::endl;
unsigned int fed(link.getFED());
unsigned int amc_number(link.getAMCNumber());
if (record.getLink() > 80)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure reco needs to have much input here, but would it be useful to add some comments to explain what these kind of numbers correspond to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mandrenguyen

Please take a look at #39307. We have already discussed this https://github.com/cms-sw/cmssw/pull/39307#issuecomment-1237042992
I quoted a wrong issue number in this PR description, fixed it already.

Best,

@mmusich
Copy link
Contributor

mmusich commented Dec 8, 2022

For my own education what use case is this PR actually targeting? As far as I am aware data-taking in 12.4.X is over and the release for 2022 re-reco is already frozen, so there seems to be no practical use case for this backport.

@zhangcg123
Copy link
Contributor Author

Hi @mmusich ,
Thanks for your information.
If the p5 dqm sw will switch to 12.5.X soon, this pr does not make sence.
I don't know about this thing. So, If an expert can confirm this, we can close this PR.
Sorry for that if I introduce some noise.

@perrotta
Copy link
Contributor

As discussed and agreed with DQM and all other groups present at the ORP meeting on Dec 13, we can now close this PR (which will never be merged in the offline release anyhow) and clean up a bit our queues

@perrotta perrotta closed this Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants