Simplifying LL1TkMuonFilter, CMSSW_12_5_X

[trtomei]

PR description:

Addressing items 2 and 3 of #39194

• Simplified the whole applyQualities infrastructure of the module
• Default is now applyQualities = false and qualities = {} (an empty vector). This is fine; if applyQualities is set to true, then some qualities must be furnished!

PR validation:

Test done:

cmsDriver.py Phase2 -s HLT:75e33 --processName=HLTX \
--conditions auto:phase2_realistic_T21 \
--geometry Extended2026D88 \
--era Phase2C17I13M9 \
--eventcontent FEVTDEBUGHLT \
--filein=/store/relval/CMSSW_12_5_0_pre5/RelValTTbar_14TeV/GEN-SIM-RECO/125X_mcRun4_realistic_v2_2026D88noPU-v1/10000/8abbb6aa-60d0-4d16-8a9a-7b9c95e5aee7.root \
-n 100 --nThreads 1 --no_exec

runs fine, and the new module interface is exercised.

This PR is a backport of #39280 . It is needed in CMSSW_12_5_X for the upcoming MC production for L1T.

[cmsbuild]

A new Pull Request was created by @trtomei (Thiago Tomei) for CMSSW_12_5_X.

It involves the following packages:

• HLTrigger/HLTfilters (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Simplifying LL1TkMuonFilter #39280

[cmsbuild]

Pull request #39281 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

[missirol]

backport of #39280

[missirol]

please test

[missirol]

please abort

Tests seem stuck.

[missirol]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-102cd6/27313/summary.html
COMMIT: 1ad2dc0
CMSSW: CMSSW_12_5_X_2022-09-04-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39281/27313/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 138.2138.2_ExpressCosmics+RunCosmics2021+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3/step2_ExpressCosmics+RunCosmics2021+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3.log
• 138.1138.1_PromptCosmics+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3/step2_PromptCosmics+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3695708
• DQMHistoTests: Total failures: 25
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3695660
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Verbatim backport of Simplifying LL1TkMuonFilter #39280
• RelVal Input test errors are unrelated

[perrotta]

merge