Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gen fragments at 13.6 TeV for BPH-TRK #39178

Merged
merged 1 commit into from
Sep 7, 2022
Merged

add gen fragments at 13.6 TeV for BPH-TRK #39178

merged 1 commit into from
Sep 7, 2022

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Aug 24, 2022

PR description:

add new genFragments at 13.6 TeV for BPH and TRK

  • B0ToJpsiK0s w/ Jspi to muons
  • DStarToD0Pi w/ D0 To KsPiPi
  • LbToJpsiLambda w/ Jspi to muons
  • LbToJpsiXiK0sPi w/ Jspi to muons
  • OmegaMinus
  • XiMinus

@cmsbuild cmsbuild added this to the CMSSW_12_5_X milestone Aug 24, 2022
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39178/31772

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for master.

It involves the following packages:

  • Configuration/Generator (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Aug 24, 2022

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Aug 24, 2022 •
edited
Loading

urgent

  • this is needed from TRK POG and BPH PAG in CMSSW_12_5_0 to perform V0 tracking optimization studies

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7911f9/27061/summary.html
COMMIT: e2e7b75
CMSSW: CMSSW_12_5_X_2022-08-24-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39178/27061/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3693084
  • DQMHistoTests: Total failures: 19
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3693042
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Aug 26, 2022

@cms-sw/generators-l2 it would be important that this update enters 12_5_0, because it will allow to ask samples for further tracking development targeting V0 reconstruction. Can you please review it?
Thanks much in advance
Att: @cms-sw/orp-l2

@perrotta
Copy link
Contributor

@cms-sw/generators-l2 it would be important that this update enters 12_5_0, because it will allow to ask samples for further tracking development targeting V0 reconstruction. Can you please review it? Thanks much in advance Att: @cms-sw/orp-l2

@cms-sw/generators-l2 please notice that we did not build pre5 yet only because we have issues with fwlite see #39212
That means that you could still have some time, but not that much: we will not wait for this PR, and as soon as that issue is solved we'll start building pre5

@mtosi
Copy link
Contributor Author

mtosi commented Aug 26, 2022

@cms-sw/generators-l2 are there issues w/ this PR ?
thanks

@AdrianoDee AdrianoDee mentioned this pull request Aug 26, 2022
Merged
@smuzaffar smuzaffar modified the milestones: CMSSW_12_5_X, CMSSW_12_6_X Aug 28, 2022
@perrotta
Copy link
Contributor

@SiewYan, @mkirsano, @Saptaparna, @alberto-sanchez, @menglu21, @GurpreetSinghChahal : is anybody around for @cms-sw/generators-l2 able to review and sign this and the other pending PRs ?

@SiewYan
Copy link
Contributor

SiewYan commented Aug 29, 2022 •
edited
Loading

Hello @perrotta , I am ok with the technical implementation, we need L2 @Saptaparna , @menglu21 , @GurpreetSinghChahal to sign off if the naming of the fragment is coherent with practice.

This was referenced Aug 29, 2022
Closed
Merged
srimanob
srimanob reviewed Aug 29, 2022
View reviewed changes
Configuration/Generator/python/OmegaMinus_13p6TeV_SoftQCDInel_TuneCUEP8M1_cfi.py Outdated
from Configuration.Generator.Pythia8CUEP8M1Settings_cfi import *


generator = cms.EDFilter("Pythia8GeneratorFilter",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the guideline (*), the generator filter does not include ExternalDecay, should Pythia8ConcurrentGeneratorFilter be used instead?

(*) https://twiki.cern.ch/twiki/bin/view/CMSPublic/WorkBookGenMultithread#Pythia8ConcurrentGeneratorFilter

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, why TuneCUEP8M1? Not CP5?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, why TuneCUEP8M1? Not CP5?

was this addressed? @mtosi

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the recommendation to use

from Configuration.Generator.MCTunesRun3ECM13p6TeV.PythiaCP5Settings_cfi import *

as done in #39243 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Please move to Run3 tuning, Thanks.

srimanob
srimanob reviewed Aug 29, 2022
View reviewed changes
Configuration/Generator/python/XiMinus_13p6TeV_SoftQCDInel_TuneCUEP8M1_cfi.py Outdated
from Configuration.Generator.Pythia8CUEP8M1Settings_cfi import *


generator = cms.EDFilter("Pythia8GeneratorFilter",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as OmegaMinus.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please use Pythia8ConcurrentGeneratorFilter to enable multithreading.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, perhaps with EvtGen this is not possible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be used with Pythia8ConcurrentGeneratorFilter

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39178/32003

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2022

Pull request #39178 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Sep 6, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7911f9/27354/summary.html
COMMIT: 4e5bbc1
CMSSW: CMSSW_12_6_X_2022-09-05-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39178/27354/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3618210
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3618186
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@menglu21
Copy link
Contributor

menglu21 commented Sep 6, 2022

look fine to GEN

@mmusich
Copy link
Contributor

mmusich commented Sep 6, 2022

look fine to GEN

could you please +1 it, then?
Thanks!

@Saptaparna
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@rappoccio rappoccio merged commit bb8a147 into cms-sw:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saptaparna Saptaparna Saptaparna left review comments

@mmusich mmusich mmusich left review comments

@mandrenguyen mandrenguyen mandrenguyen left review comments

@srimanob srimanob srimanob left review comments

Assignees
No one assigned
Labels
code-checks-approved fully-signed generators-approved orp-approved tests-approved urgent
Projects
None yet
Milestone
CMSSW_12_6_X
Development

Successfully merging this pull request may close these issues.