Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.5.X] Adding V0 Validation Wfs to the RelVal Matrix #39232

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 29, 2022

backport of #39215 and #39178

PR description:

This PR adds new genFragments at 13.6 TeV for BPH and TRK:

  • B0ToJpsiK0s w/ Jspi to muons
  • DStarToD0Pi w/ D0 To KsPiPi
  • LbToJpsiLambda w/ Jspi to muons
  • LbToJpsiXiK0sPi w/ Jspi to muons
  • OmegaMinus
  • XiMinus

And also the wfs to be used for BPH-TRK V0 reconstruction validation to the RelVal matrix.

PR validation:

Running wfs 11744.0, 11745.0, 11746.0, 11747.0, 11748.0, 11749.0.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #39215 and #39178

@mmusich
Copy link
Contributor Author

mmusich commented Aug 29, 2022

urgent

  • this is needed from TRK POG and BPH PAG in CMSSW_12_5_0 to perform V0 tracking optimization studies

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 29, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_5_X.

It involves the following packages:

  • Configuration/Generator (generators)
  • Configuration/PyReleaseValidation (pdmv, upgrade)

@SiewYan, @mkirsano, @jordan-martins, @bbilin, @alberto-sanchez, @Saptaparna, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 29, 2022

test parameters:

  • workflows = 11744.0,11745.0,11746.0,11747.0,11748.0,11749.0
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix

@mmusich
Copy link
Contributor Author

mmusich commented Aug 29, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-646713/27158/summary.html
COMMIT: 2dbc191
CMSSW: CMSSW_12_5_X_2022-08-29-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39232/27158/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-646713/11744.0_B0ToJpsiK0s_DGamma0_13p6TeV+2021+B0ToJpsiK0s_JMM_Filter_DGamma0_TuneCP5_13p6TeV-pythia8-evtgen_GenSim+Digi+RecoNano+HARVESTNano+ALCA
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-646713/11745.0_DStarToD0Pi_D0ToKsPiPi_13p6TeV+2021+DStarToD0Pi_D0ToKsPiPi_inclusive_SoftQCD_TuneCP5_13p6TeV-pythia8-ev_GenSim+Digi+RecoNano+HARVESTNano+ALCA
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-646713/11746.0_LbToJpsiLambda_DGamma0_13p6TeV+2021+LbToJpsiLambda_JMM_Filter_DGamma0_TuneCP5_13p6TeV-pythia8-evtgen_GenSim+Digi+RecoNano+HARVESTNano+ALCA
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-646713/11747.0_LbToJpsiXiK0sPr_DGamma0_13p6TeV+2021+LbToJpsiXiK0sPi_JMM_Filter_DGamma0_TuneCP5_13p6TeV-pythia8-evtgen_GenSim+Digi+RecoNano+HARVESTNano+ALCA
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-646713/11748.0_OmegaMinus_13p6TeV+2021+OmegaMinus_13p6TeV_SoftQCDInel_TuneCUEP8M1_GenSim+Digi+RecoNano+HARVESTNano+ALCA
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-646713/11749.0_XiMinus_SoftQCDInel_13p6TeV+2021+XiMinus_13p6TeV_SoftQCDInel_TuneCUEP8M1_GenSim+Digi+RecoNano+HARVESTNano+ALCA

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3695708
  • DQMHistoTests: Total failures: 18
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695668
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Sep 1, 2022

last push is to synch with the status of the master PRs.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2022

Pull request #39232 was updated. @SiewYan, @mkirsano, @bbilin, @alberto-sanchez, @Saptaparna, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @menglu21, @sunilUIET, @GurpreetSinghChahal can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 1, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-646713/27268/summary.html
COMMIT: cee274a
CMSSW: CMSSW_12_5_X_2022-08-31-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39232/27268/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3695708
  • DQMHistoTests: Total failures: 24
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695662
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Sep 2, 2022

test parameters:

  • workflows = 11744.0, 11745.0, 11746.0, 11747.0, 11748.0
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-646713/27284/summary.html
COMMIT: eecc2b9
CMSSW: CMSSW_12_5_X_2022-09-01-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39232/27284/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-646713/11744.0_B0ToJpsiK0s_DGamma0_13p6TeV+2021+B0ToJpsiK0s_JMM_Filter_DGamma0_TuneCP5_13p6TeV-pythia8-evtgen_GenSim+Digi+RecoNano+HARVESTNano+ALCA
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-646713/11745.0_DStarToD0Pi_D0ToKsPiPi_13p6TeV+2021+DStarToD0Pi_D0ToKsPiPi_inclusive_SoftQCD_TuneCP5_13p6TeV-pythia8-ev_GenSim+Digi+RecoNano+HARVESTNano+ALCA
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-646713/11746.0_LbToJpsiLambda_DGamma0_13p6TeV+2021+LbToJpsiLambda_JMM_Filter_DGamma0_TuneCP5_13p6TeV-pythia8-evtgen_GenSim+Digi+RecoNano+HARVESTNano+ALCA
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-646713/11747.0_LbToJpsiXiK0sPr_DGamma0_13p6TeV+2021+LbToJpsiXiK0sPi_JMM_Filter_DGamma0_TuneCP5_13p6TeV-pythia8-evtgen_GenSim+Digi+RecoNano+HARVESTNano+ALCA
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-646713/11748.0_OmegaMinus_13p6TeV+2021+OmegaMinus_13p6TeV_SoftQCDInel_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano+ALCA

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3695708
  • DQMHistoTests: Total failures: 17
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695669
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

mtosi and others added 2 commits September 6, 2022 10:16
Pythia8GeneratorFilter --> Pythia8ConcurrentGeneratorFilter

deleted uneeded file

add OmegaMinus w/ TuneCP5 setting

fix CP5 tuning

Pythia8ConcurrentGeneratorFilter

ExternalGeneratorFilter
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2022

Pull request #39232 was updated. @SiewYan, @mkirsano, @bbilin, @alberto-sanchez, @Saptaparna, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @menglu21, @sunilUIET, @GurpreetSinghChahal can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 6, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-646713/27360/summary.html
COMMIT: 9c58314
CMSSW: CMSSW_12_5_X_2022-09-05-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39232/27360/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-646713/11744.0_B0ToJpsiK0s_DGamma0_13p6TeV+2021+B0ToJpsiK0s_JMM_Filter_DGamma0_TuneCP5_13p6TeV-pythia8-evtgen_GenSim+Digi+RecoNano+HARVESTNano+ALCA
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-646713/11745.0_DStarToD0Pi_D0ToKsPiPi_13p6TeV+2021+DStarToD0Pi_D0ToKsPiPi_inclusive_SoftQCD_TuneCP5_13p6TeV-pythia8-ev_GenSim+Digi+RecoNano+HARVESTNano+ALCA
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-646713/11746.0_LbToJpsiLambda_DGamma0_13p6TeV+2021+LbToJpsiLambda_JMM_Filter_DGamma0_TuneCP5_13p6TeV-pythia8-evtgen_GenSim+Digi+RecoNano+HARVESTNano+ALCA
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-646713/11747.0_LbToJpsiXiK0sPr_DGamma0_13p6TeV+2021+LbToJpsiXiK0sPi_JMM_Filter_DGamma0_TuneCP5_13p6TeV-pythia8-evtgen_GenSim+Digi+RecoNano+HARVESTNano+ALCA
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-646713/11748.0_OmegaMinus_13p6TeV+2021+OmegaMinus_13p6TeV_SoftQCDInel_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano+ALCA

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3695708
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695676
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link
Contributor

+Upgrade

@mmusich
Copy link
Contributor Author

mmusich commented Sep 7, 2022

@cms-sw/pdmv-l2 @cms-sw/generators-l2 please kindly sing this, as the master PRs f #39215 and #39178 have converged by now.

@kskovpen
Copy link
Contributor

kskovpen commented Sep 7, 2022

+pdmv

@perrotta
Copy link
Contributor

perrotta commented Sep 7, 2022

backport of #39215
...and #39178

@rappoccio
Copy link
Contributor

+1

@rappoccio rappoccio merged commit e46f26f into cms-sw:CMSSW_12_5_X Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants