Adding V0 Validation Wfs to the RelVal Matrix #39215

AdrianoDee · 2022-08-26T13:02:16Z

PR description:

Requires #39178

This PR adds the wfs to be used for BPH-TRK V0 reconstruction validation to the RelVal matrix.

PR validation:

Running wfs 11744.0, 11745.0, 11746.0, 11747.0, 11748.0, ~~11749.0~~.

cmsbuild · 2022-08-26T13:09:45Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39215/31828

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): TICL version 4: CLUE3D as default Pattern Recognition, Linking #38880, Clean up Phase-2 geometry (Up to D85) #38702, Add run3 tracking low pu era #33532

cmsbuild · 2022-08-26T13:10:10Z

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

mmusich · 2022-08-26T13:10:15Z

test parameters:

pull_request = add gen fragments at 13.6 TeV for BPH-TRK #39178
workflows = 11744.0, 11745.0, 11746.0, 11747.0, 11748.0, 11749.0

AdrianoDee · 2022-08-26T13:10:42Z

please test with #39178

cmsbuild · 2022-08-26T17:01:17Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b1084/27122/summary.html
COMMIT: a7c1dc4
CMSSW: CMSSW_12_5_X_2022-08-25-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39215/27122/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3695708
DQMHistoTests: Total failures: 23
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3695662
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

mmusich · 2022-08-26T17:27:11Z

I don't see the requested workflows

workflows = 11744.0, 11745.0, 11746.0, 11747.0, 11748.0, 11749.0

at https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b1084/27122/runTheMatrix-results/

was #39215 (comment) overriden by #39215 (comment) ?

mmusich · 2022-08-26T17:27:55Z

urgent

this is needed from TRK POG and BPH PAG in CMSSW_12_5_0 to perform V0 tracking optimization studies

srimanob · 2022-08-26T17:56:21Z

test parameters:

pull_request = add gen fragments at 13.6 TeV for BPH-TRK #39178
workflows = 11744.0, 11745.0, 11746.0, 11747.0, 11748.0, 11749.0
relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix

srimanob · 2022-08-26T17:57:08Z

@cmsbuild please test

srimanob · 2022-08-26T17:58:28Z

@cmsbuild please abort

cmsbuild · 2022-09-01T15:10:45Z

Pull request #39215 was updated. @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please check and sign again.

AdrianoDee · 2022-09-01T15:11:10Z

please test

mmusich · 2022-09-02T06:35:56Z

@smuzaffar, tests are running since 15h, is there anything stuck here?

smuzaffar · 2022-09-02T07:25:49Z

sorry @mmusich , job was killed due to a buggy lxplus node. I just have restarted it

cmsbuild · 2022-09-02T08:07:19Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b1084/27275/summary.html
COMMIT: 9b653ba
CMSSW: CMSSW_12_6_X_2022-09-01-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39215/27275/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/pool/condor/dir_23570/jenkins/workspace/compare-root-files-short-matrix/data/PR-0b1084/11744.0_B0ToJpsiK0s_DGamma0_13p6TeV+2021+B0ToJpsiK0s_JMM_Filter_DGamma0_TuneCP5_13p6TeV-pythia8-evtgen_GenSim+Digi+RecoNano+HARVESTNano+ALCA
/pool/condor/dir_23570/jenkins/workspace/compare-root-files-short-matrix/data/PR-0b1084/11745.0_DStarToD0Pi_D0ToKsPiPi_13p6TeV+2021+DStarToD0Pi_D0ToKsPiPi_inclusive_SoftQCD_TuneCP5_13p6TeV-pythia8-ev_GenSim+Digi+RecoNano+HARVESTNano+ALCA
/pool/condor/dir_23570/jenkins/workspace/compare-root-files-short-matrix/data/PR-0b1084/11746.0_LbToJpsiLambda_DGamma0_13p6TeV+2021+LbToJpsiLambda_JMM_Filter_DGamma0_TuneCP5_13p6TeV-pythia8-evtgen_GenSim+Digi+RecoNano+HARVESTNano+ALCA
/pool/condor/dir_23570/jenkins/workspace/compare-root-files-short-matrix/data/PR-0b1084/11747.0_LbToJpsiXiK0sPr_DGamma0_13p6TeV+2021+LbToJpsiXiK0sPi_JMM_Filter_DGamma0_TuneCP5_13p6TeV-pythia8-evtgen_GenSim+Digi+RecoNano+HARVESTNano+ALCA
/pool/condor/dir_23570/jenkins/workspace/compare-root-files-short-matrix/data/PR-0b1084/11748.0_OmegaMinus_13p6TeV+2021+OmegaMinus_13p6TeV_SoftQCDInel_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano+ALCA

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3620448
DQMHistoTests: Total failures: 23
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3620402
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

mmusich · 2022-09-02T08:10:22Z

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 looks like the new round of tests was succesfull.
Can you kindly check and sign again?

kskovpen · 2022-09-02T08:20:38Z

+pdmv

srimanob · 2022-09-02T08:27:56Z

+Upgrade

cmsbuild · 2022-09-02T08:28:22Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

mmusich · 2022-09-06T07:59:51Z

please test

to refresh the tests since add gen fragments at 13.6 TeV for BPH-TRK #39178 was updated.

cmsbuild · 2022-09-06T11:52:23Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b1084/27355/summary.html
COMMIT: 9b653ba
CMSSW: CMSSW_12_6_X_2022-09-05-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39215/27355/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0b1084/11744.0_B0ToJpsiK0s_DGamma0_13p6TeV+2021+B0ToJpsiK0s_JMM_Filter_DGamma0_TuneCP5_13p6TeV-pythia8-evtgen_GenSim+Digi+RecoNano+HARVESTNano+ALCA
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0b1084/11745.0_DStarToD0Pi_D0ToKsPiPi_13p6TeV+2021+DStarToD0Pi_D0ToKsPiPi_inclusive_SoftQCD_TuneCP5_13p6TeV-pythia8-ev_GenSim+Digi+RecoNano+HARVESTNano+ALCA
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0b1084/11746.0_LbToJpsiLambda_DGamma0_13p6TeV+2021+LbToJpsiLambda_JMM_Filter_DGamma0_TuneCP5_13p6TeV-pythia8-evtgen_GenSim+Digi+RecoNano+HARVESTNano+ALCA
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0b1084/11747.0_LbToJpsiXiK0sPr_DGamma0_13p6TeV+2021+LbToJpsiXiK0sPi_JMM_Filter_DGamma0_TuneCP5_13p6TeV-pythia8-evtgen_GenSim+Digi+RecoNano+HARVESTNano+ALCA
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0b1084/11748.0_OmegaMinus_13p6TeV+2021+OmegaMinus_13p6TeV_SoftQCDInel_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano+ALCA

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3618210
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3618186
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

mmusich · 2022-09-07T07:38:44Z

@cms-sw/orp-l2 kind ping (backport of this is needed urgently for 12_5_0).

rappoccio · 2022-09-07T14:17:23Z

+1

AdrianoDee changed the title ~~Adding V0 validation wfs to the matrix~~ Adding V0 Validation Vfs to the RelVal Matrix Aug 26, 2022

cmsbuild added this to the CMSSW_12_5_X milestone Aug 26, 2022

cmsbuild added code-checks-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Aug 26, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 26, 2022

cmsbuild added the requires-external label Aug 26, 2022

cmsbuild added tests-started and removed tests-pending labels Aug 26, 2022

cmsbuild mentioned this pull request Aug 26, 2022

ECAL - Implement follow up issues for Phase 2 GPU reconstruction #39195

Merged

cmsbuild added tests-approved and removed tests-started labels Aug 26, 2022

cmsbuild added the urgent label Aug 26, 2022

cmsbuild added tests-started and removed tests-approved labels Aug 26, 2022

cmsbuild removed the tests-started label Aug 26, 2022

cmsbuild added tests-started and removed tests-pending labels Sep 1, 2022

cmsbuild added tests-approved and removed tests-started labels Sep 2, 2022

cmsbuild added pdmv-approved and removed pdmv-pending labels Sep 2, 2022

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Sep 2, 2022

cmsbuild added tests-started and removed tests-approved labels Sep 6, 2022

cmsbuild added tests-approved and removed tests-started labels Sep 6, 2022

rappoccio merged commit a1512e5 into cms-sw:master Sep 7, 2022

cmsbuild added orp-approved and removed orp-pending labels Sep 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding V0 Validation Wfs to the RelVal Matrix #39215

Adding V0 Validation Wfs to the RelVal Matrix #39215

AdrianoDee commented Aug 26, 2022 •

edited

Loading

cmsbuild commented Aug 26, 2022

cmsbuild commented Aug 26, 2022

mmusich commented Aug 26, 2022

AdrianoDee commented Aug 26, 2022

cmsbuild commented Aug 26, 2022

mmusich commented Aug 26, 2022

mmusich commented Aug 26, 2022

srimanob commented Aug 26, 2022

srimanob commented Aug 26, 2022

srimanob commented Aug 26, 2022

cmsbuild commented Sep 1, 2022

AdrianoDee commented Sep 1, 2022

mmusich commented Sep 2, 2022

smuzaffar commented Sep 2, 2022

cmsbuild commented Sep 2, 2022

mmusich commented Sep 2, 2022

kskovpen commented Sep 2, 2022

srimanob commented Sep 2, 2022

cmsbuild commented Sep 2, 2022

mmusich commented Sep 6, 2022

cmsbuild commented Sep 6, 2022

mmusich commented Sep 7, 2022

rappoccio commented Sep 7, 2022

Adding V0 Validation Wfs to the RelVal Matrix #39215

Adding V0 Validation Wfs to the RelVal Matrix #39215

Conversation

AdrianoDee commented Aug 26, 2022 • edited Loading

PR description:

PR validation:

cmsbuild commented Aug 26, 2022

cmsbuild commented Aug 26, 2022

mmusich commented Aug 26, 2022

AdrianoDee commented Aug 26, 2022

cmsbuild commented Aug 26, 2022

Comparison Summary

mmusich commented Aug 26, 2022

mmusich commented Aug 26, 2022

srimanob commented Aug 26, 2022

srimanob commented Aug 26, 2022

srimanob commented Aug 26, 2022

cmsbuild commented Sep 1, 2022

AdrianoDee commented Sep 1, 2022

mmusich commented Sep 2, 2022

smuzaffar commented Sep 2, 2022

cmsbuild commented Sep 2, 2022

Comparison Summary

mmusich commented Sep 2, 2022

kskovpen commented Sep 2, 2022

srimanob commented Sep 2, 2022

cmsbuild commented Sep 2, 2022

mmusich commented Sep 6, 2022

cmsbuild commented Sep 6, 2022

Comparison Summary

mmusich commented Sep 7, 2022

rappoccio commented Sep 7, 2022

AdrianoDee commented Aug 26, 2022 •

edited

Loading