-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplifying LL1TkMuonFilter #39280
Simplifying LL1TkMuonFilter #39280
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39280/31937
|
A new Pull Request was created by @trtomei (Thiago Tomei) for master. It involves the following packages:
@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
- Added `#include <algorithm>` for the `std::binary_search` - Simplified initialization of the `tkMuonToken_` - Sort the `qualities_` for the `std::binary_search`
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39280/31955
|
Pull request #39280 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-405ea0/27280/summary.html Comparison SummarySummary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
Addressing items 2 and 3 of #39194
applyQualities = false
andqualities = {}
(an empty vector). This is fine; ifapplyQualities
is set totrue
, then some qualities must be furnished!PR validation:
Test done:
runs fine, and the new module interface is exercised.