Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying LL1TkMuonFilter #39280

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Conversation

trtomei
Copy link
Contributor

@trtomei trtomei commented Sep 1, 2022

PR description:

Addressing items 2 and 3 of #39194

  • Simplified the whole applyQualities infrastructure of the module
  • Default is now applyQualities = false and qualities = {} (an empty vector). This is fine; if applyQualities is set to true, then some qualities must be furnished!

PR validation:

Test done:

cmsDriver.py Phase2 -s HLT:75e33 --processName=HLTX \
--conditions auto:phase2_realistic_T21 \
--geometry Extended2026D88 \
--era Phase2C17I13M9 \
--eventcontent FEVTDEBUGHLT \
--filein=/store/relval/CMSSW_12_5_0_pre5/RelValTTbar_14TeV/GEN-SIM-RECO/125X_mcRun4_realistic_v2_2026D88noPU-v1/10000/8abbb6aa-60d0-4d16-8a9a-7b9c95e5aee7.root \
-n 100 --nThreads 1 --no_exec

runs fine, and the new module interface is exercised.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39280/31937

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2022

A new Pull Request was created by @trtomei (Thiago Tomei) for master.

It involves the following packages:

  • HLTrigger/HLTfilters (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

 - Added `#include <algorithm>` for the `std::binary_search`
 - Simplified initialization of the `tkMuonToken_`
 - Sort the `qualities_` for the `std::binary_search`
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39280/31955

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2022

Pull request #39280 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@missirol
Copy link
Contributor

missirol commented Sep 1, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-405ea0/27280/summary.html
COMMIT: 1ad2dc0
CMSSW: CMSSW_12_6_X_2022-09-01-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39280/27280/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3620448
  • DQMHistoTests: Total failures: 15
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3620410
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

missirol commented Sep 2, 2022

+hlt

  • addresses Items-3,4 of #39194
  • differences in outputs of wf 39434.75 are likely due to Item-6 of #39194

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Sep 2, 2022

+1

@cmsbuild cmsbuild merged commit 91b300e into cms-sw:master Sep 2, 2022
@trtomei trtomei deleted the dev_HLTP2_issue39194 branch September 7, 2022 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants