-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx293X Extend the possibility of new cells needed for rotated full wafers #35864
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35864/26251
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35864/26252
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a758c/19992/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+1 |
fix for `TestDQMServicesDemo` unit test [12.1.X]
…121x Fix the Patatrack pixel local reconstruction running on CPU
Fix for multiprocessing in RecoTrack Validation script [12.1.X]
add `process.runType.commissioning_run` in the supported types of `beampixel_dqm_sourceclient-live` [12.1.X]
@AdrianoDee, @srimanob Please approve |
Hi @bsunanda |
No - it has some extension of cell structure. I tested with original as well as new ones. They give satisfactory results. Any small change in geometry makes perturbation in results |
Please hold on - I am checking the code again |
8d108e8
to
f05ee1a
Compare
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35864/26427
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
It was updated from a version CMSSW_12_1_X. So several new files get added. Close this in favor of #35997 |
PR description:
Extend the possibility of new cells needed for rotated full wafers of HGCal
PR validation:
Tested using cfg's in Geometry/HGCalCommonData/test/python
if this PR is a backport please specify the original PR and why you need to report that PR:
Nothing special