-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restrict RunHI2011 to 182124:40, used in the short matrix wf 140.53 #35912
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35912/26309
|
A new Pull Request was created by @slava77 (Slava Krutelyov) for master. It involves the following packages:
@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test TestDQMServicesDemo had ERRORS Comparison SummaryThe workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
this is expected here (only one file is selected now) and the comparisons show no differences in 140.53 (confirming that the same input is used here and in the baseline). |
@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 |
Regarding your question in the PR description, relvals submission will use this setting also. @slava77 |
+1 This PR is to limit the LS used for HI 2011 workflow. It should be OK, to make PR test more stable. If we need relvals, PdmV should modify this before submission happens. |
@cms-sw/pdmv-l2 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
merge
|
this is to improve stability in PR tests where DAS occasionally returns different files for wf 140.53
Due to a rather large number of files in 182124 /HIMinBiasUPC/HIRun2011-v1/RAW (301 file) the order of files in the das query changes occasionally, which leads to different events produced in PR tests for wf 140.53.
This PR is selecting LS 40 from the run, which should select just one file, the same file that was processed in the PR tests for this workflow in a recent IB CMSSW_12_1_X_2021-10-28-2300. The number of events in the selection is still fairly large (1428) for PR-like or even somewhat longer tests.
I'm not sure if the LS selection in relval_steps.py directly applies to relval submission, where more events may be needed. However, it's very likely that we will not run relvals for this data (I see that the last
/HIMinBiasUPC/CMSSW_*/DQMIO
was in 11_1_0)