Use pdigi_hi_nogen for HI MC wfs #35028

mandrenguyen · 2021-08-26T11:15:59Z

PR description:

This PR switches to the DIGI:pdigi_hi_nogen for heavy-ion MC RelVal workflows.

Back in #24199 the option DIGI:pdigi_hi_nogen was introduced.
The previously used pdigi_hi option adds some heavy-ion generator level quantities, such as npart and ncoll, to the output.
The 'nogen' extension prevents gen collections from being reproduced in the digi step.
Most heavy-ion MC requests use an event overlay workflow, with a crossing frame to mix the gen info from the signal and background events.
If the gen info is reproduced at the digi step, we lose the gen info from the background event.
The pdigi_hi_nogen has long been the default option in official MC, but we neglected to switch to this option in the RelVal workflows, which occasionally leads to confusion.
This PR fixes that.

2nd commit: A new validation sequence for the heavy-ion event overlay workflow is added. It ignores genParticles that are not from collisionID = 0 (the signal event)

PR validation:

Tested on wf 159 and 301

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport needed

cmsbuild · 2021-08-26T11:22:58Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35028/24886

This PR adds an extra 44KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): NANO: rework for Prompt (part3) #34714, Add SiStripCalCosmics ALCANANO #34985

cmsbuild · 2021-08-26T11:23:20Z

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @chayanit, @bbilin, @wajidalikhan, @kpedro88, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

AdrianoDee · 2021-08-26T11:52:26Z

test parameters:

workflows = 150.0,159.0,300.0,310.0

AdrianoDee · 2021-08-26T11:52:33Z

please test

srimanob · 2021-08-26T12:43:11Z

test parameters:

workflows = 150.0,159.0,300.0,310.0

srimanob · 2021-08-26T12:43:25Z

@cmsbuild please test

cmsbuild · 2021-08-27T07:51:31Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5de25b/18057/summary.html
COMMIT: 1f35810
CMSSW: CMSSW_12_1_X_2021-08-25-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35028/18057/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5de25b/300.0_Pyquen_GammaJet_pt20_2760GeV+Pyquen_GammaJet_pt20_2760GeV+DIGIHIMIX+RECOHIMIX+HARVESTHI2018PPRECO
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5de25b/310.0_Pyquen_GammaJet_pt20_2760GeV_2021+Pyquen_GammaJet_pt20_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO

Summary:

No significant changes to the logs found
Reco comparison results: 16 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000352
DQMHistoTests: Total failures: 9322
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2991008
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

srimanob · 2021-09-03T16:27:53Z

@mandrenguyen
I see a lot of failure coming from wfs 312,
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_pileup.py#L25
which uses DIGIHI2021MIX.

Could you please go through the report,
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_1_X_2021-08-25-2300+5de25b/45022/validateJR.html
and confirm if this is expected.

Thanks.

mandrenguyen · 2021-09-04T06:39:43Z

@srimanob I checked that wf 312 runs at the prompt without issue. I looked thru the log files, but I'm not spotting anything relevant. Are you able to see where the code is crashing?

srimanob · 2021-09-07T16:52:37Z

Hi @mandrenguyen
Oh, I mean fails in PR test report. I just want to confirm with you that the use of pdigi_hi_nogen is the source of the fail comparison on that specific workflows.

mandrenguyen · 2021-09-07T17:01:22Z

@srimanob Ah, so it's not a crash. The pdigi_hi_nogen flag will change the genParticles in mixing worksflows, which are those that use --pileup HiMix in the DIGI step 312 is such an example. I can't tell from the monitoring pages that you point to whether these changes come from changes to the genParticles.

srimanob · 2021-09-08T14:18:29Z

There are 2 possibilities here. Since DIGI:pdigi_hi_nogen is available since 2018, #24199, we can either

merge this PR and run high statistics test in the next pre-release
or ask PdmV to submit relvals with CMSSW_12_1_0_pre2 with customization and check.

Since the effect on this PR is very limited to HI GEN MC, I would prefer to merge it, and try to run at the next pre-release. Do you agree @qliphy @perrotta @cms-sw/pdmv-l2 ?

srimanob · 2021-09-08T14:18:48Z

+Upgrade

qliphy · 2021-11-15T00:34:39Z

please test
re-test

cmsbuild · 2021-11-15T03:45:23Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5de25b/20525/summary.html
COMMIT: e8d493e
CMSSW: CMSSW_12_2_X_2021-11-14-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35028/20525/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5de25b/300.0_Pyquen_GammaJet_pt20_2760GeV+Pyquen_GammaJet_pt20_2760GeV+DIGIHIMIX+RECOHIMIX+HARVESTHI2018PPRECO
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5de25b/310.0_Pyquen_GammaJet_pt20_2760GeV_2021+Pyquen_GammaJet_pt20_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO

Summary:

No significant changes to the logs found
Reco comparison results: 1297 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 2902040
DQMHistoTests: Total failures: 8787
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2893231
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: found differences in 1 / 41 workflows

jfernan2 · 2021-11-15T07:46:55Z

+1

kskovpen · 2021-11-17T05:19:15Z

+1

perrotta · 2021-11-17T15:55:55Z

Looking at the comparison plots there are quite a lot of differences, and I assume they are kind of expected.
I would agree with what @srimanob wrote above, i.e. "Since the effect on this PR is very limited to HI GEN MC, I would prefer to merge it, and try to run at the next pre-release".
Therefore, if there are no counterindications (and since it has been fully signed I assume there are not) I would merge this PR so that it can be fully validated in pre3.

mandrenguyen · 2021-11-17T16:08:21Z

@perrotta This should only have changed gen quantities. I'm a bit at a loss as to how we can have changes to reco quantities.

perrotta · 2021-11-17T16:17:45Z

@perrotta This should only have changed gen quantities. I'm a bit at a loss as to how we can have changes to reco quantities.

Uhm, since you touched the digi step I assumed that it would have forcibly propagated to reco as well...
But if you say now that it was not expected, then this has to be understood, and also fixed if needed!

mandrenguyen · 2021-11-17T16:25:32Z

Ah, I have updated the release for the pileup dataset. So that's where this effect comes from.

perrotta · 2021-11-17T16:27:29Z

Ah, I have updated the release for the pileup dataset. So that's where this effect comes from.

Indeed, that was my understanding
Therefore you confirm that the changes look reasonable, given that?

mandrenguyen · 2021-11-17T16:34:10Z

Yes, I would say so. Sorry for the noise.

perrotta · 2021-11-17T16:35:24Z

+operations

cmsbuild · 2021-11-17T16:35:48Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-11-18T01:01:08Z

+1

cmsbuild added this to the CMSSW_12_1_X milestone Aug 26, 2021

cmsbuild added code-checks-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Aug 26, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 26, 2021

cmsbuild added tests-started and removed tests-pending labels Aug 26, 2021

cmsbuild added tests-approved and removed tests-started labels Aug 27, 2021

This was referenced Aug 30, 2021

Fix the random segfault of RelVal workflow 573 #35072

Merged

Add SiStripCalCosmics ALCANANO #34985

Merged

cmsbuild added upgrade-approved and removed upgrade-pending labels Sep 8, 2021

cmsbuild added the generators-approved label Nov 8, 2021

cmsbuild mentioned this pull request Nov 12, 2021

Fix prodlike workflows #36050

Closed

cmsbuild added tests-started and removed tests-approved labels Nov 15, 2021

cmsbuild added tests-approved and removed tests-started labels Nov 15, 2021

cmsbuild mentioned this pull request Nov 15, 2021

Add PilotBeam data in relval matrix tests #36133

Merged

cmsbuild added pdmv-approved and removed pdmv-pending labels Nov 17, 2021

cmsbuild added fully-signed operations-approved and removed operations-pending pending-signatures labels Nov 17, 2021

cmsbuild added orp-approved and removed orp-pending labels Nov 18, 2021

cmsbuild merged commit b27d25b into cms-sw:master Nov 18, 2021

mandrenguyen deleted the nogen branch May 31, 2022 18:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use pdigi_hi_nogen for HI MC wfs #35028

Use pdigi_hi_nogen for HI MC wfs #35028

mandrenguyen commented Aug 26, 2021 •

edited

Loading

cmsbuild commented Aug 26, 2021

cmsbuild commented Aug 26, 2021

AdrianoDee commented Aug 26, 2021

AdrianoDee commented Aug 26, 2021

srimanob commented Aug 26, 2021

srimanob commented Aug 26, 2021

cmsbuild commented Aug 27, 2021

srimanob commented Sep 3, 2021

mandrenguyen commented Sep 4, 2021

srimanob commented Sep 7, 2021

mandrenguyen commented Sep 7, 2021

srimanob commented Sep 8, 2021

srimanob commented Sep 8, 2021

qliphy commented Nov 15, 2021

cmsbuild commented Nov 15, 2021

jfernan2 commented Nov 15, 2021

kskovpen commented Nov 17, 2021

perrotta commented Nov 17, 2021 •

edited

Loading

mandrenguyen commented Nov 17, 2021

perrotta commented Nov 17, 2021

mandrenguyen commented Nov 17, 2021

perrotta commented Nov 17, 2021

mandrenguyen commented Nov 17, 2021

perrotta commented Nov 17, 2021

cmsbuild commented Nov 17, 2021

qliphy commented Nov 18, 2021

Use pdigi_hi_nogen for HI MC wfs #35028

Use pdigi_hi_nogen for HI MC wfs #35028

Conversation

mandrenguyen commented Aug 26, 2021 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Aug 26, 2021

cmsbuild commented Aug 26, 2021

AdrianoDee commented Aug 26, 2021

AdrianoDee commented Aug 26, 2021

srimanob commented Aug 26, 2021

srimanob commented Aug 26, 2021

cmsbuild commented Aug 27, 2021

Comparison Summary

srimanob commented Sep 3, 2021

mandrenguyen commented Sep 4, 2021

srimanob commented Sep 7, 2021

mandrenguyen commented Sep 7, 2021

srimanob commented Sep 8, 2021

srimanob commented Sep 8, 2021

qliphy commented Nov 15, 2021

cmsbuild commented Nov 15, 2021

Comparison Summary

jfernan2 commented Nov 15, 2021

kskovpen commented Nov 17, 2021

perrotta commented Nov 17, 2021 • edited Loading

mandrenguyen commented Nov 17, 2021

perrotta commented Nov 17, 2021

mandrenguyen commented Nov 17, 2021

perrotta commented Nov 17, 2021

mandrenguyen commented Nov 17, 2021

perrotta commented Nov 17, 2021

cmsbuild commented Nov 17, 2021

qliphy commented Nov 18, 2021

mandrenguyen commented Aug 26, 2021 •

edited

Loading

perrotta commented Nov 17, 2021 •

edited

Loading