Add PilotBeam data in relval matrix tests #36133
Conversation
|
EDIT: this was fixed in 341ea11 |
|
Issue with |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36133/26648
|
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages:
@perrotta, @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Maybe we should also tag @cms-sw/dqm-l2 , right? |
|
It seems this time the GEM related error is no longer in L1REPACK (as fixed) but rather in DQM (dqmoffline_8_step) - perhaps some similar modifications need to be done there? |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36133/26667
|
|
Pull request #36133 was updated. @perrotta, @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @qliphy, @fabiocos, @davidlange6 can you please check and sign again. |
thanks @Martin-Grunewald indeed i'm investigating the issue with @jfernan2! |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36133/26668
|
|
+pdmv |
|
+Upgrade Adding pilot beam data to runTheMatrix. All added workflows run fine. |
|
+1 |
|
+1 |
cmsbuild
added
fully-signed
operations-approved
orp-approved
and removed
operations-pending
pending-signatures
orp-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
| steps['ALCARECOPROMPTR3']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,ALCA:SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+HcalCalHO+HcalCalIterativePhiSym+HcalCalHBHEMuonFilter+HcalCalIsoTrkFilter,DQM', | ||
| '--conditions':'auto:run3_data_prompt', | ||
| '--scenario':'pp', | ||
| '--era':'Run3', | ||
| '--datatier':'RECO,MINIAOD,ALCARECO,DQMIO', |
There was a problem hiding this comment.
it's puzzling to see MINIAOD in the data outputs but no PAT step
There was a problem hiding this comment.
Hi @slava77 thanks for the suggestion, I admit i'm not a RECO nor PdmV expert, I was merely trying to put in the tests some recent data with wfs as similar as possible to the already existing ones. If you want to open a PR to improve/add these workflow please feel free to do it. Thanks a lot!
| '--datatier':'RECO,MINIAOD,ALCARECO,DQMIO', | ||
| '--eventcontent':'RECO,MINIAOD,ALCARECO,DQM', | ||
| '--triggerResultsProcess': 'RECO', | ||
| '--customise':'Configuration/DataProcessing/RecoTLR.customisePrompt'},steps['RECODR3']]) |
There was a problem hiding this comment.
customisePostEra_Run3 is used in the T0 configuration, see Configuration/DataProcessing/python/Impl/ppEra_Run3.py
There was a problem hiding this comment.
Please see #36133 (comment)
| @@ -2003,6 +2009,15 @@ def lhegensim2018ml(fragment,howMuch): | |||
| '--conditions':'auto:run2_data' | |||
| },steps['TIER0']]) | |||
|
|
|||
| steps['TIER0EXPRUN3']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,EI,ALCAPRODUCER:SiPixelCalZeroBias+SiStripCalZeroBias+SiStripCalMinBias+SiStripCalMinBiasAAG+TkAlMinBias,DQM:@express,ENDJOB', | |||
| '--process':'RECO', | |||
| '--datatier':'ALCARECO,DQMIO', | |||
There was a problem hiding this comment.
what is the reason for a T0 express setup to write only ALCARECO event content? IIRC, the express writes FEVT.
There was a problem hiding this comment.
this was copied from the already existing one:
cmssw/Configuration/PyReleaseValidation/python/relval_steps.py
Lines 2004 to 2011 in 988e293
AFAIK Express step does write ALCARECO.
There was a problem hiding this comment.
is this ALCA-specific step?
https://github.com/dmwm/T0/blob/master/etc/ProdOfflineConfiguration.py
has ALCARECO only in ExpressAlignment and ALCALUMIPIXELSEXPRESS datasets.
@cms-sw/alca-l2 please check/clarify
There was a problem hiding this comment.
All these under the standard express are alcarecos or alcaprompts:
https://github.com/dmwm/T0/blob/master/etc/ProdOfflineConfiguration.py#L246-L250
There was a problem hiding this comment.
All these under the standard express are alcarecos or alcaprompts: https://github.com/dmwm/T0/blob/master/etc/ProdOfflineConfiguration.py#L246-L250
good, but your reference points to the Express PD, which writes FEVT, while this relval step is configured to write ALCARECO. It looks like a fix is needed.
|
|
||
| #Run 3 | ||
| steps['RECODR3']=merge([{'--scenario':'pp', | ||
| '-s':'RAW2DIGI,L1Reco,RECO,DQM', |
There was a problem hiding this comment.
PAT got lost here as well
it seems like this step is not used in any workflow though. so, no harm so far.
PR description:
This PR adds few workflows in the relval matrix to run on PilotBeams2021 data. Spefically:
136.899for standard cosmics processing with CRAFT2021 data138.1/138.2/138.3remain unchanged (apart minor update in name) and are:138.1prompt wf on cosmics138.2express wf on cosmics138.3splashes for 2021 data138.4/138.5are prompt and express (respectively) on 2021 collision data (MinBias, is it ok?)139.00Xcycle (as suggested by @bbilin) for standard (whatever it means) pp processing:139.001for MinBias139.002for ZeroBias139.003for HLTPhysics139.004for NoBPTXImportant Notes:
139.001is failing at step4 (harvesting), see Add PilotBeam data in relval matrix tests #36133 (comment) Any help would be much appreciated.SimL1EmulatorRepack_Full_cff.pyhas been modified to account for GEM unpacker thanks to suggestions from @missirol and @dildick, but step3 of139.002is still failing with the same exception (see Add PilotBeam data in relval matrix tests #36133 (comment)) and I don't understand why...any suggestion?PR validation:
Validation for this PR can be run with:
runTheMatrix.py -l 136.897,136.899,138.1,138.2,138.3,138.4,138.5,139.001,139.002,139.003,139.004 -j8 --ibeosBackport:
N/A