Add DQM Matrix to RelVals

[kskovpen]

PR description:

Following the recent discussions on the use of DQM Matrix in Run 3 wfs (https://indico.cern.ch/event/1084340/contributions/4558962/attachments/2328015/3966321/21-10-14_News_PPD.pdf, slide 8), this PR attempts at introducing similar modifications to the existing Run 2 DQM steps, as well as preserving the current code structure.

Any feedback/criticism is highly appreciated. The current version of this PR is meant to be treated as a draft to collect feedback. Depending on the outcome, the updates can be further propagated to the rest of the wfs.

PR validation:

The currently modified workflows refer to 2018A. An example of one of the updated workflows can be produced by e.g.:

runTheMatrix.py --what standard -l 136.850 -t 8 --wm init

if this PR is a backport please specify the original PR and why you need to backport that PR:

not a backport

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35678/25968

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Use pdigi_hi_nogen for HI MC wfs #35028, Fix for UBSAN DQM crash #35658, Added PPS Alignment to the Prompt Calibration Loop #35631

[cmsbuild]

A new Pull Request was created by @kskovpen for master.

It involves the following packages:

• Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[kskovpen]

please test workflow 136.850

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-182572/19639/summary.html
COMMIT: b515b72
CMSSW: CMSSW_12_1_X_2021-10-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35678/19639/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @atishelmanch Proposed solution to ECAL emulator PR issue  #35557
• @Dr15Jones Converted ObjectSelector system to use edm::stream::EDFilter<> #35575
• @CMSTrackerDPG Prompt calibration loop module for SiPixelLorentzAngle #35507
• @ChrisMisan Diamond sampic dqm #35445

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-182572/19639/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-182572/19639/git-merge-result

RelVals

• 136.85136.85_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM_DQMM+HARVEST2018_L1TEgDQM/step4_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM_DQMM+HARVEST2018_L1TEgDQM.log

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35678/25982

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Use pdigi_hi_nogen for HI MC wfs #35028, Fix for UBSAN DQM crash #35658, Added PPS Alignment to the Prompt Calibration Loop #35631

[cmsbuild]

Pull request #35678 was updated. @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please check and sign again.

[cmsbuild]

Pull request #35678 was updated. @jordan-martins, @bbilin, @wajidalikhan, @emanueleusai, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @kskovpen, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

[kskovpen]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-182572/20561/summary.html
COMMIT: b987a79
CMSSW: CMSSW_12_2_X_2021-11-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35678/20561/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 136.793, 136.731 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3164527
• DQMHistoTests: Total failures: 2059
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3162448
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -86091.634 KiB( 39 files compared)
• DQMHistoSizes: changed ( 136.874 ): -16565.990 KiB CTPPS/TimingDiamond
• DQMHistoSizes: changed ( 136.874 ): -10829.543 KiB CTPPS/TrackingPixel
• DQMHistoSizes: changed ( 136.874 ): -4500.885 KiB Hcal/DigiTask
• DQMHistoSizes: changed ( 136.874 ): -3939.948 KiB L1T/L1TStage2EMTF
• DQMHistoSizes: changed ( 136.874 ): -3592.058 KiB L1T/L1TStage2BMTF
• DQMHistoSizes: changed ( 136.874 ): -3151.653 KiB CTPPS/TimingFastSilicon
• DQMHistoSizes: changed ( 136.874 ): -2923.854 KiB CSC/CSCOfflineMonitor
• DQMHistoSizes: changed ( 136.874 ): -2628.626 KiB L1TEMU/L1TStage2CaloLayer2
• DQMHistoSizes: changed ( 136.874 ): -2604.475 KiB Hcal/TPTask
• DQMHistoSizes: changed ( 136.874 ): -2585.661 KiB Muons_miniAOD/MuonRecoAnalyzer
• DQMHistoSizes: changed ( 136.874 ): ...
• Checked 169 log files, 31 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[kskovpen]

@jfernan2 updated :)

[jfernan2]

Thanks @kskovpen
Do you plan to modify any other wf or we can go ahead?
The reduction according to RelMon is patent (e.g. wf 136.874 = ~50MB less of MEs)

[kskovpen]

Thanks @kskovpen
Do you plan to modify any other wf or we can go ahead?
The reduction according to RelMon is patent (e.g. wf 136.874 = ~50MB less of MEs)

Thanks @jfernan2 ! The ballpark of Run2 wfs is now updated, and the next step should be to apply a consistent schema to the upcoming Run3 processing (once available). This said, I would say that we don't plan any further Run2 updates for now.

[jfernan2]

+1

[kskovpen]

+1

[srimanob]

+Upgrade

This PR updates the DQM matrix used in relvals, as agreed between PdmV and DQM. PR test runs fine, with reduction of the histogram as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• It results in a clean up of the DQM histograms produced, as planned
• Verified and blessed by Pdmv and DQM (among others)