Fix for UBSAN DQM crash

[jfernan2]

PR description:

As pointed out in:
#35605 (comment)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35658/25928

• This PR adds an extra 48KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Added PPS Alignment to the Prompt Calibration Loop #35631, Prompt calibration loop module for SiPixelLorentzAngle #35507, Use pdigi_hi_nogen for HI MC wfs #35028

[cmsbuild]

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

• Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test workflow 1003.0

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bca6ba/19605/summary.html
COMMIT: 98b577c
CMSSW: CMSSW_12_1_X_2021-10-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35658/19605/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @Dr15Jones Better string handling ExternalGeneratorFilter #35611
• @gk199 HCAL: uHTR group 0 LUT bits 12-15 set, used to set LLP trigger fine grain bits  #35599
• @fabferro PPS PixelDigiToRaw sanity check bug fix #35592
• @dildick Fix empty histograms in CSC L1T DQM #35641
• @tvami Include realistic CSCBadChambers in Run-3 MC GTs #35637
• @gartung Utilities/StaticAnalyzer: Update to EventSetupRecord::get calls report  #35635

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bca6ba/19605/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bca6ba/19605/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2796107
• DQMHistoTests: Total failures: 32
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2796053
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -1224.715 KiB( 39 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): -96.688 KiB L1TEMU/L1TdeCSCTPG
• DQMHistoSizes: changed ( 136.731 ): -64.459 KiB L1TEMU/L1TdeCSCTPG
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[srimanob]

Wondering if we should just use @allForPrompt which is updated in #35605, instead of this customization? The difference seems to be only egamma, I guess it can run anyways. So we don't need to customize in several places in future.

[jfernan2]

I fully agree @srimanob
Thanks for the suggestion!

[jfernan2]

please test workflow 1003.0

[cmsbuild]

Pull request #35658 was updated. @jordan-martins, @bbilin, @wajidalikhan, @AdrianoDee, @srimanob, @kskovpen can you please check and sign again.

[srimanob]

Should we abort and start the test again?

[srimanob]

abort

[srimanob]

test parameters:

• workflow = 1003.0

[srimanob]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bca6ba/19681/summary.html
COMMIT: d8d5b23
CMSSW: CMSSW_12_1_X_2021-10-15-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35658/19681/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2751113
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2751085
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 170 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[srimanob]

+Upgrade

Updating DQM and Harvesting sequence of problematic data workflow to allForPrompt. Test runs fine on problematic workflow.

[qliphy]

@cms-sw/pdmv-l2 Any comment?

[kskovpen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1