Phase2-hgx294 Update the longitudinal structure for the V16 (D86) geometry of HGCal

[bsunanda]

PR description:

Update the longitudinal structure for the V16 (D86) geometry of HGCal

PR validation:

Tested using Overlap checking tool and with the runTheMatrix for D86

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35945/26351

• This PR adds an extra 80KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Geometry/HGCalCommonData/data/hgcalwafer/v15f/hgcal.xml modified in PR(s): Phase2-hgx293X Extend the possibility of new cells needed for rotated full wafers #35864

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fda8d3/20165/summary.html
COMMIT: 59bf667
CMSSW: CMSSW_12_2_X_2021-11-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35945/20165/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3608 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2901890
• DQMHistoTests: Total failures: 48655
• DQMHistoTests: Total nulls: 61
• DQMHistoTests: Total successes: 2853152
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35945/26364

• This PR adds an extra 80KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Geometry/HGCalCommonData/data/hgcalwafer/v15f/hgcal.xml modified in PR(s): Phase2-hgx293X Extend the possibility of new cells needed for rotated full wafers #35864

[cmsbuild]

Pull request #35945 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35945/26389

• This PR adds an extra 48KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Geometry/HGCalCommonData/data/hgcalwafer/v15f/hgcal.xml modified in PR(s): Phase2-hgx293X Extend the possibility of new cells needed for rotated full wafers #35864

[cmsbuild]

Pull request #35945 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @AdrianoDee, @srimanob can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fda8d3/20222/summary.html
COMMIT: e28b479
CMSSW: CMSSW_12_2_X_2021-11-02-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35945/20222/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3552 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2901890
• DQMHistoTests: Total failures: 48299
• DQMHistoTests: Total nulls: 63
• DQMHistoTests: Total successes: 2853506
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[cvuosalo]

+1

[bsunanda]

@AdrianoDee, @srimanob Please approve this

[srimanob]

+Upgrade

Without any plots of validation or pointer to the discussion, I only check on the effect of this PR. It affects only D86 as expected. Changes introduced in this PR is limited to XML, and log debug in the plugins.

FYI @cms-sw/hgcal-dpg-l2

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• xml code changes for the V16 (D86) geometry of HGCal
• Differences are visible in the corresponding workflow: as usual they are mostly due to the modified random seed sequences, and it is hard to disentangle the real effect of this PR in the automatically run validation plots