Run4-hgx247 Add some new features for HGCal #30323

bsunanda · 2020-06-21T20:32:27Z

PR description:

Add some new features for HGCal and replaces PR #30294

PR validation:

Tested against workflows of runTheMatrix.py

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2020-06-21T20:32:55Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-21T20:39:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30323/16314

This PR adds an extra 44KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/CaloTopology/interface/HGCalTopology.h modified in PR(s): Phase2-hgx247 Add a few new features for HGCal #30294
- File Geometry/CaloTopology/src/HGCalTopology.cc modified in PR(s): Phase2-hgx247 Add a few new features for HGCal #30294
- File Geometry/HGCalCommonData/interface/HGCalDDDConstants.h modified in PR(s): Phase2-hgx247 Add a few new features for HGCal #30294
- File Geometry/HGCalCommonData/interface/HGCalGeomTools.h modified in PR(s): Phase2-hgx247 Add a few new features for HGCal #30294
- File Geometry/HGCalCommonData/interface/HGCalTypes.h modified in PR(s): Phase2-hgx247 Add a few new features for HGCal #30294
- File Geometry/HGCalCommonData/python/testHGCalV13XML_cfi.py modified in PR(s): Phase2-hgx247 Add a few new features for HGCal #30294
- File Geometry/HGCalCommonData/src/HGCalDDDConstants.cc modified in PR(s): Phase2-hgx247 Add a few new features for HGCal #30294, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File Geometry/HGCalCommonData/src/HGCalGeomTools.cc modified in PR(s): Phase2-hgx247 Add a few new features for HGCal #30294
- File Geometry/HGCalGeometry/test/HGCalGeomLocatorTester.cc modified in PR(s): Phase2-hgx247 Add a few new features for HGCal #30294
- File Geometry/HGCalGeometry/test/python/testHGCalGeomLocator_cfg.py modified in PR(s): Phase2-hgx247 Add a few new features for HGCal #30294
- File L1Trigger/Configuration/python/SimL1Emulator_cff.py modified in PR(s): Phase2-hgx247 Add a few new features for HGCal #30294, New Package - Phase2 L1CaloTrigger #29904

cmsbuild · 2020-06-21T20:39:45Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/CaloTopology
Geometry/HGCalCommonData
Geometry/HGCalGeometry
L1Trigger/Configuration

@benkrikler, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @rekovic, @kpedro88, @civanch can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2020-06-21T20:40:40Z

@cmsbuild Please test

cmsbuild · 2020-06-21T20:41:04Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-21-0000/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7233/console Started: 2020/06/21 23:01

cmsbuild · 2020-06-21T22:23:20Z

+1
Tested at: 8af2340
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d93ef/7233/summary.html
CMSSW: CMSSW_11_2_X_2020-06-21-0000
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-06-21T22:23:23Z

Comparison job queued.

cmsbuild · 2020-06-22T03:13:50Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d93ef/7233/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778811
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778757
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

cvuosalo · 2020-06-22T17:30:52Z

+1

bsunanda · 2020-06-23T20:14:46Z

@rekovic @kpedro88 Could you approve this PR?

kpedro88 · 2020-06-23T20:19:00Z

+upgrade

bsunanda · 2020-06-24T15:50:50Z

@rekovic Please approve this PR

bsunanda · 2020-06-24T20:21:07Z

@silviodonato Can this PR be integrated soon? That will help to move on for the next HGCal verson

silviodonato · 2020-06-25T06:59:34Z

merge
@rekovic

…-Run4-hgx247 Restore "Run4-hgx247 Add some new features for HGCal" (#30323)

Run4-hgx250 Backport the corrections to HGCal geometry most relevant for partial wafers from 3 PR's #30323 #30413 #30425

Add some new features for HGCal

8af2340

cmsbuild added this to the CMSSW_11_2_X milestone Jun 21, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending l1-pending orp-pending pending-signatures tests-pending upgrade-pending labels Jun 21, 2020

bsunanda mentioned this pull request Jun 21, 2020

Phase2-hgx247 Add a few new features for HGCal #30294

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 21, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 21, 2020

cmsbuild added tests-approved and removed tests-started labels Jun 21, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 22, 2020

cmsbuild mentioned this pull request Jun 22, 2020

New Package - Phase2 L1CaloTrigger #30325

Merged

cmsbuild removed the geometry-pending label Jun 22, 2020

cmsbuild added the geometry-approved label Jun 22, 2020

cmsbuild mentioned this pull request Jun 23, 2020

New Package - Phase2 L1CaloTrigger #29904

Closed

cmsbuild added upgrade-approved and removed upgrade-pending labels Jun 23, 2020

cmsbuild added orp-approved and removed orp-pending labels Jun 25, 2020

cmsbuild merged commit c6ab457 into cms-sw:master Jun 25, 2020

jbsauvan mentioned this pull request Jun 29, 2020

New Package - Phase2 L1TTrackMatch #30363

Merged

This was referenced Jun 29, 2020

Revert "Run4-hgx247 Add some new features for HGCal" #30458

Merged

Restore "Run4-hgx247 Add some new features for HGCal" (#30323) #30467

Closed

jbsauvan mentioned this pull request Jun 30, 2020

Update module mapping for V11 cms-data/L1Trigger-L1THGCal#19

Merged

bsunanda mentioned this pull request Jun 30, 2020

Phase2-geox02 Make workflow for a version with HGCal V13 #30442

Merged

jbsauvan mentioned this pull request Jun 30, 2020

[HGC trigger] Update mapping for V11 #30470

Merged

silviodonato mentioned this pull request Jun 30, 2020

Restore "Run4-hgx247 Add some new features for HGCal" (#30323) #30473

Merged

bsunanda mentioned this pull request Jul 1, 2020

Phase2-hgx250 Comparison of results from flat file and from insitu checks #30423

Merged

cmsbuild added a commit that referenced this pull request Jul 1, 2020

Merge pull request #30473 from silviodonato/revert-30458-revert-30323…

0ad2f1c

…-Run4-hgx247 Restore "Run4-hgx247 Add some new features for HGCal" (#30323)

bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Jul 2, 2020

Backport cms-sw#30323 cms-sw#30413 cms-sw#30425

6f7800d

bsunanda mentioned this pull request Jul 2, 2020

Run4-hgx250 Backport the corrections to HGCal geometry most relevant for partial wafers from 3 PR's #30323 #30413 #30425 #30511

Merged

silviodonato mentioned this pull request Jul 3, 2020

[HGC trigger] Update mapping for V11 (backport 11_1_X) #30516

Merged

cmsbuild added a commit that referenced this pull request Jul 4, 2020

Merge pull request #30511 from bsunanda/Run4-hgx250

72603d4

Run4-hgx250 Backport the corrections to HGCal geometry most relevant for partial wafers from 3 PR's #30323 #30413 #30425

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run4-hgx247 Add some new features for HGCal #30323

Run4-hgx247 Add some new features for HGCal #30323

bsunanda commented Jun 21, 2020 •

edited

Loading

cmsbuild commented Jun 21, 2020

cmsbuild commented Jun 21, 2020

cmsbuild commented Jun 21, 2020

bsunanda commented Jun 21, 2020

cmsbuild commented Jun 21, 2020 •

edited

Loading

cmsbuild commented Jun 21, 2020

cmsbuild commented Jun 21, 2020

cmsbuild commented Jun 22, 2020

cvuosalo commented Jun 22, 2020

bsunanda commented Jun 23, 2020

kpedro88 commented Jun 23, 2020

bsunanda commented Jun 24, 2020

bsunanda commented Jun 24, 2020

silviodonato commented Jun 25, 2020

Run4-hgx247 Add some new features for HGCal #30323

Run4-hgx247 Add some new features for HGCal #30323

Conversation

bsunanda commented Jun 21, 2020 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jun 21, 2020

cmsbuild commented Jun 21, 2020

cmsbuild commented Jun 21, 2020

bsunanda commented Jun 21, 2020

cmsbuild commented Jun 21, 2020 • edited Loading

cmsbuild commented Jun 21, 2020

cmsbuild commented Jun 21, 2020

cmsbuild commented Jun 22, 2020

cvuosalo commented Jun 22, 2020

bsunanda commented Jun 23, 2020

kpedro88 commented Jun 23, 2020

bsunanda commented Jun 24, 2020

bsunanda commented Jun 24, 2020

silviodonato commented Jun 25, 2020

bsunanda commented Jun 21, 2020 •

edited

Loading

cmsbuild commented Jun 21, 2020 •

edited

Loading