New Package - Phase2 L1CaloTrigger #29904

rekovic · 2020-05-19T09:42:06Z

PR description: New package for Phase2 L1Trigger

Contains only Standalone EG in Barrel and EndCap. These STA objects are needed for the L1T Correlator and ParticleFlow, which will be PRed afterwards.

These currently hold 3 data files, which will be moved to Externals during the code review.

Co-authored-by: Gianluca <[email protected]> Co-authored-by: Cecile Caillol <[email protected]>

cmsbuild · 2020-05-19T09:42:31Z

The code-checks are being triggered in jenkins.

rekovic · 2020-05-19T09:42:34Z

will move the data files.

cmsbuild · 2020-05-19T09:48:24Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29904/15489

This PR adds an extra 328KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29904/15489/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29904/15489/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-05-19T10:24:33Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-19T10:30:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29904/15492

This PR adds an extra 328KB to repository

cmsbuild · 2020-05-19T10:30:28Z

A new Pull Request was created by @rekovic for master.

It involves the following packages:

L1Trigger/L1CaloTrigger

The following packages do not have a category, yet:

L1Trigger/L1CaloTrigger
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

silviodonato · 2020-05-19T12:56:03Z

assign l1

silviodonato · 2020-05-19T12:56:11Z

assign upgrade

cmsbuild · 2020-05-19T12:56:25Z

New categories assigned: upgrade,l1

@benkrikler,@rekovic,@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

kpedro88 · 2020-05-19T14:53:52Z

@rekovic in addition to moving the data files, the commits in this PR should be rebased or squashed so that the data files never enter the cmssw repository history

L1Trigger/L1CaloTrigger/interface/L1EGammaEECalibrator.h

L1Trigger/L1CaloTrigger/interface/ParametricCalibration.h

L1Trigger/L1CaloTrigger/src/L1EGammaEECalibrator.cc

L1Trigger/L1CaloTrigger/src/ParametricCalibration.cc

kpedro88 · 2020-05-19T17:45:46Z

@rekovic a lot of these code review comments are the same ones that I make every time: no legacy producers, CMS code rules, basic cleanup, etc. It will speed the review and integration process for the remaining PRs if these issues are addressed before the PRs are submitted.

cmsbuild · 2020-06-24T23:04:19Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-24T23:09:37Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29904/16406

This PR adds an extra 380KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/Configuration/python/SimL1Emulator_cff.py modified in PR(s): Run4-hgx247 Add some new features for HGCal #30323, New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/BuildFile.xml modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/interface/L1EGammaEECalibrator.h modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/interface/ParametricCalibration.h modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/plugins/BuildFile.xml modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/plugins/L1EGammaCrystalsEmulatorProducer.cc modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/plugins/L1EGammaEEProducer.cc modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/python/L1EGammaCrystalsEmulatorProducer_cfi.py modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/python/L1TowerCalibrationProducer_cfi.py modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/python/l1EGammaCrystalsProducer_cfi.py modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/python/l1EGammaEEProducer_cfi.py modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/python/ntuple_cfi.py modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/python/test_L1EGCrystalClusterEmulator_cfg.py modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/src/L1EGammaEECalibrator.cc modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/src/ParametricCalibration.cc modified in PR(s): New Package - Phase2 L1CaloTrigger #30325

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29904/16406/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29904/16406/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-06-24T23:13:14Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-24T23:19:48Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29904/16407

This PR adds an extra 392KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/Configuration/python/SimL1Emulator_cff.py modified in PR(s): Run4-hgx247 Add some new features for HGCal #30323, New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/BuildFile.xml modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/interface/L1EGammaEECalibrator.h modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/interface/ParametricCalibration.h modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/plugins/BuildFile.xml modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/plugins/L1EGammaCrystalsEmulatorProducer.cc modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/plugins/L1EGammaEEProducer.cc modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/python/L1EGammaCrystalsEmulatorProducer_cfi.py modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/python/L1TowerCalibrationProducer_cfi.py modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/python/l1EGammaCrystalsProducer_cfi.py modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/python/l1EGammaEEProducer_cfi.py modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/python/ntuple_cfi.py modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/python/test_L1EGCrystalClusterEmulator_cfg.py modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/src/L1EGammaEECalibrator.cc modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/src/ParametricCalibration.cc modified in PR(s): New Package - Phase2 L1CaloTrigger #30325

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29904/16407/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29904/16407/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-06-24T23:25:32Z

The code-checks are being triggered in jenkins.

rekovic · 2020-06-24T23:28:39Z

At this point, almost all the comments are addressed. Will use this version to rebase onto #30325

cmsbuild · 2020-06-24T23:30:37Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-24T23:36:02Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29904/16409

This PR adds an extra 396KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/Configuration/python/SimL1Emulator_cff.py modified in PR(s): Run4-hgx247 Add some new features for HGCal #30323, New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/BuildFile.xml modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/interface/L1EGammaEECalibrator.h modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/interface/ParametricCalibration.h modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/plugins/BuildFile.xml modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/plugins/L1EGammaCrystalsEmulatorProducer.cc modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/plugins/L1EGammaEEProducer.cc modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/python/L1EGammaCrystalsEmulatorProducer_cfi.py modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/python/L1TowerCalibrationProducer_cfi.py modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/python/l1EGammaCrystalsProducer_cfi.py modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/python/l1EGammaEEProducer_cfi.py modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/python/ntuple_cfi.py modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/python/test_L1EGCrystalClusterEmulator_cfg.py modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/src/L1EGammaEECalibrator.cc modified in PR(s): New Package - Phase2 L1CaloTrigger #30325
- File L1Trigger/L1CaloTrigger/src/ParametricCalibration.cc modified in PR(s): New Package - Phase2 L1CaloTrigger #30325

cmsbuild · 2020-06-24T23:36:29Z

Pull request #29904 was updated. @cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please check and sign again.

silviodonato · 2020-06-25T09:34:41Z

moved to #30325

Phase2 L1CaloTrigger - only Standalone EG in Barrel and EndCap.

68b26e2

Co-authored-by: Gianluca <[email protected]> Co-authored-by: Cecile Caillol <[email protected]>

cmsbuild added this to the CMSSW_11_1_X milestone May 19, 2020

cmsbuild added code-checks-pending comparison-pending new-package-pending orp-pending pending-signatures tests-pending labels May 19, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 19, 2020

Code format.

d09d889

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 19, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 19, 2020

cmsbuild added l1-pending upgrade-pending labels May 19, 2020

kpedro88 reviewed May 19, 2020

View reviewed changes

smuzaffar removed this from the CMSSW_11_1_X milestone May 22, 2020

cmsbuild added the code-checks-rejected label Jun 24, 2020

Address move multiline functions.

a33b61a

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 24, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 24, 2020

Address constexpr.

5da1500

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 24, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 24, 2020

Address magic numbers - add comment.

680252b

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 24, 2020

code format.

b4fdcc3

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 24, 2020

rekovic added a commit to cms-l1t-offline/cmssw that referenced this pull request Jun 25, 2020

Addressed comments of cms-sw#29904 (b4fdcc3)

32952c6

silviodonato closed this Jun 25, 2020

cmsbuild pushed a commit that referenced this pull request Jun 29, 2020

Addressed comments of #29904 (b4fdcc3)

071ddb6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Package - Phase2 L1CaloTrigger #29904

New Package - Phase2 L1CaloTrigger #29904

rekovic commented May 19, 2020

cmsbuild commented May 19, 2020

rekovic commented May 19, 2020

cmsbuild commented May 19, 2020

cmsbuild commented May 19, 2020

cmsbuild commented May 19, 2020

cmsbuild commented May 19, 2020

silviodonato commented May 19, 2020

silviodonato commented May 19, 2020

cmsbuild commented May 19, 2020

kpedro88 commented May 19, 2020

kpedro88 commented May 19, 2020

cmsbuild commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

rekovic commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

silviodonato commented Jun 25, 2020

New Package - Phase2 L1CaloTrigger #29904

New Package - Phase2 L1CaloTrigger #29904

Conversation

rekovic commented May 19, 2020

PR description: New package for Phase2 L1Trigger

cmsbuild commented May 19, 2020

rekovic commented May 19, 2020

cmsbuild commented May 19, 2020

cmsbuild commented May 19, 2020

cmsbuild commented May 19, 2020

cmsbuild commented May 19, 2020

silviodonato commented May 19, 2020

silviodonato commented May 19, 2020

cmsbuild commented May 19, 2020

kpedro88 commented May 19, 2020

kpedro88 commented May 19, 2020

cmsbuild commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

rekovic commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

silviodonato commented Jun 25, 2020