New Package - Phase2 L1CaloTrigger #30325

rekovic · 2020-06-22T09:24:51Z

New Package for L1T Phase2: Only Standalone EG in Barrel and EndCap,

PR description:

addressed comments, with data files removed.
depends on externals L1T Calo data files Phase1 and Phase2 cms-data/L1Trigger-L1TCalorimeter#22
supersedes New Package - Phase2 L1CaloTrigger #29904

rekovic · 2020-06-22T09:25:08Z

assign upgrade

cmsbuild · 2020-06-22T09:25:15Z

The code-checks are being triggered in jenkins.

rekovic · 2020-06-22T09:25:15Z

assign l1

rekovic · 2020-06-22T09:26:25Z

test parameters

pull_request = L1T Calo data files Phase1 and Phase2 cms-data/L1Trigger-L1TCalorimeter#22

rekovic · 2020-06-22T09:26:42Z

please test

cmsbuild · 2020-06-22T09:34:07Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30325/16317

This PR adds an extra 36KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/Configuration/python/SimL1Emulator_cff.py modified in PR(s): New Package - Phase2 L1CaloTrigger #29904, Run4-hgx247 Add some new features for HGCal #30323
- File L1Trigger/L1CaloTrigger/BuildFile.xml modified in PR(s): New Package - Phase2 L1CaloTrigger #29904
- File L1Trigger/L1CaloTrigger/interface/L1EGammaEECalibrator.h modified in PR(s): New Package - Phase2 L1CaloTrigger #29904
- File L1Trigger/L1CaloTrigger/interface/ParametricCalibration.h modified in PR(s): New Package - Phase2 L1CaloTrigger #29904
- File L1Trigger/L1CaloTrigger/plugins/BuildFile.xml modified in PR(s): New Package - Phase2 L1CaloTrigger #29904
- File L1Trigger/L1CaloTrigger/plugins/L1EGammaCrystalsEmulatorProducer.cc modified in PR(s): New Package - Phase2 L1CaloTrigger #29904
- File L1Trigger/L1CaloTrigger/plugins/L1EGammaEEProducer.cc modified in PR(s): New Package - Phase2 L1CaloTrigger #29904
- File L1Trigger/L1CaloTrigger/python/L1EGammaCrystalsEmulatorProducer_cfi.py modified in PR(s): New Package - Phase2 L1CaloTrigger #29904
- File L1Trigger/L1CaloTrigger/python/L1TowerCalibrationProducer_cfi.py modified in PR(s): New Package - Phase2 L1CaloTrigger #29904
- File L1Trigger/L1CaloTrigger/python/l1EGammaCrystalsProducer_cfi.py modified in PR(s): New Package - Phase2 L1CaloTrigger #29904
- File L1Trigger/L1CaloTrigger/python/l1EGammaEEProducer_cfi.py modified in PR(s): New Package - Phase2 L1CaloTrigger #29904
- File L1Trigger/L1CaloTrigger/python/ntuple_cfi.py modified in PR(s): New Package - Phase2 L1CaloTrigger #29904
- File L1Trigger/L1CaloTrigger/python/test_L1EGCrystalClusterEmulator_cfg.py modified in PR(s): New Package - Phase2 L1CaloTrigger #29904
- File L1Trigger/L1CaloTrigger/src/L1EGammaEECalibrator.cc modified in PR(s): New Package - Phase2 L1CaloTrigger #29904
- File L1Trigger/L1CaloTrigger/src/ParametricCalibration.cc modified in PR(s): New Package - Phase2 L1CaloTrigger #29904

cmsbuild · 2020-06-22T09:34:34Z

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild · 2020-06-22T09:34:35Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-21-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7240/console Started: 2020/06/22 11:35

cmsbuild · 2020-06-22T09:34:36Z

A new Pull Request was created by @rekovic for master.

It involves the following packages:

L1Trigger/Configuration
L1Trigger/L1CaloTrigger

The following packages do not have a category, yet:

L1Trigger/L1CaloTrigger
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

L1Trigger/L1CaloTrigger/plugins/L1EGammaEEProducer.cc

cmsbuild · 2020-06-22T10:53:10Z

-1

Tested at: c67896b

CMSSW: CMSSW_11_2_X_2020-06-21-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd687b/7240/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
20034.0 step2

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35.log

20434.0 step2

runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41.log

23234.0 step2

runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49.log

21234.0 step2

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44.log

cmsbuild · 2020-06-22T10:53:12Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

L1Trigger/L1CaloTrigger/plugins/L1EGammaEEProducer.cc

cmsbuild · 2020-06-29T17:07:05Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #30363,cms-data/L1Trigger-L1TCalorimeter#22,cms-data/L1Trigger-L1TMuon#18,#30245,#30458

CMSSW_11_2_X_2020-06-29-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7502/console Started: 2020/06/29 21:51

cmsbuild · 2020-06-29T21:45:46Z

-1
@rekovic This pull request cannot be automatically merged, could you please rebase it?

You can see the log for git cms-merge-topic here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30325/7502/git-merge-result

cmsbuild · 2020-06-30T09:19:35Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #30363,cms-data/L1Trigger-L1TCalorimeter#22,cms-data/L1Trigger-L1TMuon#18,#30245,#30458

CMSSW_11_2_X_2020-06-29-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7513/console Started: 2020/06/30 11:30

cmsbuild · 2020-06-30T09:47:12Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #30363,cms-data/L1Trigger-L1TCalorimeter#22,cms-data/L1Trigger-L1TMuon#18,#30245,#30458

CMSSW_11_2_X_2020-06-29-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7514/console Started: 2020/06/30 11:49

cmsbuild · 2020-06-30T11:54:09Z

+1
Tested at: 1c3c7f6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a912c/7514/summary.html
CMSSW: CMSSW_11_2_X_2020-06-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

added esConsumes to modules in RecoLocalMuon/GEMSegment #30451 @JamminJones: added esConsumes to modules in RecoLocalMuon/GEMSegment
added esConsumes to modules in RecoLocalMuon/GEMRecHit #30450 @JamminJones: added esConsumes to modules in RecoLocalMuon/GEMRecHit
Revert "Run4-hgx247 Add some new features for HGCal" #30458 @cms-sw: Revert "Run4-hgx247 Add some new features for HGCal"

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a912c/7514/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a912c/7514/git-merge-result

cmsbuild · 2020-06-30T11:54:24Z

Comparison job queued.

cmsbuild · 2020-06-30T13:46:33Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a912c/7514/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778915
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778864
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

cmsbuild · 2020-07-01T09:10:21Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #30363,cms-data/L1Trigger-L1TCalorimeter#22,cms-data/L1Trigger-L1TMuon#18,#30245,#30458

CMSSW_11_2_X_2020-06-30-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7551/console Started: 2020/07/01 11:13

cmsbuild · 2020-07-01T11:02:50Z

+1
Tested at: 1c3c7f6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a912c/7551/summary.html
CMSSW: CMSSW_11_2_X_2020-06-30-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-01T11:03:07Z

Comparison job queued.

cmsbuild · 2020-07-01T13:23:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a912c/7551/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2784120
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2784064
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
Checked 154 log files, 17 edm output root files, 37 DQM output files

cmsbuild added this to the CMSSW_11_2_X milestone Jun 22, 2020

cmsbuild added code-checks-pending comparison-pending l1-pending new-package-pending orp-pending pending-signatures tests-pending upgrade-pending labels Jun 22, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 22, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 22, 2020

rekovic commented Jun 22, 2020

View reviewed changes

L1Trigger/L1CaloTrigger/plugins/L1EGammaEEProducer.cc Outdated Show resolved Hide resolved

rekovic commented Jun 22, 2020

View reviewed changes

L1Trigger/L1CaloTrigger/plugins/L1EGammaEEProducer.cc Outdated Show resolved Hide resolved

rekovic commented Jun 22, 2020

View reviewed changes

L1Trigger/L1CaloTrigger/plugins/L1EGammaEEProducer.cc Outdated Show resolved Hide resolved

rekovic commented Jun 22, 2020

View reviewed changes

L1Trigger/L1CaloTrigger/plugins/L1EGammaEEProducer.cc Outdated Show resolved Hide resolved

cmsbuild removed comparison-pending tests-started labels Jun 22, 2020

cmsbuild merged commit 9c9e72f into cms-sw:master Jun 29, 2020

cmsbuild mentioned this pull request Jun 29, 2020

Revert "Run4-hgx247 Add some new features for HGCal" #30458

Merged

cmsbuild added tests-started and removed tests-approved labels Jun 29, 2020

cmsbuild added comparison-pending tests-approved and removed comparison-available tests-started labels Jun 30, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 30, 2020

cmsbuild added tests-started and removed tests-approved labels Jul 1, 2020

cmsbuild added comparison-pending tests-approved and removed comparison-available tests-started labels Jul 1, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 1, 2020

silviodonato mentioned this pull request Jul 3, 2020

[Phase2-L1T] Turn on L1CaloTrigger, L1TrackMatch and L1ParticleFlow #30520

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Package - Phase2 L1CaloTrigger #30325

New Package - Phase2 L1CaloTrigger #30325

rekovic commented Jun 22, 2020

rekovic commented Jun 22, 2020

cmsbuild commented Jun 22, 2020

rekovic commented Jun 22, 2020

rekovic commented Jun 22, 2020

rekovic commented Jun 22, 2020

cmsbuild commented Jun 22, 2020

cmsbuild commented Jun 22, 2020

cmsbuild commented Jun 22, 2020 •

edited

Loading

cmsbuild commented Jun 22, 2020

cmsbuild commented Jun 22, 2020

cmsbuild commented Jun 22, 2020

cmsbuild commented Jun 29, 2020 •

edited

Loading

cmsbuild commented Jun 29, 2020

cmsbuild commented Jun 30, 2020 •

edited

Loading

cmsbuild commented Jun 30, 2020 •

edited

Loading

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jul 1, 2020 •

edited

Loading

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

New Package - Phase2 L1CaloTrigger #30325

New Package - Phase2 L1CaloTrigger #30325

Conversation

rekovic commented Jun 22, 2020

PR description:

rekovic commented Jun 22, 2020

cmsbuild commented Jun 22, 2020

rekovic commented Jun 22, 2020

rekovic commented Jun 22, 2020

rekovic commented Jun 22, 2020

cmsbuild commented Jun 22, 2020

cmsbuild commented Jun 22, 2020

cmsbuild commented Jun 22, 2020 • edited Loading

cmsbuild commented Jun 22, 2020

cmsbuild commented Jun 22, 2020

cmsbuild commented Jun 22, 2020

cmsbuild commented Jun 29, 2020 • edited Loading

cmsbuild commented Jun 29, 2020

cmsbuild commented Jun 30, 2020 • edited Loading

cmsbuild commented Jun 30, 2020 • edited Loading

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jul 1, 2020 • edited Loading

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jun 22, 2020 •

edited

Loading

cmsbuild commented Jun 29, 2020 •

edited

Loading

cmsbuild commented Jun 30, 2020 •

edited

Loading

cmsbuild commented Jun 30, 2020 •

edited

Loading

cmsbuild commented Jul 1, 2020 •

edited

Loading