Revert "Run4-hgx247 Add some new features for HGCal" #30458

silviodonato · 2020-06-29T17:04:12Z

...for testing with #30363

cmsbuild · 2020-06-29T17:04:36Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-29T17:07:08Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #30363,cms-data/L1Trigger-L1TCalorimeter#22,cms-data/L1Trigger-L1TMuon#18,#30325,#30245

CMSSW_11_2_X_2020-06-29-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7502/console Started: 2020/06/29 21:51

cmsbuild · 2020-06-29T18:01:20Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30458/16591

This PR adds an extra 8KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/CaloTopology/interface/HGCalTopology.h modified in PR(s): Phase2-hgx250 Comparison of results from flat file and from insitu checks #30423
- File Geometry/CaloTopology/src/HGCalTopology.cc modified in PR(s): Phase2-hgx250 Comparison of results from flat file and from insitu checks #30423
- File Geometry/HGCalCommonData/interface/HGCalDDDConstants.h modified in PR(s): Phase2-hgx250 Comparison of results from flat file and from insitu checks #30423
- File Geometry/HGCalCommonData/python/testHGCalV13XML_cfi.py modified in PR(s): Phase2-hgx250 Comparison of results from flat file and from insitu checks #30423
- File Geometry/HGCalCommonData/src/HGCalDDDConstants.cc modified in PR(s): Phase2-hgx250 Comparison of results from flat file and from insitu checks #30423, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File L1Trigger/Configuration/python/SimL1Emulator_cff.py modified in PR(s): New Package - Phase2 L1TTrackMatch #30363

cmsbuild · 2020-06-29T18:01:46Z

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

Geometry/CaloTopology
Geometry/HGCalCommonData
Geometry/HGCalGeometry
L1Trigger/Configuration

@benkrikler, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @rekovic, @kpedro88, @civanch can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2020-06-29T21:45:52Z

-1
@silviodonato This pull request cannot be automatically merged, could you please rebase it?

You can see the log for git cms-merge-topic here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30458/7502/git-merge-result

silviodonato · 2020-06-30T08:18:31Z

please test

cmsbuild · 2020-06-30T08:18:54Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-29-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7511/console Started: 2020/06/30 10:46

cmsbuild · 2020-06-30T09:19:38Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #30363,cms-data/L1Trigger-L1TCalorimeter#22,cms-data/L1Trigger-L1TMuon#18,#30325,#30245

CMSSW_11_2_X_2020-06-29-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7513/console Started: 2020/06/30 11:30

cmsbuild · 2020-06-30T09:47:16Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #30363,cms-data/L1Trigger-L1TCalorimeter#22,cms-data/L1Trigger-L1TMuon#18,#30325,#30245

CMSSW_11_2_X_2020-06-29-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7514/console Started: 2020/06/30 11:49

cmsbuild · 2020-06-30T11:54:17Z

+1
Tested at: a1a1f9a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a912c/7514/summary.html
CMSSW: CMSSW_11_2_X_2020-06-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

added esConsumes to modules in RecoLocalMuon/GEMSegment #30451 @JamminJones: added esConsumes to modules in RecoLocalMuon/GEMSegment
added esConsumes to modules in RecoLocalMuon/GEMRecHit #30450 @JamminJones: added esConsumes to modules in RecoLocalMuon/GEMRecHit
Revert "Run4-hgx247 Add some new features for HGCal" #30458 @cms-sw: Revert "Run4-hgx247 Add some new features for HGCal"

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a912c/7514/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a912c/7514/git-merge-result

cmsbuild · 2020-06-30T11:54:27Z

Comparison job queued.

cmsbuild · 2020-06-30T13:46:38Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a912c/7514/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778915
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778864
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

cmsbuild · 2020-07-01T09:10:24Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #30363,cms-data/L1Trigger-L1TCalorimeter#22,cms-data/L1Trigger-L1TMuon#18,#30325,#30245

CMSSW_11_2_X_2020-06-30-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7551/console Started: 2020/07/01 11:13

cmsbuild · 2020-07-01T11:02:58Z

+1
Tested at: a1a1f9a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a912c/7551/summary.html
CMSSW: CMSSW_11_2_X_2020-06-30-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-01T11:03:10Z

Comparison job queued.

cmsbuild · 2020-07-01T13:23:30Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a912c/7551/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2784120
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2784064
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
Checked 154 log files, 17 edm output root files, 37 DQM output files

cvuosalo · 2020-09-18T20:04:09Z

+1

Revert "Run4-hgx247 Add some new features for HGCal"

a1a1f9a

cmsbuild added this to the CMSSW_11_2_X milestone Jun 29, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending l1-pending orp-pending pending-signatures tests-pending upgrade-pending labels Jun 29, 2020

silviodonato mentioned this pull request Jun 29, 2020

New Package - Phase2 L1TTrackMatch #30363

Merged

cmsbuild added requires-external tests-started and removed tests-pending labels Jun 29, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 29, 2020

cmsbuild added tests-pending and removed tests-started labels Jun 30, 2020

cmsbuild removed the requires-external label Jun 30, 2020

cmsbuild added the orp-approved label Jun 30, 2020

cmsbuild merged commit 48037cb into master Jun 30, 2020

cmsbuild added the requires-external label Jun 30, 2020

cmsbuild added tests-approved and removed tests-started labels Jun 30, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 30, 2020

This was referenced Jun 30, 2020

Restore "Run4-hgx247 Add some new features for HGCal" (#30323) #30467

Closed

Restore "Run4-hgx247 Add some new features for HGCal" (#30323) #30473

Merged

cmsbuild added tests-started and removed tests-approved labels Jul 1, 2020

cmsbuild added comparison-pending tests-approved and removed comparison-available tests-started labels Jul 1, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 1, 2020

cmsbuild added geometry-approved and removed geometry-pending labels Sep 18, 2020

smuzaffar deleted the revert-30323-Run4-hgx247 branch November 6, 2020 21:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Run4-hgx247 Add some new features for HGCal" #30458

Revert "Run4-hgx247 Add some new features for HGCal" #30458

silviodonato commented Jun 29, 2020

cmsbuild commented Jun 29, 2020

cmsbuild commented Jun 29, 2020 •

edited

Loading

cmsbuild commented Jun 29, 2020

cmsbuild commented Jun 29, 2020

cmsbuild commented Jun 29, 2020

silviodonato commented Jun 30, 2020

cmsbuild commented Jun 30, 2020 •

edited

Loading

cmsbuild commented Jun 30, 2020 •

edited

Loading

cmsbuild commented Jun 30, 2020 •

edited

Loading

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jul 1, 2020 •

edited

Loading

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cvuosalo commented Sep 18, 2020

Revert "Run4-hgx247 Add some new features for HGCal" #30458

Revert "Run4-hgx247 Add some new features for HGCal" #30458

Conversation

silviodonato commented Jun 29, 2020

cmsbuild commented Jun 29, 2020

cmsbuild commented Jun 29, 2020 • edited Loading

cmsbuild commented Jun 29, 2020

cmsbuild commented Jun 29, 2020

cmsbuild commented Jun 29, 2020

silviodonato commented Jun 30, 2020

cmsbuild commented Jun 30, 2020 • edited Loading

cmsbuild commented Jun 30, 2020 • edited Loading

cmsbuild commented Jun 30, 2020 • edited Loading

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jul 1, 2020 • edited Loading

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cvuosalo commented Sep 18, 2020

cmsbuild commented Jun 29, 2020 •

edited

Loading

cmsbuild commented Jun 30, 2020 •

edited

Loading

cmsbuild commented Jun 30, 2020 •

edited

Loading

cmsbuild commented Jun 30, 2020 •

edited

Loading

cmsbuild commented Jul 1, 2020 •

edited

Loading