Phase2-geox02 Make workflow for a version with HGCal V13 #30442

bsunanda · 2020-06-28T16:00:45Z

PR description:

Make workflow (2026D59) for a version with HGCal V13. But the new workflow needs merging of 2 PR's (#30423 and #30428). Also corrects scenarios for 2026D57 and 2026D58 where two files intended to add similar (but not the same) volumes are added

PR validation:.

Tested along with the 2 PR's

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2020-06-28T16:01:08Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-28T16:49:14Z

The code-checks are being triggered in jenkins.

bsunanda · 2020-06-28T16:56:08Z

@cmsbuild Please test

cmsbuild · 2020-06-28T17:02:00Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30442/16555

This PR adds an extra 48KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Geometry/python/GeometryExtended2026D59Reco_cff.py modified in PR(s): Adding geometry scenarios D59 and D60 implementing ETL version 4 and 5 #30340
- File Configuration/Geometry/python/GeometryExtended2026D59_cff.py modified in PR(s): Adding geometry scenarios D59 and D60 implementing ETL version 4 and 5 #30340
- File Configuration/Geometry/python/dict2026Geometry.py modified in PR(s): Adding geometry scenarios D59 and D60 implementing ETL version 4 and 5 #30340, update the tracking material for Phase2 geometry D49 #30126
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): HCAL only wf #30136
- File Configuration/StandardSequences/python/GeometryConf.py modified in PR(s): Adding geometry scenarios D59 and D60 implementing ETL version 4 and 5 #30340
- File Geometry/CMSCommonData/python/cmsExtendedGeometry2026D59XML_cfi.py modified in PR(s): Adding geometry scenarios D59 and D60 implementing ETL version 4 and 5 #30340

cmsbuild · 2020-06-28T17:02:21Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-28-0000/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7465/console Started: 2020/06/28 19:11

cmsbuild · 2020-06-28T17:02:22Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData
Geometry/MuonCommonData

@pgunnell, @civanch, @Dr15Jones, @chayanit, @cvuosalo, @wajidalikhan, @ianna, @mdhildreth, @cmsbuild, @makortel, @franzoni, @silviodonato, @kpedro88, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @vargasa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @lecriste, @ptcox, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2020-06-28T18:27:17Z

+1
Tested at: 0d63639
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f976c0/7465/summary.html
CMSSW: CMSSW_11_2_X_2020-06-28-0000
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-06-28T18:27:20Z

Comparison job queued.

cmsbuild · 2020-06-28T20:16:54Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f976c0/7465/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778915
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778861
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

rovere · 2020-06-29T06:40:38Z

Configuration/Geometry/python/dict2026Geometry.py

+        "reco" :[
+            'from Geometry.ForwardGeometry.ForwardGeometry_cfi import *',
+        ]
+    },
    "F5" : {


Are you sure you want to redefined "F4" key?

Thanks for pointing this out. F4 is copied and pasted twice. I have removed the second one

cmsbuild · 2020-07-02T00:40:49Z

+1
Tested at: 28f015c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f976c0/7578/summary.html
CMSSW: CMSSW_11_2_X_2020-06-30-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-02T00:40:53Z

Comparison job queued.

cmsbuild · 2020-07-02T02:34:09Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f976c0/7578/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2784120
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2784063
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 154 log files, 17 edm output root files, 37 DQM output files

kpedro88 · 2020-07-02T12:47:50Z

+upgrade

chayanit · 2020-07-02T13:12:41Z

+1

bsunanda · 2020-07-02T13:14:47Z

@cvuosalo @ianna Can you approve this PR

cvuosalo · 2020-07-02T16:27:35Z

+1

bsunanda · 2020-07-02T17:28:41Z

@franzoni Could you approve this PR?

kpedro88 · 2020-07-03T03:21:40Z

@silviodonato please approve this so I can rebase #30477

silviodonato · 2020-07-03T12:37:18Z

+1

cmsbuild · 2020-07-03T12:37:40Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Make workflow for a version with HGCal V13

2d0ef03

cmsbuild added this to the CMSSW_11_2_X milestone Jun 28, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending operations-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Jun 28, 2020

Correct the mfshield file

0d63639

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 28, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 28, 2020

cmsbuild added tests-approved and removed tests-started labels Jun 28, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 28, 2020

rovere reviewed Jun 29, 2020

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Jul 2, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 2, 2020

cmsbuild added upgrade-approved and removed upgrade-pending labels Jul 2, 2020

cmsbuild added pdmv-approved and removed pdmv-pending labels Jul 2, 2020

cmsbuild added geometry-approved and removed geometry-pending labels Jul 2, 2020

cmsbuild added fully-signed operations-approved and removed operations-pending orp-pending pending-signatures labels Jul 3, 2020

cmsbuild added the orp-approved label Jul 3, 2020

cmsbuild merged commit dcff25b into cms-sw:master Jul 3, 2020

cmsbuild mentioned this pull request Jul 3, 2020

Bug-fix in L1Trigger/Phase2L1ParticleFlow/python/l1pfJetMet_cff.py #30528

Merged

silviodonato mentioned this pull request Jul 4, 2020

Exception in workflow 27834.0. HGCalTriggerGeometry: Wafer is not mapped to any trigger module #30538

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-geox02 Make workflow for a version with HGCal V13 #30442

Phase2-geox02 Make workflow for a version with HGCal V13 #30442

bsunanda commented Jun 28, 2020

cmsbuild commented Jun 28, 2020

cmsbuild commented Jun 28, 2020

bsunanda commented Jun 28, 2020

cmsbuild commented Jun 28, 2020

cmsbuild commented Jun 28, 2020 •

edited

Loading

cmsbuild commented Jun 28, 2020

cmsbuild commented Jun 28, 2020

cmsbuild commented Jun 28, 2020

cmsbuild commented Jun 28, 2020

rovere Jun 29, 2020

bsunanda Jun 29, 2020

cmsbuild commented Jul 2, 2020

cmsbuild commented Jul 2, 2020

cmsbuild commented Jul 2, 2020

kpedro88 commented Jul 2, 2020

chayanit commented Jul 2, 2020

bsunanda commented Jul 2, 2020

cvuosalo commented Jul 2, 2020

bsunanda commented Jul 2, 2020

kpedro88 commented Jul 3, 2020

silviodonato commented Jul 3, 2020

cmsbuild commented Jul 3, 2020

Phase2-geox02 Make workflow for a version with HGCal V13 #30442

Phase2-geox02 Make workflow for a version with HGCal V13 #30442

Conversation

bsunanda commented Jun 28, 2020

PR description:

PR validation:.

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jun 28, 2020

cmsbuild commented Jun 28, 2020

bsunanda commented Jun 28, 2020

cmsbuild commented Jun 28, 2020

cmsbuild commented Jun 28, 2020 • edited Loading

cmsbuild commented Jun 28, 2020

cmsbuild commented Jun 28, 2020

cmsbuild commented Jun 28, 2020

cmsbuild commented Jun 28, 2020

rovere Jun 29, 2020

Choose a reason for hiding this comment

bsunanda Jun 29, 2020

Choose a reason for hiding this comment

cmsbuild commented Jul 2, 2020

cmsbuild commented Jul 2, 2020

cmsbuild commented Jul 2, 2020

kpedro88 commented Jul 2, 2020

chayanit commented Jul 2, 2020

bsunanda commented Jul 2, 2020

cvuosalo commented Jul 2, 2020

bsunanda commented Jul 2, 2020

kpedro88 commented Jul 3, 2020

silviodonato commented Jul 3, 2020

cmsbuild commented Jul 3, 2020

cmsbuild commented Jun 28, 2020 •

edited

Loading