Update Triton client to version 2.25 #8324

kpedro88 · 2023-02-17T19:32:00Z

This PR updates the Triton client to a newer version. Important changes:

Introduction of multi-request inference interfaces
Includes numerous PRs (from me) repositories to improve the build options, eliminating almost all of the manual patches we previously needed to apply in order to build only the necessary components in CMSSW.

…reamed

cmsbuild · 2023-02-17T19:32:27Z

A new Pull Request was created by @kpedro88 (Kevin Pedro) for branch IB/CMSSW_13_0_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

smuzaffar · 2023-02-18T09:02:07Z

please test with cms-sw/cmssw#40814

restart the tests after correcting the base branch ( 13.1.X )

smuzaffar · 2023-02-18T09:06:58Z

triton-inference-client.spec

-common_tag_2_11_0=249232758855cc764c78a12964c2a5c09c388d87
-mkdir repo-common && pushd repo-common && curl -k -L https://github.com/%{github_user}/common/archive/${common_tag_2_11_0}.tar.gz | tar -xz --strip=1 && popd
+common_tag=d5c561841e9bd0818c40e5153bdb88e98725ee79
+mkdir repo-common && pushd repo-common && curl -k -L https://github.com/%{github_user}/common/archive/${common_tag}.tar.gz | tar -xz --strip=1 && popd


@kpedro88 , I never noticed that we are downloading the sources here. Why not just make this an extra source

%define common_tag d5c561841e9bd0818c40e5153bdb88e98725ee79 Source1: https://github.com/%{github_user}/common/archive/%{common_tag}.tar.gz

this way it will be cached in cmsrep for future use.

thanks for the suggestion, implemented

cmsbuild · 2023-02-18T09:38:28Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da148b/30728/summary.html
COMMIT: 388cdc3
CMSSW: CMSSW_13_0_X_2023-02-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8324/30728/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-02-17-2300/src/HeterogeneousCore/SonicTriton/src/TritonClient.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-02-17-2300/src/HeterogeneousCore/SonicTriton/src/TritonException.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-02-17-2300/src/HeterogeneousCore/SonicTriton/src/TritonMemResource.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-02-17-2300/src/HeterogeneousCore/SonicTriton/src/TritonService.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-02-17-2300/src/HeterogeneousCore/SonicTriton/src/triton_utils.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-02-17-2300/src/HeterogeneousCore/SonicTriton/src/TritonData.cc:7:10: fatal error: model_config.h: No such file or directory
    7 | #include "model_config.h"
      |          ^~~~~~~~~~~~~~~~
compilation terminated.
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-02-17-2300/src/HeterogeneousCore/SonicTriton/src/TritonData.cc:7:10: fatal error: model_config.h: No such file or directory
    7 | #include "model_config.h"

cmsbuild · 2023-02-18T19:01:05Z

Pull request #8324 was updated.

aandvalenzuela · 2023-02-20T07:52:31Z

please test with cms-sw/cmssw#40814

kpedro88 · 2023-02-20T19:47:16Z

@smuzaffar I thought this would get tests-approved automatically when cms-sw/cmssw#40814 passed, since they are tested together. Do we need to specify the whole slew of related PRs everywhere now?

smuzaffar · 2023-02-20T19:59:16Z

@smuzaffar I thought this would get tests-approved automatically when #40814 passed, since they are tested together. Do we need to specify the whole slew of related PRs everywhere now?

yes @kpedro88 since couple of years now :-) every PR should be tested individually to get the test-approved label.

kpedro88 · 2023-02-20T20:00:44Z

test parameters

pull_requests = Ragged batching interface for SonicTriton cmssw#40814, Add model for ragged batching unit test cms-data/HeterogeneousCore-SonicTriton#2, Updated configs to play better with GPU backend cms-data/RecoEgamma-EgammaPhotonProducers#2, Updated model files to play nicely with GPU backend cms-data/RecoEcal-EgammaClusterProducers#3
workflows = 10805.31

kpedro88 · 2023-02-20T20:01:42Z

please test

cmsbuild · 2023-02-21T01:26:35Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da148b/30761/summary.html
COMMIT: ace7b56
CMSSW: CMSSW_13_1_X_2023-02-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8324/30761/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da148b/30761/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da148b/30761/git-merge-result

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

You potentially added 28 lines to the logs
Reco comparison results: 6789 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3631295
DQMHistoTests: Total failures: 11600
DQMHistoTests: Total nulls: 67
DQMHistoTests: Total successes: 3619606
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -641.2850000000002 KiB( 49 files compared)
DQMHistoSizes: changed ( 1000.0,... ): -17.997 KiB JetMET/MET
DQMHistoSizes: changed ( 1000.0,... ): -1.050 KiB Egamma/Electrons
DQMHistoSizes: changed ( 10024.0,... ): -30.041 KiB JetMET/MET
DQMHistoSizes: changed ( 136.7611,... ): -12.044 KiB JetMET/MET
Checked 219 log files, 169 edm output root files, 50 DQM output files
TriggerResults: found differences in 2 / 48 workflows

kpedro88 · 2023-02-21T14:40:46Z

please test

cmsbuild · 2023-02-21T18:20:35Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da148b/30783/summary.html
COMMIT: ace7b56
CMSSW: CMSSW_13_1_X_2023-02-21-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8324/30783/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@jshin96 [PileupJetId, Puppi] Pileup ID input variable fix, puppi weight ValueMap access, optional photon protection for existing puppi weights cmssw#40762
@eyigitba Fix RPC and GEM TP unpacking in EMTF unpacker cmssw#40797
@bsunanda Run3-gex153 GE21 chamber has shifted its position in 2023. Accordingly a new scenario is made for 2023 geometry cmssw#40783

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da148b/30783/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da148b/30783/git-merge-result

Comparison Summary

Summary:

You potentially removed 17 lines from the logs
Reco comparison results: 32 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3631295
DQMHistoTests: Total failures: 42
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3631231
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 219 log files, 169 edm output root files, 50 DQM output files
TriggerResults: no differences found

gartung · 2023-03-01T20:52:39Z

@kpedro88 does this version of triton require a version of grpc newer than 1.35.00?

kpedro88 · 2023-03-01T20:57:05Z

I have not found any need to update the gRPC version.

gartung · 2023-03-01T21:08:04Z

OK. Thanks. I am updating the Fermilab Triton client version and they are trying to build gRPC 1.51.3.

kpedro88 · 2023-03-01T21:12:37Z

The CMS build is very precise about using existing dependencies. The FNAL/ups version may just be picking up defaults from CMake.

perrotta · 2023-03-02T18:24:00Z

+1

perrotta · 2023-03-02T18:32:16Z

merge

kpedro88 added 6 commits February 2, 2023 10:19

update to newest triton release & better cmake flags

821fbd5

fixes related to common

a269559

update to latest triton version w/ most cmake/build improvements upst…

efe6bf6

…reamed

get additional lib

9243edf

remove now-unneeded modification (fixed upstream in protobuf)

863e3a4

move to newer version w/ googletest removal

388cdc3

cmsbuild added tests-pending externals-pending pending-signatures orp-pending labels Feb 17, 2023

kpedro88 mentioned this pull request Feb 17, 2023

Ragged batching interface for SonicTriton cms-sw/cmssw#40814

Merged

cmsbuild added tests-started requires-external and removed tests-pending labels Feb 18, 2023

smuzaffar changed the base branch from IB/CMSSW_13_0_X/master to IB/CMSSW_13_1_X/master February 18, 2023 09:01

smuzaffar reviewed Feb 18, 2023

View reviewed changes

cmsbuild added tests-rejected and removed tests-started labels Feb 18, 2023

move common repo to source1

ace7b56

cmsbuild added tests-pending and removed tests-rejected requires-external labels Feb 18, 2023

cmsbuild added tests-started requires-external and removed tests-pending labels Feb 20, 2023

cmsbuild added the tests-rejected label Feb 20, 2023

cmsbuild added tests-started and removed tests-rejected labels Feb 20, 2023

cmsbuild added tests-rejected and removed tests-started labels Feb 21, 2023

cmsbuild added tests-started and removed tests-rejected labels Feb 21, 2023

cmsbuild added tests-approved and removed tests-started labels Feb 21, 2023

cmsbuild added orp-approved and removed orp-pending labels Mar 2, 2023

cmsbuild merged commit da8f168 into cms-sw:IB/CMSSW_13_1_X/master Mar 2, 2023

This was referenced Mar 2, 2023

[BuildRules] Enable alpaka ROCm backend #8346

Merged

Fix weights to be identical to original commit cms-data/RecoEgamma-EgammaPhotonProducers#3

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Triton client to version 2.25 #8324

Update Triton client to version 2.25 #8324

kpedro88 commented Feb 17, 2023

cmsbuild commented Feb 17, 2023

smuzaffar commented Feb 18, 2023

smuzaffar Feb 18, 2023

kpedro88 Feb 18, 2023

cmsbuild commented Feb 18, 2023

cmsbuild commented Feb 18, 2023

aandvalenzuela commented Feb 20, 2023

kpedro88 commented Feb 20, 2023 •

edited

Loading

smuzaffar commented Feb 20, 2023 •

edited

Loading

kpedro88 commented Feb 20, 2023 •

edited

Loading

kpedro88 commented Feb 20, 2023

cmsbuild commented Feb 21, 2023

kpedro88 commented Feb 21, 2023

cmsbuild commented Feb 21, 2023

gartung commented Mar 1, 2023

kpedro88 commented Mar 1, 2023

gartung commented Mar 1, 2023

kpedro88 commented Mar 1, 2023

perrotta commented Mar 2, 2023

perrotta commented Mar 2, 2023

Update Triton client to version 2.25 #8324

Update Triton client to version 2.25 #8324

Conversation

kpedro88 commented Feb 17, 2023

cmsbuild commented Feb 17, 2023

smuzaffar commented Feb 18, 2023

smuzaffar Feb 18, 2023

Choose a reason for hiding this comment

kpedro88 Feb 18, 2023

Choose a reason for hiding this comment

cmsbuild commented Feb 18, 2023

Build

cmsbuild commented Feb 18, 2023

aandvalenzuela commented Feb 20, 2023

kpedro88 commented Feb 20, 2023 • edited Loading

smuzaffar commented Feb 20, 2023 • edited Loading

kpedro88 commented Feb 20, 2023 • edited Loading

kpedro88 commented Feb 20, 2023

cmsbuild commented Feb 21, 2023

RelVals-INPUT

Comparison Summary

kpedro88 commented Feb 21, 2023

cmsbuild commented Feb 21, 2023

Comparison Summary

gartung commented Mar 1, 2023

kpedro88 commented Mar 1, 2023

gartung commented Mar 1, 2023

kpedro88 commented Mar 1, 2023

perrotta commented Mar 2, 2023

perrotta commented Mar 2, 2023

kpedro88 commented Feb 20, 2023 •

edited

Loading

smuzaffar commented Feb 20, 2023 •

edited

Loading

kpedro88 commented Feb 20, 2023 •

edited

Loading