Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated configs to play better with GPU backend #2

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

ssrothman
Copy link
Contributor

@kpedro88 notified me that the torchscript configs in this repo were not compatible with the Sonic Pytorch GPU backend. This update fixes this compatibility. Note that none of the weights or actual model behavior have changed. This is just a minor syntactic change in the torchscript code.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2023

A new Pull Request was created by @ssrothman for branch main.

@smuzaffar, @aandvalenzuela, @iarspider, @clacaputo, @cmsbuild, @mandrenguyen can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #2 was updated.

Revert broken empty inputs hack
@cmsbuild
Copy link
Contributor

Pull request #2 was updated.

@kpedro88
Copy link
Contributor

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27d3e7/30763/summary.html
COMMIT: 9c3b47e
CMSSW: CMSSW_13_1_X_2023-02-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/RecoEgamma-EgammaPhotonProducers/2/30763/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27d3e7/30763/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27d3e7/30763/git-merge-result

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 6790 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3631295
  • DQMHistoTests: Total failures: 11596
  • DQMHistoTests: Total nulls: 67
  • DQMHistoTests: Total successes: 3619610
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -641.2850000000002 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): -17.997 KiB JetMET/MET
  • DQMHistoSizes: changed ( 1000.0,... ): -1.050 KiB Egamma/Electrons
  • DQMHistoSizes: changed ( 10024.0,... ): -30.041 KiB JetMET/MET
  • DQMHistoSizes: changed ( 136.7611,... ): -12.044 KiB JetMET/MET
  • Checked 219 log files, 169 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 2 / 48 workflows

@smuzaffar
Copy link
Contributor

+externals

@perrotta
Copy link

perrotta commented Mar 2, 2023

+1

@perrotta
Copy link

perrotta commented Mar 2, 2023

@cms-sw/reconstruction-l2 we must bypass your signature because the PR that need this external was already merged, sorry for that. Follow up in issue cms-sw/cmssw#40938

@perrotta
Copy link

perrotta commented Mar 2, 2023

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants