Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model for ragged batching unit test #2

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Conversation

kpedro88
Copy link
Contributor

These data files are needed for the new unit test for ragged batching.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for branch main.

@smuzaffar, @makortel, @aandvalenzuela, @iarspider, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6427a7/30762/summary.html
COMMIT: 03f799f
CMSSW: CMSSW_13_1_X_2023-02-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/HeterogeneousCore-SonicTriton/2/30762/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6427a7/30762/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6427a7/30762/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 13 lines from the logs
  • Reco comparison results: 6781 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3528709
  • DQMHistoTests: Total failures: 11500
  • DQMHistoTests: Total nulls: 67
  • DQMHistoTests: Total successes: 3517120
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -610.1940000000002 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): -17.997 KiB JetMET/MET
  • DQMHistoSizes: changed ( 1000.0,... ): -1.050 KiB Egamma/Electrons
  • DQMHistoSizes: changed ( 10024.0,... ): -30.041 KiB JetMET/MET
  • DQMHistoSizes: changed ( 136.7611,... ): -12.044 KiB JetMET/MET
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 2 / 47 workflows

@makortel
Copy link

makortel commented Mar 1, 2023

+heterogeneous

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

This pull request is fully signed and it will be integrated in one of the next main IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link

perrotta commented Mar 2, 2023

+1

  • New datafiles added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants