Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated model files to play nicely with GPU backend #3

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Updated model files to play nicely with GPU backend #3

merged 1 commit into from
Mar 2, 2023

Conversation

ssrothman
Copy link

Analogous to cms-data/RecoEgamma-EgammaPhotonProducers#2

Updates model configs to play nicely with SonicTriton pytorch GPU backend

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2023

A new Pull Request was created by @ssrothman for branch main.

@smuzaffar, @aandvalenzuela, @iarspider, @clacaputo, @cmsbuild, @mandrenguyen can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2023

Pull request #3 was updated.

@ssrothman ssrothman marked this pull request as draft February 8, 2023 19:10
@cmsbuild
Copy link
Contributor

Pull request #3 was updated.

1 similar comment
@cmsbuild
Copy link
Contributor

Pull request #3 was updated.

@kpedro88 kpedro88 mentioned this pull request Feb 17, 2023
Merged
@ssrothman
Updated model files to play nicely with GPU backend
de1af2c 
Actual correct model files

Actual actual correct model files

Name the model files correctly (smh)
@cmsbuild
Copy link
Contributor

Pull request #3 was updated.

@ssrothman ssrothman marked this pull request as ready for review February 19, 2023 01:57
This was referenced Feb 20, 2023
Merged
Merged
Merged
@kpedro88
Copy link
Contributor

test parameters

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad17d5/30764/summary.html
COMMIT: de1af2c
CMSSW: CMSSW_13_1_X_2023-02-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/RecoEcal-EgammaClusterProducers/3/30764/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad17d5/30764/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad17d5/30764/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 6781 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3528709
  • DQMHistoTests: Total failures: 11500
  • DQMHistoTests: Total nulls: 67
  • DQMHistoTests: Total successes: 3517120
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -610.1940000000002 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): -17.997 KiB JetMET/MET
  • DQMHistoSizes: changed ( 1000.0,... ): -1.050 KiB Egamma/Electrons
  • DQMHistoSizes: changed ( 10024.0,... ): -30.041 KiB JetMET/MET
  • DQMHistoSizes: changed ( 136.7611,... ): -12.044 KiB JetMET/MET
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 2 / 47 workflows

@smuzaffar
Copy link
Contributor

+externals

@perrotta
Copy link

perrotta commented Mar 2, 2023

+1

@perrotta
Copy link

perrotta commented Mar 2, 2023

@cms-sw/reconstruction-l2 we must bypass your signature because the PR that need this external was already merged, sorry for that. Follow up in issue cms-sw/cmssw#40938

@perrotta
Copy link

perrotta commented Mar 2, 2023

merge

@cmsbuild cmsbuild merged commit 5d5978e into cms-data:main Mar 2, 2023
@cmsbuild cmsbuild mentioned this pull request Mar 2, 2023
Merged
@perrotta perrotta mentioned this pull request Mar 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-approved orp-approved pending-signatures reconstruction-pending requires-external tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ssrothman @cmsbuild @kpedro88 @smuzaffar @perrotta