Run3-gex153 GE21 chamber has shifted its position in 2023. Accordingly a new scenario is made for 2023 geometry

[bsunanda]

PR description:

GE21 chamberhas shifted its position in 2023. Accordingly a new scenario is made for 2023 geometry

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be decided if it needs to be back ported

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40783/34215

• This PR adds an extra 44KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Configuration/Geometry (geometry, upgrade)
• Configuration/StandardSequences (operations)
• Geometry/CMSCommonData (geometry, upgrade)
• Geometry/MuonCommonData (geometry)

@perrotta, @rappoccio, @Dr15Jones, @bsunanda, @makortel, @civanch, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @vargasa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @kpedro88, @ptcox, @mmusich, @sameasy, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[srimanob]

Is the geometry expected for 2023 MC?
FYI @cms-sw/pdmv-l2

[kskovpen]

Just to mention that we are using the 2021 geometry in the MC production (which is the only one available). Is this geometry meant to be included in 2023 MC?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3bed83/30668/summary.html
COMMIT: 24cb741
CMSSW: CMSSW_13_1_X_2023-02-16-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40783/30668/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 12 lines from the logs
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3556272
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3556247
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[bsunanda]

I believe this will be official 2023 Geometry.

[bsunanda]

+geometry

[civanch]

@bsunanda , is it correct that dict2021Geometry includes 2023 gem entry?

[bsunanda]

Strictly speaking, we have 2 dictionaries one for Run3 and one for Run4. They are names 2021 and 2026 - maybe we can change the names later. I shall ask Kevin about this. It is he who introduced this

[civanch]

In the next technical stop the geometry will changed again. May be correct to keep dictionary for 2021 unchanged and create 2023? I mean that if we keep updating the dictionary would we need to to use it for 2022 geometry? Likely no....

[bsunanda]

We can always add a new version in the dictionary. We can always define a new scenario with a suitable combination. That is why the dictionary is good. I doubt if things will change during any technical stop. It will change most likely in the next YETS for 2024. That can be easily accommodated in this scheme.

[bsunanda]

@srimanob Please approve this

[srimanob]

+Upgrade

[perrotta]

@bsunanda there is one workflow among the tested ones which refers to 2023:

• 12434.0_TTbar_14TeV+2023

Shouldn't this updated GEM geometry get propagated to it? If I am not wrong this is not (yet) the case. Is it possible to customize a test workflow (e.g. that 12434) to include this scenario, and verify as such that it works?

[srimanob]

Hi @perrotta
After DB is available? Since we use DB:Extended for Run-3 geometry.
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py#L2282-L2288

[bsunanda]

Once this PR gets integrated we can start making payload for DB

…

________________________________ From: Phat Srimanobhas ***@***.*** Sent: 21 February 2023 10:04 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] Run3-gex153 GE21 chamber has shifted its position in 2023. Accordingly a new scenario is made for 2023 geometry (PR #40783) Hi @perrotta<https://github.com/perrotta> After DB is available? Since we use DB:Extended for Run-3 geometry. https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py#L2282-L2288 — Reply to this email directly, view it on GitHub<#40783 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOWI4XERYDZTZWBGUBLWYSAKHANCNFSM6AAAAAAU6BOSDQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[perrotta]

Ok, clear.
Then, how did you test this new geometry? Was it ever validated?

[bsunanda]

I ran the overlap checks and ran on a private test script for the SIM step.

…

________________________________ From: Andrea Perrotta ***@***.*** Sent: 21 February 2023 11:03 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] Run3-gex153 GE21 chamber has shifted its position in 2023. Accordingly a new scenario is made for 2023 geometry (PR #40783) Ok, clear. Then, how did you test this new geometry? Was it ever validated? — Reply to this email directly, view it on GitHub<#40783 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZORAPED645DOAZZTM33WYSHGBANCNFSM6AAAAAAU6BOSDQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[perrotta]

+1

• Taking the private checks reported by @bsunanda for good
• Of course, before using for 2023 a complete validation by the GEM group is mandatory

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.